linux/drivers/net
Simon Horman e7214663e0 net: txgbe: Avoid passing uninitialised parameter to pci_wake_from_d3()
txgbe_shutdown() relies on txgbe_dev_shutdown() to initialise
wake by passing it by reference. However, txgbe_dev_shutdown()
doesn't use this parameter at all.

wake is then passed uninitialised by txgbe_dev_shutdown()
to pci_wake_from_d3().

Resolve this problem by:
* Removing the unused parameter from txgbe_dev_shutdown()
* Removing the uninitialised variable wake from txgbe_dev_shutdown()
* Passing false to pci_wake_from_d3() - this assumes that
  although uninitialised wake was in practice false (0).

I'm not sure that this counts as a bug, as I'm not sure that
it manifests in any unwanted behaviour. But in any case, the issue
was introduced by:

  3ce7547e5b ("net: txgbe: Add build support for txgbe")

Flagged by Smatch as:

  .../txgbe_main.c:486 txgbe_shutdown() error: uninitialized symbol 'wake'.

No functional change intended.
Compile tested only.

Signed-off-by: Simon Horman <horms@kernel.org>
Reviewed-by: Jiawen Wu <jiawenwu@trustnetic.com>
Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
2023-06-07 12:28:58 +01:00
..
appletalk
arcnet
bonding Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2023-05-25 19:57:39 -07:00
caif
can Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2023-05-18 14:39:34 -07:00
dsa net: dsa: qca8k: remove unnecessary (void*) conversions 2023-06-07 12:26:19 +01:00
ethernet net: txgbe: Avoid passing uninitialised parameter to pci_wake_from_d3() 2023-06-07 12:28:58 +01:00
fddi
fjes
hamradio hamradio: drop ISA_DMA_API dependency 2023-04-19 13:11:41 +01:00
hippi
hyperv hv_netvsc: Allocate rx indirection table size dynamically 2023-06-07 09:46:49 +01:00
ieee802154 spi: Updates for v6.4 2023-04-27 11:02:26 -07:00
ipa net: ipa: Use correct value for IPA_STATUS_SIZE 2023-06-01 13:29:18 +02:00
ipvlan ipvlan: Remove NULL check before dev_{put, hold} 2023-05-12 08:56:57 +01:00
mctp
mdio net: mdio: Introduce a regmap-based mdio driver 2023-06-05 09:56:36 +01:00
netdevsim
pcs net: pcs: xpcs: remove xpcs_create() from public view 2023-06-05 11:26:02 +01:00
phy net: phy: realtek: Disable clock on suspend 2023-06-07 09:52:24 +01:00
plip
ppp net/pppoe: fix a typo for the PPPOE_HASH_BITS_1 definition 2023-06-06 13:28:30 +02:00
pse-pd
slip
team net: fix stack overflow when LRO is disabled for virtual interfaces 2023-05-19 22:46:37 -07:00
thunderbolt
usb net: usb: qmi_wwan: Set DTR quirk for BroadMobi BM818 2023-05-29 22:03:48 -07:00
vmxnet3 net: introduce and use skb_frag_fill_page_desc() 2023-05-13 19:47:56 +01:00
vxlan net: vxlan: Add nolocalbypass option to vxlan. 2023-05-13 17:02:33 +01:00
wan spi: Updates for v6.4 2023-04-27 11:02:26 -07:00
wireguard
wireless Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2023-05-18 14:39:34 -07:00
wwan Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2023-05-18 14:39:34 -07:00
xen-netback net: introduce and use skb_frag_fill_page_desc() 2023-05-13 19:47:56 +01:00
amt.c
bareudp.c
dummy.c
eql.c
geneve.c
gtp.c
ifb.c
Kconfig net: veth: make PAGE_POOL_STATS optional 2023-05-10 09:57:39 +01:00
LICENSE.SRC
loopback.c
macsec.c macsec: Don't rely solely on the dst MAC address to identify destination MACsec device 2023-04-21 08:22:15 +01:00
macvlan.c
macvtap.c
Makefile
mdio.c
mhi_net.c
mii.c
net_failover.c
netconsole.c
nlmon.c
ntb_netdev.c
rionet.c
sb1000.c
Space.c
sungem_phy.c
tap.c net: add vlan_get_protocol_and_depth() helper 2023-05-10 10:25:55 +01:00
tun.c tun: Fix memory leak for detached NAPI queue. 2023-05-17 09:02:55 +01:00
veth.c net: veth: make PAGE_POOL_STATS optional 2023-05-10 09:57:39 +01:00
virtio_net.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2023-05-18 14:39:34 -07:00
vrf.c
vsockmon.c
xen-netfront.c