mirror of
https://github.com/torvalds/linux.git
synced 2024-11-05 19:41:54 +00:00
7ea6fd7e2d
The "bestcomm-core" driver defines its of_match table as follows
static struct of_device_id mpc52xx_bcom_of_match[] = {
{ .type = "dma-controller", .compatible = "fsl,mpc5200-bestcomm", },
{ .type = "dma-controller", .compatible = "mpc5200-bestcomm", },
{},
};
so while registering the driver, the driver's probe function won't be
called, because the device tree node doesn't have a device_type
property. Thus the driver's bcom_engine structure won't be allocated.
Referencing this structure later causes observed Oops.
Checking bcom_eng pointer for NULL before referencing data pointed
by it prevents oopsing, but fec driver still doesn't work (because
of the lost bestcomm match and resulted task allocation failure).
Actually the compatible property exists and should match and so
the fec driver should work.
This removes .type = "dma-controller" from the bestcomm driver's
mpc52xx_bcom_of_match table to solve the problem.
Signed-off-by: Anatolij Gustschin <agust@denx.de>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
Signed-off-by: Paul Mackerras <paulus@samba.org>
|
||
|---|---|---|
| .. | ||
| ata.c | ||
| ata.h | ||
| bcom_ata_task.c | ||
| bcom_fec_rx_task.c | ||
| bcom_fec_tx_task.c | ||
| bcom_gen_bd_rx_task.c | ||
| bcom_gen_bd_tx_task.c | ||
| bestcomm_priv.h | ||
| bestcomm.c | ||
| bestcomm.h | ||
| fec.c | ||
| fec.h | ||
| gen_bd.c | ||
| gen_bd.h | ||
| Kconfig | ||
| Makefile | ||
| sram.c | ||
| sram.h | ||