mirror of
https://github.com/torvalds/linux.git
synced 2024-12-13 06:32:50 +00:00
1cb3b0095c
The following warning was observed when attempting to suspend to disk using a USB flash as a swap device. [ 111.779649] ------------[ cut here ]------------ [ 111.788382] URB (____ptrval____) submitted while active [ 111.796646] WARNING: CPU: 3 PID: 365 at drivers/usb/core/urb.c:363 usb_submit_urb+0x3d8/0x590 [ 111.805417] Modules linked in: [ 111.808584] CPU: 3 PID: 365 Comm: kworker/3:2 Not tainted 5.6.0-rc6-00002-gdfd1731f9a3e-dirty #545 [ 111.817796] Hardware name: ARM Juno development board (r2) (DT) [ 111.823896] Workqueue: usb_hub_wq hub_event [ 111.828217] pstate: 60000005 (nZCv daif -PAN -UAO) [ 111.833156] pc : usb_submit_urb+0x3d8/0x590 [ 111.837471] lr : usb_submit_urb+0x3d8/0x590 [ 111.841783] sp : ffff800018de38b0 [ 111.845205] x29: ffff800018de38b0 x28: 0000000000000003 [ 111.850682] x27: ffff000970530b20 x26: ffff8000133fd000 [ 111.856159] x25: ffff8000133fd000 x24: ffff800018de3b38 [ 111.861635] x23: 0000000000000004 x22: 0000000000000c00 [ 111.867112] x21: 0000000000000000 x20: 00000000fffffff0 [ 111.872589] x19: ffff0009704e7a00 x18: ffffffffffffffff [ 111.878065] x17: 00000000a7c8f4bc x16: 000000002af33de8 [ 111.883542] x15: ffff8000133fda88 x14: 0720072007200720 [ 111.889019] x13: 0720072007200720 x12: 0720072007200720 [ 111.894496] x11: 0000000000000000 x10: 00000000a5286134 [ 111.899973] x9 : 0000000000000002 x8 : ffff000970c837a0 [ 111.905449] x7 : 0000000000000000 x6 : ffff800018de3570 [ 111.910926] x5 : 0000000000000001 x4 : 0000000000000003 [ 111.916401] x3 : 0000000000000000 x2 : ffff800013427118 [ 111.921879] x1 : 9d4e965b4b7d7c00 x0 : 0000000000000000 [ 111.927356] Call trace: [ 111.929892] usb_submit_urb+0x3d8/0x590 [ 111.933852] hub_activate+0x108/0x7f0 [ 111.937633] hub_resume+0xac/0x148 [ 111.941149] usb_resume_interface.isra.10+0x60/0x138 [ 111.946265] usb_resume_both+0xe4/0x140 [ 111.950225] usb_runtime_resume+0x24/0x30 [ 111.954365] __rpm_callback+0xdc/0x138 [ 111.958236] rpm_callback+0x34/0x98 [ 111.961841] rpm_resume+0x4a8/0x720 [ 111.965445] rpm_resume+0x50c/0x720 [ 111.969049] __pm_runtime_resume+0x4c/0xb8 [ 111.973276] usb_autopm_get_interface+0x28/0x60 [ 111.977948] hub_event+0x80/0x16d8 [ 111.981466] process_one_work+0x2a4/0x748 [ 111.985604] worker_thread+0x48/0x498 [ 111.989387] kthread+0x13c/0x140 [ 111.992725] ret_from_fork+0x10/0x18 [ 111.996415] irq event stamp: 354 [ 111.999756] hardirqs last enabled at (353): [<ffff80001019ea1c>] console_unlock+0x504/0x5b8 [ 112.008441] hardirqs last disabled at (354): [<ffff8000100a95d0>] do_debug_exception+0x1a8/0x258 [ 112.017479] softirqs last enabled at (350): [<ffff8000100818a4>] __do_softirq+0x4bc/0x568 [ 112.025984] softirqs last disabled at (343): [<ffff8000101145a4>] irq_exit+0x144/0x150 [ 112.034129] ---[ end trace dc96030b9cf6c8a3 ]--- The problem was tracked down to a missing call to pm_runtime_set_active() on resume in ohci-platform. Link: https://lore.kernel.org/lkml/20200323143857.db5zphxhq4hz3hmd@e107158-lin.cambridge.arm.com/ Acked-by: Alan Stern <stern@rowland.harvard.edu> Signed-off-by: Qais Yousef <qais.yousef@arm.com> CC: Tony Prisk <linux@prisktech.co.nz> CC: Greg Kroah-Hartman <gregkh@linuxfoundation.org> CC: Mathias Nyman <mathias.nyman@intel.com> CC: Oliver Neukum <oneukum@suse.de> CC: linux-arm-kernel@lists.infradead.org CC: linux-usb@vger.kernel.org CC: linux-kernel@vger.kernel.org Link: https://lore.kernel.org/r/20200518154931.6144-1-qais.yousef@arm.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
362 lines
8.6 KiB
C
362 lines
8.6 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Generic platform ohci driver
|
|
*
|
|
* Copyright 2007 Michael Buesch <m@bues.ch>
|
|
* Copyright 2011-2012 Hauke Mehrtens <hauke@hauke-m.de>
|
|
* Copyright 2014 Hans de Goede <hdegoede@redhat.com>
|
|
*
|
|
* Derived from the OCHI-SSB driver
|
|
* Derived from the OHCI-PCI driver
|
|
* Copyright 1999 Roman Weissgaerber
|
|
* Copyright 2000-2002 David Brownell
|
|
* Copyright 1999 Linus Torvalds
|
|
* Copyright 1999 Gregory P. Smith
|
|
*/
|
|
|
|
#include <linux/clk.h>
|
|
#include <linux/dma-mapping.h>
|
|
#include <linux/hrtimer.h>
|
|
#include <linux/io.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/err.h>
|
|
#include <linux/of.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/pm_runtime.h>
|
|
#include <linux/reset.h>
|
|
#include <linux/usb/ohci_pdriver.h>
|
|
#include <linux/usb.h>
|
|
#include <linux/usb/hcd.h>
|
|
|
|
#include "ohci.h"
|
|
|
|
#define DRIVER_DESC "OHCI generic platform driver"
|
|
#define OHCI_MAX_CLKS 3
|
|
#define hcd_to_ohci_priv(h) ((struct ohci_platform_priv *)hcd_to_ohci(h)->priv)
|
|
|
|
struct ohci_platform_priv {
|
|
struct clk *clks[OHCI_MAX_CLKS];
|
|
struct reset_control *resets;
|
|
};
|
|
|
|
static const char hcd_name[] = "ohci-platform";
|
|
|
|
static int ohci_platform_power_on(struct platform_device *dev)
|
|
{
|
|
struct usb_hcd *hcd = platform_get_drvdata(dev);
|
|
struct ohci_platform_priv *priv = hcd_to_ohci_priv(hcd);
|
|
int clk, ret;
|
|
|
|
for (clk = 0; clk < OHCI_MAX_CLKS && priv->clks[clk]; clk++) {
|
|
ret = clk_prepare_enable(priv->clks[clk]);
|
|
if (ret)
|
|
goto err_disable_clks;
|
|
}
|
|
|
|
return 0;
|
|
|
|
err_disable_clks:
|
|
while (--clk >= 0)
|
|
clk_disable_unprepare(priv->clks[clk]);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static void ohci_platform_power_off(struct platform_device *dev)
|
|
{
|
|
struct usb_hcd *hcd = platform_get_drvdata(dev);
|
|
struct ohci_platform_priv *priv = hcd_to_ohci_priv(hcd);
|
|
int clk;
|
|
|
|
for (clk = OHCI_MAX_CLKS - 1; clk >= 0; clk--)
|
|
if (priv->clks[clk])
|
|
clk_disable_unprepare(priv->clks[clk]);
|
|
}
|
|
|
|
static struct hc_driver __read_mostly ohci_platform_hc_driver;
|
|
|
|
static const struct ohci_driver_overrides platform_overrides __initconst = {
|
|
.product_desc = "Generic Platform OHCI controller",
|
|
.extra_priv_size = sizeof(struct ohci_platform_priv),
|
|
};
|
|
|
|
static struct usb_ohci_pdata ohci_platform_defaults = {
|
|
.power_on = ohci_platform_power_on,
|
|
.power_suspend = ohci_platform_power_off,
|
|
.power_off = ohci_platform_power_off,
|
|
};
|
|
|
|
static int ohci_platform_probe(struct platform_device *dev)
|
|
{
|
|
struct usb_hcd *hcd;
|
|
struct resource *res_mem;
|
|
struct usb_ohci_pdata *pdata = dev_get_platdata(&dev->dev);
|
|
struct ohci_platform_priv *priv;
|
|
struct ohci_hcd *ohci;
|
|
int err, irq, clk = 0;
|
|
|
|
if (usb_disabled())
|
|
return -ENODEV;
|
|
|
|
/*
|
|
* Use reasonable defaults so platforms don't have to provide these
|
|
* with DT probing on ARM.
|
|
*/
|
|
if (!pdata)
|
|
pdata = &ohci_platform_defaults;
|
|
|
|
err = dma_coerce_mask_and_coherent(&dev->dev, DMA_BIT_MASK(32));
|
|
if (err)
|
|
return err;
|
|
|
|
irq = platform_get_irq(dev, 0);
|
|
if (irq < 0)
|
|
return irq;
|
|
|
|
hcd = usb_create_hcd(&ohci_platform_hc_driver, &dev->dev,
|
|
dev_name(&dev->dev));
|
|
if (!hcd)
|
|
return -ENOMEM;
|
|
|
|
platform_set_drvdata(dev, hcd);
|
|
dev->dev.platform_data = pdata;
|
|
priv = hcd_to_ohci_priv(hcd);
|
|
ohci = hcd_to_ohci(hcd);
|
|
|
|
if (pdata == &ohci_platform_defaults && dev->dev.of_node) {
|
|
if (of_property_read_bool(dev->dev.of_node, "big-endian-regs"))
|
|
ohci->flags |= OHCI_QUIRK_BE_MMIO;
|
|
|
|
if (of_property_read_bool(dev->dev.of_node, "big-endian-desc"))
|
|
ohci->flags |= OHCI_QUIRK_BE_DESC;
|
|
|
|
if (of_property_read_bool(dev->dev.of_node, "big-endian"))
|
|
ohci->flags |= OHCI_QUIRK_BE_MMIO | OHCI_QUIRK_BE_DESC;
|
|
|
|
if (of_property_read_bool(dev->dev.of_node, "no-big-frame-no"))
|
|
ohci->flags |= OHCI_QUIRK_FRAME_NO;
|
|
|
|
if (of_property_read_bool(dev->dev.of_node,
|
|
"remote-wakeup-connected"))
|
|
ohci->hc_control = OHCI_CTRL_RWC;
|
|
|
|
of_property_read_u32(dev->dev.of_node, "num-ports",
|
|
&ohci->num_ports);
|
|
|
|
for (clk = 0; clk < OHCI_MAX_CLKS; clk++) {
|
|
priv->clks[clk] = of_clk_get(dev->dev.of_node, clk);
|
|
if (IS_ERR(priv->clks[clk])) {
|
|
err = PTR_ERR(priv->clks[clk]);
|
|
if (err == -EPROBE_DEFER)
|
|
goto err_put_clks;
|
|
priv->clks[clk] = NULL;
|
|
break;
|
|
}
|
|
}
|
|
|
|
priv->resets = devm_reset_control_array_get_optional_shared(
|
|
&dev->dev);
|
|
if (IS_ERR(priv->resets)) {
|
|
err = PTR_ERR(priv->resets);
|
|
goto err_put_clks;
|
|
}
|
|
|
|
err = reset_control_deassert(priv->resets);
|
|
if (err)
|
|
goto err_put_clks;
|
|
}
|
|
|
|
if (pdata->big_endian_desc)
|
|
ohci->flags |= OHCI_QUIRK_BE_DESC;
|
|
if (pdata->big_endian_mmio)
|
|
ohci->flags |= OHCI_QUIRK_BE_MMIO;
|
|
if (pdata->no_big_frame_no)
|
|
ohci->flags |= OHCI_QUIRK_FRAME_NO;
|
|
if (pdata->num_ports)
|
|
ohci->num_ports = pdata->num_ports;
|
|
|
|
#ifndef CONFIG_USB_OHCI_BIG_ENDIAN_MMIO
|
|
if (ohci->flags & OHCI_QUIRK_BE_MMIO) {
|
|
dev_err(&dev->dev,
|
|
"Error: CONFIG_USB_OHCI_BIG_ENDIAN_MMIO not set\n");
|
|
err = -EINVAL;
|
|
goto err_reset;
|
|
}
|
|
#endif
|
|
#ifndef CONFIG_USB_OHCI_BIG_ENDIAN_DESC
|
|
if (ohci->flags & OHCI_QUIRK_BE_DESC) {
|
|
dev_err(&dev->dev,
|
|
"Error: CONFIG_USB_OHCI_BIG_ENDIAN_DESC not set\n");
|
|
err = -EINVAL;
|
|
goto err_reset;
|
|
}
|
|
#endif
|
|
|
|
pm_runtime_set_active(&dev->dev);
|
|
pm_runtime_enable(&dev->dev);
|
|
if (pdata->power_on) {
|
|
err = pdata->power_on(dev);
|
|
if (err < 0)
|
|
goto err_reset;
|
|
}
|
|
|
|
res_mem = platform_get_resource(dev, IORESOURCE_MEM, 0);
|
|
hcd->regs = devm_ioremap_resource(&dev->dev, res_mem);
|
|
if (IS_ERR(hcd->regs)) {
|
|
err = PTR_ERR(hcd->regs);
|
|
goto err_power;
|
|
}
|
|
hcd->rsrc_start = res_mem->start;
|
|
hcd->rsrc_len = resource_size(res_mem);
|
|
|
|
err = usb_add_hcd(hcd, irq, IRQF_SHARED);
|
|
if (err)
|
|
goto err_power;
|
|
|
|
device_wakeup_enable(hcd->self.controller);
|
|
|
|
platform_set_drvdata(dev, hcd);
|
|
|
|
return err;
|
|
|
|
err_power:
|
|
if (pdata->power_off)
|
|
pdata->power_off(dev);
|
|
err_reset:
|
|
pm_runtime_disable(&dev->dev);
|
|
reset_control_assert(priv->resets);
|
|
err_put_clks:
|
|
while (--clk >= 0)
|
|
clk_put(priv->clks[clk]);
|
|
|
|
if (pdata == &ohci_platform_defaults)
|
|
dev->dev.platform_data = NULL;
|
|
|
|
usb_put_hcd(hcd);
|
|
|
|
return err;
|
|
}
|
|
|
|
static int ohci_platform_remove(struct platform_device *dev)
|
|
{
|
|
struct usb_hcd *hcd = platform_get_drvdata(dev);
|
|
struct usb_ohci_pdata *pdata = dev_get_platdata(&dev->dev);
|
|
struct ohci_platform_priv *priv = hcd_to_ohci_priv(hcd);
|
|
int clk;
|
|
|
|
pm_runtime_get_sync(&dev->dev);
|
|
usb_remove_hcd(hcd);
|
|
|
|
if (pdata->power_off)
|
|
pdata->power_off(dev);
|
|
|
|
reset_control_assert(priv->resets);
|
|
|
|
for (clk = 0; clk < OHCI_MAX_CLKS && priv->clks[clk]; clk++)
|
|
clk_put(priv->clks[clk]);
|
|
|
|
usb_put_hcd(hcd);
|
|
|
|
pm_runtime_put_sync(&dev->dev);
|
|
pm_runtime_disable(&dev->dev);
|
|
|
|
if (pdata == &ohci_platform_defaults)
|
|
dev->dev.platform_data = NULL;
|
|
|
|
return 0;
|
|
}
|
|
|
|
#ifdef CONFIG_PM_SLEEP
|
|
static int ohci_platform_suspend(struct device *dev)
|
|
{
|
|
struct usb_hcd *hcd = dev_get_drvdata(dev);
|
|
struct usb_ohci_pdata *pdata = dev->platform_data;
|
|
struct platform_device *pdev = to_platform_device(dev);
|
|
bool do_wakeup = device_may_wakeup(dev);
|
|
int ret;
|
|
|
|
ret = ohci_suspend(hcd, do_wakeup);
|
|
if (ret)
|
|
return ret;
|
|
|
|
if (pdata->power_suspend)
|
|
pdata->power_suspend(pdev);
|
|
|
|
return ret;
|
|
}
|
|
|
|
static int ohci_platform_resume(struct device *dev)
|
|
{
|
|
struct usb_hcd *hcd = dev_get_drvdata(dev);
|
|
struct usb_ohci_pdata *pdata = dev_get_platdata(dev);
|
|
struct platform_device *pdev = to_platform_device(dev);
|
|
|
|
if (pdata->power_on) {
|
|
int err = pdata->power_on(pdev);
|
|
if (err < 0)
|
|
return err;
|
|
}
|
|
|
|
ohci_resume(hcd, false);
|
|
|
|
pm_runtime_disable(dev);
|
|
pm_runtime_set_active(dev);
|
|
pm_runtime_enable(dev);
|
|
|
|
return 0;
|
|
}
|
|
#endif /* CONFIG_PM_SLEEP */
|
|
|
|
static const struct of_device_id ohci_platform_ids[] = {
|
|
{ .compatible = "generic-ohci", },
|
|
{ .compatible = "cavium,octeon-6335-ohci", },
|
|
{ .compatible = "ti,ohci-omap3", },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(of, ohci_platform_ids);
|
|
|
|
static const struct platform_device_id ohci_platform_table[] = {
|
|
{ "ohci-platform", 0 },
|
|
{ }
|
|
};
|
|
MODULE_DEVICE_TABLE(platform, ohci_platform_table);
|
|
|
|
static SIMPLE_DEV_PM_OPS(ohci_platform_pm_ops, ohci_platform_suspend,
|
|
ohci_platform_resume);
|
|
|
|
static struct platform_driver ohci_platform_driver = {
|
|
.id_table = ohci_platform_table,
|
|
.probe = ohci_platform_probe,
|
|
.remove = ohci_platform_remove,
|
|
.shutdown = usb_hcd_platform_shutdown,
|
|
.driver = {
|
|
.name = "ohci-platform",
|
|
.pm = &ohci_platform_pm_ops,
|
|
.of_match_table = ohci_platform_ids,
|
|
}
|
|
};
|
|
|
|
static int __init ohci_platform_init(void)
|
|
{
|
|
if (usb_disabled())
|
|
return -ENODEV;
|
|
|
|
pr_info("%s: " DRIVER_DESC "\n", hcd_name);
|
|
|
|
ohci_init_driver(&ohci_platform_hc_driver, &platform_overrides);
|
|
return platform_driver_register(&ohci_platform_driver);
|
|
}
|
|
module_init(ohci_platform_init);
|
|
|
|
static void __exit ohci_platform_cleanup(void)
|
|
{
|
|
platform_driver_unregister(&ohci_platform_driver);
|
|
}
|
|
module_exit(ohci_platform_cleanup);
|
|
|
|
MODULE_DESCRIPTION(DRIVER_DESC);
|
|
MODULE_AUTHOR("Hauke Mehrtens");
|
|
MODULE_AUTHOR("Alan Stern");
|
|
MODULE_LICENSE("GPL");
|