mirror of
https://github.com/torvalds/linux.git
synced 2024-12-27 13:22:23 +00:00
5045ea3737
__kernel_get_syscall_map() and __kernel_clock_getres() use cmpli to
check if the passed in pointer is non zero. cmpli maps to a 32 bit
compare on binutils, so we ignore the top 32 bits.
A simple test case can be created by passing in a bogus pointer with
the bottom 32 bits clear. Using a clk_id that is handled by the VDSO,
then one that is handled by the kernel shows the problem:
printf("%d\n", clock_getres(CLOCK_REALTIME, (void *)0x100000000));
printf("%d\n", clock_getres(CLOCK_BOOTTIME, (void *)0x100000000));
And we get:
0
-1
The bigger issue is if we pass a valid pointer with the bottom 32 bits
clear, in this case we will return success but won't write any data
to the pointer.
I stumbled across this issue because the LLVM integrated assembler
doesn't accept cmpli with 3 arguments. Fix this by converting them to
cmpldi.
Fixes:
|
||
|---|---|---|
| .. | ||
| .gitignore | ||
| cacheflush.S | ||
| datapage.S | ||
| getcpu.S | ||
| gettimeofday.S | ||
| Makefile | ||
| note.S | ||
| sigtramp.S | ||
| vdso64_wrapper.S | ||
| vdso64.lds.S | ||