linux/net/can
Colin Ian King 62c04647c6 can: bcm: check for null sk before deferencing it via the call to sock_net
The assignment of net via call sock_net will dereference sk. This
is performed before a sanity null check on sk, so there could be
a potential null dereference on the sock_net call if sk is null.
Fix this by assigning net after the sk null check. Also replace
the sk == NULL with the more usual !sk idiom.

Detected by CoverityScan CID#1431862 ("Dereference before null check")

Fixes: 384317ef41 ("can: network namespace support for CAN_BCM protocol")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
2017-10-19 13:05:53 +02:00
..
af_can.c can: af_can: namespace support: fix lockdep splat: properly initialize spin_lock 2017-06-09 11:39:23 +02:00
af_can.h can: complete initial namespace support 2017-04-25 09:04:29 +02:00
bcm.c can: bcm: check for null sk before deferencing it via the call to sock_net 2017-10-19 13:05:53 +02:00
gw.c rtnetlink: make rtnl_register accept a flags parameter 2017-08-09 16:57:38 -07:00
Kconfig can: Kconfig: switch on all CAN protocolls by default 2013-01-26 16:58:58 +01:00
Makefile can: build proc support only if CONFIG_PROC_FS is activated 2016-06-17 15:39:41 +02:00
proc.c can: complete initial namespace support 2017-04-25 09:04:29 +02:00
raw.c can: initial support for network namespaces 2017-04-04 17:35:58 +02:00