linux/drivers/char/xilinx_hwicap
Arnd Bergmann 613655fa39 drivers: autoconvert trivial BKL users to private mutex
All these files use the big kernel lock in a trivial
way to serialize their private file operations,
typically resulting from an earlier semi-automatic
pushdown from VFS.

None of these drivers appears to want to lock against
other code, and they all use the BKL as the top-level
lock in their file operations, meaning that there
is no lock-order inversion problem.

Consequently, we can remove the BKL completely,
replacing it with a per-file mutex in every case.
Using a scripted approach means we can avoid
typos.

These drivers do not seem to be under active
maintainance from my brief investigation. Apologies
to those maintainers that I have missed.

file=$1
name=$2
if grep -q lock_kernel ${file} ; then
    if grep -q 'include.*linux.mutex.h' ${file} ; then
            sed -i '/include.*<linux\/smp_lock.h>/d' ${file}
    else
            sed -i 's/include.*<linux\/smp_lock.h>.*$/include <linux\/mutex.h>/g' ${file}
    fi
    sed -i ${file} \
        -e "/^#include.*linux.mutex.h/,$ {
                1,/^\(static\|int\|long\)/ {
                     /^\(static\|int\|long\)/istatic DEFINE_MUTEX(${name}_mutex);

} }"  \
    -e "s/\(un\)*lock_kernel\>[ ]*()/mutex_\1lock(\&${name}_mutex)/g" \
    -e '/[      ]*cycle_kernel_lock();/d'
else
    sed -i -e '/include.*\<smp_lock.h\>/d' ${file}  \
                -e '/cycle_kernel_lock()/d'
fi

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
2010-10-05 15:01:04 +02:00
..
buffer_icap.c xilinx_hwicap: remove improper wording in license statement 2008-12-17 11:23:07 -08:00
buffer_icap.h xilinx_hwicap: remove improper wording in license statement 2008-12-17 11:23:07 -08:00
fifo_icap.c xilinx_hwicap: remove improper wording in license statement 2008-12-17 11:23:07 -08:00
fifo_icap.h xilinx_hwicap: remove improper wording in license statement 2008-12-17 11:23:07 -08:00
Makefile [POWERPC] Xilinx: hwicap driver 2008-02-06 10:23:52 -07:00
xilinx_hwicap.c drivers: autoconvert trivial BKL users to private mutex 2010-10-05 15:01:04 +02:00
xilinx_hwicap.h xilinx_hwicap: remove improper wording in license statement 2008-12-17 11:23:07 -08:00