mirror of
https://github.com/torvalds/linux.git
synced 2024-11-22 20:22:09 +00:00
60e93dc097
Break the requirement that device-dax instances are physically contiguous. With this constraint removed it allows fragmented available capacity to be fully allocated. This capability is useful to mitigate the "noisy neighbor" problem with memory-side-cache management for virtual machines, or any other scenario where a platform address boundary also designates a performance boundary. For example a direct mapped memory side cache might rotate cache colors at 1GB boundaries. With dis-contiguous allocations a device-dax instance could be configured to contain only 1 cache color. It also satisfies Joao's use case (see link) for partitioning memory for exclusive guest access. It allows for a future potential mode where the host kernel need not allocate 'struct page' capacity up-front. Reported-by: Joao Martins <joao.m.martins@oracle.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Cc: Andy Lutomirski <luto@kernel.org> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Ard Biesheuvel <ardb@kernel.org> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: Ben Skeggs <bskeggs@redhat.com> Cc: Bjorn Helgaas <bhelgaas@google.com> Cc: Borislav Petkov <bp@alien8.de> Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com> Cc: Brice Goglin <Brice.Goglin@inria.fr> Cc: Catalin Marinas <catalin.marinas@arm.com> Cc: Daniel Vetter <daniel@ffwll.ch> Cc: Dave Hansen <dave.hansen@linux.intel.com> Cc: Dave Jiang <dave.jiang@intel.com> Cc: David Airlie <airlied@linux.ie> Cc: David Hildenbrand <david@redhat.com> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: "H. Peter Anvin" <hpa@zytor.com> Cc: Hulk Robot <hulkci@huawei.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: Ira Weiny <ira.weiny@intel.com> Cc: Jason Gunthorpe <jgg@mellanox.com> Cc: Jason Yan <yanaijie@huawei.com> Cc: Jeff Moyer <jmoyer@redhat.com> Cc: "Jérôme Glisse" <jglisse@redhat.com> Cc: Jia He <justin.he@arm.com> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com> Cc: Juergen Gross <jgross@suse.com> Cc: kernel test robot <lkp@intel.com> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Mike Rapoport <rppt@linux.ibm.com> Cc: Paul Mackerras <paulus@ozlabs.org> Cc: Pavel Tatashin <pasha.tatashin@soleen.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com> Cc: Randy Dunlap <rdunlap@infradead.org> Cc: Stefano Stabellini <sstabellini@kernel.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Tom Lendacky <thomas.lendacky@amd.com> Cc: Vishal Verma <vishal.l.verma@intel.com> Cc: Vivek Goyal <vgoyal@redhat.com> Cc: Wei Yang <richard.weiyang@linux.alibaba.com> Cc: Will Deacon <will@kernel.org> Link: https://lore.kernel.org/lkml/20200110190313.17144-1-joao.m.martins@oracle.com/ Link: https://lkml.kernel.org/r/159643104304.4062302.16561669534797528660.stgit@dwillia2-desk3.amr.corp.intel.com Link: https://lkml.kernel.org/r/160106116875.30709.11456649969327399771.stgit@dwillia2-desk3.amr.corp.intel.com Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
209 lines
5.3 KiB
C
209 lines
5.3 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/* Copyright(c) 2016-2019 Intel Corporation. All rights reserved. */
|
|
#include <linux/memremap.h>
|
|
#include <linux/pagemap.h>
|
|
#include <linux/memory.h>
|
|
#include <linux/module.h>
|
|
#include <linux/device.h>
|
|
#include <linux/pfn_t.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/dax.h>
|
|
#include <linux/fs.h>
|
|
#include <linux/mm.h>
|
|
#include <linux/mman.h>
|
|
#include "dax-private.h"
|
|
#include "bus.h"
|
|
|
|
/* Memory resource name used for add_memory_driver_managed(). */
|
|
static const char *kmem_name;
|
|
/* Set if any memory will remain added when the driver will be unloaded. */
|
|
static bool any_hotremove_failed;
|
|
|
|
static int dax_kmem_range(struct dev_dax *dev_dax, int i, struct range *r)
|
|
{
|
|
struct dev_dax_range *dax_range = &dev_dax->ranges[i];
|
|
struct range *range = &dax_range->range;
|
|
|
|
/* memory-block align the hotplug range */
|
|
r->start = ALIGN(range->start, memory_block_size_bytes());
|
|
r->end = ALIGN_DOWN(range->end + 1, memory_block_size_bytes()) - 1;
|
|
if (r->start >= r->end) {
|
|
r->start = range->start;
|
|
r->end = range->end;
|
|
return -ENOSPC;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
static int dev_dax_kmem_probe(struct dev_dax *dev_dax)
|
|
{
|
|
struct device *dev = &dev_dax->dev;
|
|
int i, mapped = 0;
|
|
char *res_name;
|
|
int numa_node;
|
|
|
|
/*
|
|
* Ensure good NUMA information for the persistent memory.
|
|
* Without this check, there is a risk that slow memory
|
|
* could be mixed in a node with faster memory, causing
|
|
* unavoidable performance issues.
|
|
*/
|
|
numa_node = dev_dax->target_node;
|
|
if (numa_node < 0) {
|
|
dev_warn(dev, "rejecting DAX region with invalid node: %d\n",
|
|
numa_node);
|
|
return -EINVAL;
|
|
}
|
|
|
|
res_name = kstrdup(dev_name(dev), GFP_KERNEL);
|
|
if (!res_name)
|
|
return -ENOMEM;
|
|
|
|
for (i = 0; i < dev_dax->nr_range; i++) {
|
|
struct resource *res;
|
|
struct range range;
|
|
int rc;
|
|
|
|
rc = dax_kmem_range(dev_dax, i, &range);
|
|
if (rc) {
|
|
dev_info(dev, "mapping%d: %#llx-%#llx too small after alignment\n",
|
|
i, range.start, range.end);
|
|
continue;
|
|
}
|
|
|
|
/* Region is permanently reserved if hotremove fails. */
|
|
res = request_mem_region(range.start, range_len(&range), res_name);
|
|
if (!res) {
|
|
dev_warn(dev, "mapping%d: %#llx-%#llx could not reserve region\n",
|
|
i, range.start, range.end);
|
|
/*
|
|
* Once some memory has been onlined we can't
|
|
* assume that it can be un-onlined safely.
|
|
*/
|
|
if (mapped)
|
|
continue;
|
|
kfree(res_name);
|
|
return -EBUSY;
|
|
}
|
|
|
|
/*
|
|
* Set flags appropriate for System RAM. Leave ..._BUSY clear
|
|
* so that add_memory() can add a child resource. Do not
|
|
* inherit flags from the parent since it may set new flags
|
|
* unknown to us that will break add_memory() below.
|
|
*/
|
|
res->flags = IORESOURCE_SYSTEM_RAM;
|
|
|
|
/*
|
|
* Ensure that future kexec'd kernels will not treat
|
|
* this as RAM automatically.
|
|
*/
|
|
rc = add_memory_driver_managed(numa_node, range.start,
|
|
range_len(&range), kmem_name);
|
|
|
|
if (rc) {
|
|
dev_warn(dev, "mapping%d: %#llx-%#llx memory add failed\n",
|
|
i, range.start, range.end);
|
|
release_mem_region(range.start, range_len(&range));
|
|
if (mapped)
|
|
continue;
|
|
kfree(res_name);
|
|
return rc;
|
|
}
|
|
mapped++;
|
|
}
|
|
|
|
dev_set_drvdata(dev, res_name);
|
|
|
|
return 0;
|
|
}
|
|
|
|
#ifdef CONFIG_MEMORY_HOTREMOVE
|
|
static int dev_dax_kmem_remove(struct dev_dax *dev_dax)
|
|
{
|
|
int i, success = 0;
|
|
struct device *dev = &dev_dax->dev;
|
|
const char *res_name = dev_get_drvdata(dev);
|
|
|
|
/*
|
|
* We have one shot for removing memory, if some memory blocks were not
|
|
* offline prior to calling this function remove_memory() will fail, and
|
|
* there is no way to hotremove this memory until reboot because device
|
|
* unbind will succeed even if we return failure.
|
|
*/
|
|
for (i = 0; i < dev_dax->nr_range; i++) {
|
|
struct range range;
|
|
int rc;
|
|
|
|
rc = dax_kmem_range(dev_dax, i, &range);
|
|
if (rc)
|
|
continue;
|
|
|
|
rc = remove_memory(dev_dax->target_node, range.start,
|
|
range_len(&range));
|
|
if (rc == 0) {
|
|
release_mem_region(range.start, range_len(&range));
|
|
success++;
|
|
continue;
|
|
}
|
|
any_hotremove_failed = true;
|
|
dev_err(dev,
|
|
"mapping%d: %#llx-%#llx cannot be hotremoved until the next reboot\n",
|
|
i, range.start, range.end);
|
|
}
|
|
|
|
if (success >= dev_dax->nr_range) {
|
|
kfree(res_name);
|
|
dev_set_drvdata(dev, NULL);
|
|
}
|
|
|
|
return 0;
|
|
}
|
|
#else
|
|
static int dev_dax_kmem_remove(struct dev_dax *dev_dax)
|
|
{
|
|
/*
|
|
* Without hotremove purposely leak the request_mem_region() for the
|
|
* device-dax range and return '0' to ->remove() attempts. The removal
|
|
* of the device from the driver always succeeds, but the region is
|
|
* permanently pinned as reserved by the unreleased
|
|
* request_mem_region().
|
|
*/
|
|
any_hotremove_failed = true;
|
|
return 0;
|
|
}
|
|
#endif /* CONFIG_MEMORY_HOTREMOVE */
|
|
|
|
static struct dax_device_driver device_dax_kmem_driver = {
|
|
.probe = dev_dax_kmem_probe,
|
|
.remove = dev_dax_kmem_remove,
|
|
};
|
|
|
|
static int __init dax_kmem_init(void)
|
|
{
|
|
int rc;
|
|
|
|
/* Resource name is permanently allocated if any hotremove fails. */
|
|
kmem_name = kstrdup_const("System RAM (kmem)", GFP_KERNEL);
|
|
if (!kmem_name)
|
|
return -ENOMEM;
|
|
|
|
rc = dax_driver_register(&device_dax_kmem_driver);
|
|
if (rc)
|
|
kfree_const(kmem_name);
|
|
return rc;
|
|
}
|
|
|
|
static void __exit dax_kmem_exit(void)
|
|
{
|
|
dax_driver_unregister(&device_dax_kmem_driver);
|
|
if (!any_hotremove_failed)
|
|
kfree_const(kmem_name);
|
|
}
|
|
|
|
MODULE_AUTHOR("Intel Corporation");
|
|
MODULE_LICENSE("GPL v2");
|
|
module_init(dax_kmem_init);
|
|
module_exit(dax_kmem_exit);
|
|
MODULE_ALIAS_DAX_DEVICE(0);
|