linux/include/net/tc_act
Xin Long 7cd5af0e93 net: sched: do not offload flows with a helper in act_ct
There is no hardware supporting ct helper offload. However, prior to this
patch, a flower filter with a helper in the ct action can be successfully
set into the HW, for example (eth1 is a bnxt NIC):

  # tc qdisc add dev eth1 ingress_block 22 ingress
  # tc filter add block 22 proto ip flower skip_sw ip_proto tcp \
    dst_port 21 ct_state -trk action ct helper ipv4-tcp-ftp
  # tc filter show dev eth1 ingress

    filter block 22 protocol ip pref 49152 flower chain 0 handle 0x1
      eth_type ipv4
      ip_proto tcp
      dst_port 21
      ct_state -trk
      skip_sw
      in_hw in_hw_count 1   <----
        action order 1: ct zone 0 helper ipv4-tcp-ftp pipe
         index 2 ref 1 bind 1
        used_hw_stats delayed

This might cause the flower filter not to work as expected in the HW.

This patch avoids this problem by simply returning -EOPNOTSUPP in
tcf_ct_offload_act_setup() to not allow to offload flows with a helper
in act_ct.

Fixes: a21b06e731 ("net: sched: add helper support in act_ct")
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Reviewed-by: Jamal Hadi Salim <jhs@mojatatu.com>
Link: https://lore.kernel.org/r/f8685ec7702c4a448a1371a8b34b43217b583b9d.1699898008.git.lucien.xin@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
2023-11-16 10:10:51 +01:00
..
tc_bpf.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152 2019-05-30 11:26:32 -07:00
tc_connmark.h net/sched: act_connmark: transition to percpu stats and rcu 2023-02-16 10:39:28 +01:00
tc_csum.h
tc_ct.h net: sched: do not offload flows with a helper in act_ct 2023-11-16 10:10:51 +01:00
tc_ctinfo.h net: sched: act_ctinfo: tidy UAPI definition 2019-06-19 17:11:01 -04:00
tc_defact.h
tc_gact.h net/sched: act_gact: Add extack messages for offload failure 2022-04-08 13:45:43 +01:00
tc_gate.h flow_offload: add index to flow_action_entry structure 2021-12-19 14:08:47 +00:00
tc_ife.h
tc_ipt.h
tc_mirred.h net: sched: act_mirred: add net device refcount tracker 2021-12-07 20:45:00 -08:00
tc_mpls.h net: sched: include mpls actions in hardware intermediate representation 2019-07-23 13:52:50 -07:00
tc_nat.h net/sched: act_nat: transition to percpu stats and rcu 2023-02-16 10:39:28 +01:00
tc_pedit.h net/sched: transition act_pedit to rcu and percpu stats 2023-02-02 13:19:02 +01:00
tc_police.h net: flow_offload: add tc police action parameters 2022-02-28 11:11:35 +00:00
tc_sample.h net: sched: take reference to psample group in flow_action infra 2019-09-16 09:18:03 +02:00
tc_skbedit.h act_skbedit: skbedit queue mapping for receive queue 2022-10-25 10:32:40 +02:00
tc_skbmod.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152 2019-05-30 11:26:32 -07:00
tc_tunnel_key.h net: sched: Fix suspicious RCU usage while accessing tcf_tunnel_info 2020-10-15 09:10:11 -07:00
tc_vlan.h net/sched: fix incorrect vlan_push_eth dest field 2022-03-23 10:32:48 -07:00