mirror of
https://github.com/torvalds/linux.git
synced 2024-12-26 12:52:30 +00:00
60587bd068
The "handled" variable could be uninitialized if the
interrupt_service_routine() call back hasn't been implimented or if it
has been implemented but doesn't initialize "handled" to zero at the
start. For example, adv76xx_isr() only sets "handled" to true.
Fixes: 44b153ca63 ('[media] m5mols: Add ISO sensitivity controls')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
45 lines
1.4 KiB
C
45 lines
1.4 KiB
C
/*
|
|
* Driver for the Conexant CX23885/7/8 PCIe bridge
|
|
*
|
|
* AV device support routines - non-input, non-vl42_subdev routines
|
|
*
|
|
* Copyright (C) 2010 Andy Walls <awalls@md.metrocast.net>
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License
|
|
* as published by the Free Software Foundation; either version 2
|
|
* of the License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*/
|
|
|
|
#include "cx23885.h"
|
|
#include "cx23885-av.h"
|
|
#include "cx23885-video.h"
|
|
|
|
void cx23885_av_work_handler(struct work_struct *work)
|
|
{
|
|
struct cx23885_dev *dev =
|
|
container_of(work, struct cx23885_dev, cx25840_work);
|
|
bool handled = false;
|
|
|
|
v4l2_subdev_call(dev->sd_cx25840, core, interrupt_service_routine,
|
|
PCI_MSK_AV_CORE, &handled);
|
|
|
|
/* Getting here with the interrupt not handled
|
|
then probbaly flatiron does have pending interrupts.
|
|
*/
|
|
if (!handled) {
|
|
/* clear left and right adc channel interrupt request flag */
|
|
cx23885_flatiron_write(dev, 0x1f,
|
|
cx23885_flatiron_read(dev, 0x1f) | 0x80);
|
|
cx23885_flatiron_write(dev, 0x23,
|
|
cx23885_flatiron_read(dev, 0x23) | 0x80);
|
|
}
|
|
|
|
cx23885_irq_enable(dev, PCI_MSK_AV_CORE);
|
|
}
|