mirror of
https://github.com/torvalds/linux.git
synced 2024-11-23 04:31:50 +00:00
5e5ff73c2e
Due to compiler optimizations like inlining, there are cases where
MMIO traces using _THIS_IP_ for caller information might not be
sufficient to provide accurate debug traces.
1) With optimizations (Seen with GCC):
In this case, _THIS_IP_ works fine and prints the caller information
since it will be inlined into the caller and we get the debug traces
on who made the MMIO access, for ex:
rwmmio_read: qcom_smmu_tlb_sync+0xe0/0x1b0 width=32 addr=0xffff8000087447f4
rwmmio_post_read: qcom_smmu_tlb_sync+0xe0/0x1b0 width=32 val=0x0 addr=0xffff8000087447f4
2) Without optimizations (Seen with Clang):
_THIS_IP_ will not be sufficient in this case as it will print only
the MMIO accessors itself which is of not much use since it is not
inlined as below for example:
rwmmio_read: readl+0x4/0x80 width=32 addr=0xffff8000087447f4
rwmmio_post_read: readl+0x48/0x80 width=32 val=0x4 addr=0xffff8000087447f4
So in order to handle this second case as well irrespective of the compiler
optimizations, add _RET_IP_ to MMIO trace to make it provide more accurate
debug information in all these scenarios.
Before:
rwmmio_read: readl+0x4/0x80 width=32 addr=0xffff8000087447f4
rwmmio_post_read: readl+0x48/0x80 width=32 val=0x4 addr=0xffff8000087447f4
After:
rwmmio_read: qcom_smmu_tlb_sync+0xe0/0x1b0 -> readl+0x4/0x80 width=32 addr=0xffff8000087447f4
rwmmio_post_read: qcom_smmu_tlb_sync+0xe0/0x1b0 -> readl+0x4/0x80 width=32 val=0x0 addr=0xffff8000087447f4
Fixes: 210031971c ("asm-generic/io: Add logging support for MMIO accessors")
Signed-off-by: Sai Prakash Ranjan <quic_saipraka@quicinc.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
48 lines
1.5 KiB
C
48 lines
1.5 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Register read and write tracepoints
|
|
*
|
|
* Copyright (c) 2021-2022 Qualcomm Innovation Center, Inc. All rights reserved.
|
|
*/
|
|
|
|
#include <linux/ftrace.h>
|
|
#include <linux/module.h>
|
|
#include <asm-generic/io.h>
|
|
|
|
#define CREATE_TRACE_POINTS
|
|
#include <trace/events/rwmmio.h>
|
|
|
|
#ifdef CONFIG_TRACE_MMIO_ACCESS
|
|
void log_write_mmio(u64 val, u8 width, volatile void __iomem *addr,
|
|
unsigned long caller_addr, unsigned long caller_addr0)
|
|
{
|
|
trace_rwmmio_write(caller_addr, caller_addr0, val, width, addr);
|
|
}
|
|
EXPORT_SYMBOL_GPL(log_write_mmio);
|
|
EXPORT_TRACEPOINT_SYMBOL_GPL(rwmmio_write);
|
|
|
|
void log_post_write_mmio(u64 val, u8 width, volatile void __iomem *addr,
|
|
unsigned long caller_addr, unsigned long caller_addr0)
|
|
{
|
|
trace_rwmmio_post_write(caller_addr, caller_addr0, val, width, addr);
|
|
}
|
|
EXPORT_SYMBOL_GPL(log_post_write_mmio);
|
|
EXPORT_TRACEPOINT_SYMBOL_GPL(rwmmio_post_write);
|
|
|
|
void log_read_mmio(u8 width, const volatile void __iomem *addr,
|
|
unsigned long caller_addr, unsigned long caller_addr0)
|
|
{
|
|
trace_rwmmio_read(caller_addr, caller_addr0, width, addr);
|
|
}
|
|
EXPORT_SYMBOL_GPL(log_read_mmio);
|
|
EXPORT_TRACEPOINT_SYMBOL_GPL(rwmmio_read);
|
|
|
|
void log_post_read_mmio(u64 val, u8 width, const volatile void __iomem *addr,
|
|
unsigned long caller_addr, unsigned long caller_addr0)
|
|
{
|
|
trace_rwmmio_post_read(caller_addr, caller_addr0, val, width, addr);
|
|
}
|
|
EXPORT_SYMBOL_GPL(log_post_read_mmio);
|
|
EXPORT_TRACEPOINT_SYMBOL_GPL(rwmmio_post_read);
|
|
#endif /* CONFIG_TRACE_MMIO_ACCESS */
|