Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-27 14:41:39 +00:00
Code Issues Packages Projects Releases Wiki Activity
5b2fc2a12c
linux/drivers/media/tuners
History
Mauro Carvalho Chehab f7d84fa704 media: tw5864, fc0011: better handle WARN_ON() 
As such macro will check if the expression is true, it may fall through, as
warned:

In file included from ./include/uapi/linux/stddef.h:1:0,
                 from ./include/linux/stddef.h:4,
                 from ./include/uapi/linux/posix_types.h:4,
                 from ./include/uapi/linux/types.h:13,
                 from ./include/linux/types.h:5,
                 from ./drivers/media/dvb-core/dvb_frontend.h:35,
                 from drivers/media/tuners/fc0011.h:4,
                 from drivers/media/tuners/fc0011.c:20:
drivers/media/tuners/fc0011.c: In function 'fc0011_set_params':
./include/linux/compiler.h:179:22: warning: this statement may fall through [-Wimplicit-fallthrough=]
 # define unlikely(x) __builtin_expect(!!(x), 0)
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~
./include/asm-generic/bug.h:109:2: note: in expansion of macro 'unlikely'
  unlikely(__ret_warn_on);     \
  ^~~~~~~~
drivers/media/tuners/fc0011.c:344:3: note: in expansion of macro 'WARN_ON'
   WARN_ON(1);
   ^~~~~~~
drivers/media/tuners/fc0011.c:345:2: note: here
  case 0:
  ^~~~
In file included from ./include/uapi/linux/stddef.h:1:0,
                 from ./include/linux/stddef.h:4,
                 from ./include/uapi/linux/posix_types.h:4,
                 from ./include/uapi/linux/types.h:13,
                 from ./include/linux/types.h:5,
                 from ./include/linux/list.h:4,
                 from ./include/linux/module.h:9,
                 from drivers/media/pci/tw5864/tw5864-video.c:17:
drivers/media/pci/tw5864/tw5864-video.c: In function 'tw5864_fmt_vid_cap':
./include/linux/compiler.h:179:22: warning: this statement may fall through [-Wimplicit-fallthrough=]
 # define unlikely(x) __builtin_expect(!!(x), 0)
                      ^~~~~~~~~~~~~~~~~~~~~~~~~~
./include/asm-generic/bug.h:68:2: note: in expansion of macro 'unlikely'
  unlikely(__ret_warn_on);    \
  ^~~~~~~~
drivers/media/pci/tw5864/tw5864-video.c:547:3: note: in expansion of macro 'WARN_ON_ONCE'
   WARN_ON_ONCE(1);
   ^~~~~~~~~~~~
drivers/media/pci/tw5864/tw5864-video.c:548:2: note: here
  case STD_NTSC:
  ^~~~

On both cases, it means an error, so, let's return an error
code, to make gcc happy.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Acked-by: Michael Büsch <m@bues.ch>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
2017-06-24 16:19:27 -03:00
..
e4000_priv.h [media] e4000: implement V4L2 subdevice tuner and core ops 2015-05-20 13:49:27 -03:00
e4000.c [media] tuners: Drop owner assignment from i2c_driver 2015-08-11 13:01:32 -03:00
e4000.h [media] e4000: various small changes 2015-05-20 13:48:31 -03:00
fc001x-common.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
fc0011.c media: tw5864, fc0011: better handle WARN_ON() 2017-06-24 16:19:27 -03:00
fc0011.h treewide: remove redundant #include <linux/kconfig.h> 2016-10-11 15:06:33 -07:00
fc0012-priv.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
fc0012.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
fc0012.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
fc0013-priv.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
fc0013.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
fc0013.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
fc2580_priv.h [media] fc2580: implement V4L2 subdevice for SDR control 2015-05-18 15:58:10 -03:00
fc2580.c [media] tuners: Drop owner assignment from i2c_driver 2015-08-11 13:01:32 -03:00
fc2580.h [media] fc2580: implement V4L2 subdevice for SDR control 2015-05-18 15:58:10 -03:00
it913x.c [media] it913x: add chip device ids for binding 2017-01-31 10:50:34 -02:00
it913x.h [media] it913x: add chip device ids for binding 2017-01-31 10:50:34 -02:00
Kconfig [media] tuners: Make all TV tuners visible if COMPILE_TEST=y 2015-08-11 12:56:40 -03:00
m88rs6000t.c [media] tuners: Refactoring for m88rs6000t_sleep() 2016-01-25 15:15:38 -02:00
m88rs6000t.h [media] m88rs6000t: add new dvb-s/s2 tuner for integrated chip M88RS6000 2014-11-03 18:23:43 -02:00
Makefile [media] m88ts2022: remove from Makefile 2015-04-07 08:12:06 -03:00
max2165_priv.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
max2165.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
max2165.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
mc44s803_priv.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
mc44s803.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
mc44s803.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
msi001.c spi: Drop owner assignment from spi_drivers 2015-10-28 10:30:17 +09:00
mt20xx.c Revert "[media] dvb_frontend: merge duplicate dvb_tuner_ops.release implementations" 2016-11-18 20:44:33 -02:00
mt20xx.h [media] Add and use IS_REACHABLE macro 2015-04-08 15:02:07 -03:00
mt2060_priv.h [media] mt2060: implement sleep 2017-02-03 06:55:46 -02:00
mt2060.c [media] mt2060: implement sleep 2017-02-03 06:55:46 -02:00
mt2060.h [media] mt2060: add param to split long i2c writes 2017-02-03 06:44:03 -02:00
mt2063.c [media] dvb_frontend: tuner_ops.release returns void 2016-11-18 15:07:26 -02:00
mt2063.h [media] Add and use IS_REACHABLE macro 2015-04-08 15:02:07 -03:00
mt2131_priv.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
mt2131.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
mt2131.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
mt2266.c Revert "[media] dvb_frontend: merge duplicate dvb_tuner_ops.release implementations" 2016-11-18 20:44:33 -02:00
mt2266.h [media] Add and use IS_REACHABLE macro 2015-04-08 15:02:07 -03:00
mxl301rf.c [media] mxl301rf: add driver for MaxLinear MxL301RF OFDM tuner 2014-09-23 17:03:59 -03:00
mxl301rf.h [media] mxl301rf: add driver for MaxLinear MxL301RF OFDM tuner 2014-09-23 17:03:59 -03:00
mxl5005s.c media: tuners: mxl5005s: remove useless variable assignments 2017-06-24 15:29:33 -03:00
mxl5005s.h treewide: remove redundant #include <linux/kconfig.h> 2016-10-11 15:06:33 -07:00
mxl5007t.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
mxl5007t.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
qm1d1c0042.c [media] em28xx: add support for PLEX PX-BCUD (ISDB-S) 2016-05-06 23:51:47 -03:00
qm1d1c0042.h [media] qm1d1c0042: add driver for Sharp QM1D1C0042 ISDB-S tuner 2014-09-23 17:04:00 -03:00
qt1010_priv.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
qt1010.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
qt1010.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
r820t.c [media] dvb_frontend: tuner_ops.release returns void 2016-11-18 15:07:26 -02:00
r820t.h treewide: remove redundant #include <linux/kconfig.h> 2016-10-11 15:06:33 -07:00
si2157_priv.h [media] si2157: Add support for Si2141-A10 2017-04-14 22:27:47 -03:00
si2157.c [media] si2157: Add support for Si2141-A10 2017-04-14 22:27:47 -03:00
si2157.h treewide: remove redundant #include <linux/kconfig.h> 2016-10-11 15:06:33 -07:00
tda827x.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
tda827x.h [media] Add and use IS_REACHABLE macro 2015-04-08 15:02:07 -03:00
tda8290.c [media] dvb: make DVB frontend *_ops instances "const" 2016-11-18 15:00:22 -02:00
tda8290.h [media] Add and use IS_REACHABLE macro 2015-04-08 15:02:07 -03:00
tda9887.c [media] dvb: make DVB frontend *_ops instances "const" 2016-11-18 15:00:22 -02:00
tda9887.h [media] Add and use IS_REACHABLE macro 2015-04-08 15:02:07 -03:00
tda18212.c [media] tuners: Drop owner assignment from i2c_driver 2015-08-11 13:01:32 -03:00
tda18212.h treewide: remove redundant #include <linux/kconfig.h> 2016-10-11 15:06:33 -07:00
tda18218_priv.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
tda18218.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
tda18218.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
tda18271-common.c [media] tuners: don't break long lines 2016-10-21 10:08:13 -02:00
tda18271-fe.c [media] media drivers: annotate fall-through 2017-05-19 07:10:03 -03:00
tda18271-maps.c [media] tuners: don't break long lines 2016-10-21 10:08:13 -02:00
tda18271-priv.h [media] tda18271: use prefix on all printk messages 2016-09-05 15:26:28 -03:00
tda18271.h [media] Add and use IS_REACHABLE macro 2015-04-08 15:02:07 -03:00
tea5761.c Revert "[media] dvb_frontend: merge duplicate dvb_tuner_ops.release implementations" 2016-11-18 20:44:33 -02:00
tea5761.h [media] Add and use IS_REACHABLE macro 2015-04-08 15:02:07 -03:00
tea5767.c Revert "[media] dvb_frontend: merge duplicate dvb_tuner_ops.release implementations" 2016-11-18 20:44:33 -02:00
tea5767.h [media] Add and use IS_REACHABLE macro 2015-04-08 15:02:07 -03:00
tua9001_priv.h [media] tua9001: use div_u64() for frequency calculation 2015-05-18 15:55:14 -03:00
tua9001.c [media] tuners: Drop owner assignment from i2c_driver 2015-08-11 13:01:32 -03:00
tua9001.h [media] tua9001: various minor changes 2015-05-18 15:54:02 -03:00
tuner-i2c.h [media] tuner-i2c: be consistent with I2C declaration 2015-06-23 10:01:45 -03:00
tuner-simple.c [media] dvb_frontend: tuner_ops.release returns void 2016-11-18 15:07:26 -02:00
tuner-simple.h [media] Add and use IS_REACHABLE macro 2015-04-08 15:02:07 -03:00
tuner-types.c
tuner-xc2028-types.h
tuner-xc2028.c Merge branch 'patchwork' into v4l_for_linus 2016-12-15 08:38:35 -02:00
tuner-xc2028.h [media] Add and use IS_REACHABLE macro 2015-04-08 15:02:07 -03:00
xc4000.c [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
xc4000.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00
xc5000.c [media] xc5000: Don't spin waiting for analog lock 2017-06-06 07:51:05 -03:00
xc5000.h [media] media: Drop FSF's postal address from the source code files 2017-01-27 11:38:09 -02:00