Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-23 20:51:44 +00:00
Code Issues Packages Projects Releases Wiki Activity
5ad31a5751
linux/include/asm-xtensa
History
Andrea Righi 27ac792ca0 PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures 
On 32-bit architectures PAGE_ALIGN() truncates 64-bit values to the 32-bit
boundary. For example:

	u64 val = PAGE_ALIGN(size);

always returns a value < 4GB even if size is greater than 4GB.

The problem resides in PAGE_MASK definition (from include/asm-x86/page.h for
example):

#define PAGE_SHIFT      12
#define PAGE_SIZE       (_AC(1,UL) << PAGE_SHIFT)
#define PAGE_MASK       (~(PAGE_SIZE-1))
...
#define PAGE_ALIGN(addr)       (((addr)+PAGE_SIZE-1)&PAGE_MASK)

The "~" is performed on a 32-bit value, so everything in "and" with
PAGE_MASK greater than 4GB will be truncated to the 32-bit boundary.
Using the ALIGN() macro seems to be the right way, because it uses
typeof(addr) for the mask.

Also move the PAGE_ALIGN() definitions out of include/asm-*/page.h in
include/linux/mm.h.

See also lkml discussion: http://lkml.org/lkml/2008/6/11/237

[akpm@linux-foundation.org: fix drivers/media/video/uvc/uvc_queue.c]
[akpm@linux-foundation.org: fix v850]
[akpm@linux-foundation.org: fix powerpc]
[akpm@linux-foundation.org: fix arm]
[akpm@linux-foundation.org: fix mips]
[akpm@linux-foundation.org: fix drivers/media/video/pvrusb2/pvrusb2-dvb.c]
[akpm@linux-foundation.org: fix drivers/mtd/maps/uclinux.c]
[akpm@linux-foundation.org: fix powerpc]
Signed-off-by: Andrea Righi <righi.andrea@gmail.com>
Cc: <linux-arch@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2008-07-24 10:47:21 -07:00
..
platform-iss fix file specification in comments 2007-05-09 08:58:16 +02:00
variant-fsf [XTENSA] Add support for configurable registers and coprocessors 2008-02-13 17:41:43 -08:00
a.out.h aout: move STACK_TOP[_MAX] to asm/processor.h 2008-02-08 09:22:29 -08:00
asmmacro.h [PATCH] xtensa: remove extra header files 2006-12-10 09:55:39 -08:00
atomic.h atomic.h: atomic_add_unless as inline. Remove system.h atomic.h circular dependency 2007-05-08 11:15:20 -07:00
auxvec.h
bitops.h forbid asm/bitops.h direct inclusion 2007-10-19 11:53:41 -07:00
bootparam.h
bug.h [PATCH] xtensa: fix irq and misc fixes 2006-12-10 09:55:39 -08:00
bugs.h [XTENSA] Remove extraneous include statement 2007-08-27 13:53:27 -07:00
byteorder.h [XTENSA] clean-up header files 2007-05-31 17:47:01 -07:00
cache.h [XTENSA] Add support for cache-aliasing 2007-08-27 13:54:16 -07:00
cacheasm.h [PATCH] xtensa: remove extra header files 2006-12-10 09:55:39 -08:00
cacheflush.h [XTENSA] Fix cache flush macro for D$/I$ aliasing/non-aliasing 2008-02-13 17:43:26 -08:00
checksum.h [PATCH] xtensa: remove extra header files 2006-12-10 09:55:39 -08:00
coprocessor.h [XTENSA] Exclude thread-global registers from the xtregs structures. 2008-02-13 17:43:00 -08:00
cpumask.h
cputime.h
current.h
delay.h Don't include linux/config.h from anywhere else in include/ 2006-04-26 12:56:16 +01:00
device.h Driver core: add dev_archdata to struct device 2006-12-01 14:52:01 -08:00
div64.h [XTENSA] Use generic 64-bit division 2007-05-31 17:46:09 -07:00
dma-mapping.h xtensa: dma-mapping.h is using linux/scatterlist.h functions, so include it 2007-10-24 13:28:40 +02:00
dma.h [PATCH] xtensa: remove extra header files 2006-12-10 09:55:39 -08:00
elf.h [XTENSA] Allow debugger to modify the WINDOWBASE register. 2008-02-13 17:45:36 -08:00
emergency-restart.h
errno.h
fb.h fbdev: detect primary display device 2007-07-17 10:23:11 -07:00
fcntl.h Xtensa: use asm-generic/fcntl.h 2007-05-31 20:18:25 -07:00
futex.h [PATCH] xtensa: add asm/futex.h 2006-02-01 08:53:23 -08:00
hardirq.h Don't include linux/config.h from anywhere else in include/ 2006-04-26 12:56:16 +01:00
highmem.h
hw_irq.h [PATCH] genirq: add ->retrigger() irq op to consolidate hw_irq_resend() 2006-06-29 10:26:23 -07:00
ide.h Don't include linux/config.h from anywhere else in include/ 2006-04-26 12:56:16 +01:00
io.h [XTENSA] Add support for cache-aliasing 2007-08-27 13:54:16 -07:00
ioctl.h [PATCH] Generic ioctl.h 2006-01-10 08:01:34 -08:00
ioctls.h [patch 1/2] Xtensa: enable arbitary tty speed setting ioctls 2007-08-27 13:54:25 -07:00
ipcbuf.h
irq_regs.h [PATCH] xtensa: fix irq and misc fixes 2006-12-10 09:55:39 -08:00
irq.h [PATCH] xtensa: remove extra header files 2006-12-10 09:55:39 -08:00
Kbuild Add empty Kbuild files for 'make headers_install' in remaining arches. 2006-06-18 12:58:53 +01:00
kdebug.h move die notifier handling to common code 2007-05-08 11:15:04 -07:00
kmap_types.h
kvm.h kvm: provide kvm.h for all architecture: fixes headers_install 2008-04-02 15:28:18 -07:00
linkage.h
local.h
mman.h [PATCH] Remove final references to deprecated "MAP_ANON" page protection flag 2007-02-11 10:51:17 -08:00
mmu_context.h [XTENSA] clean-up header files 2007-05-31 17:47:01 -07:00
mmu.h
module.h [XTENSA] Fix modules for non-exec processor configurations 2008-02-13 17:23:26 -08:00
msgbuf.h
mutex.h [PATCH] mutex subsystem, add default include/asm-*/mutex.h files 2006-01-09 15:59:19 -08:00
namei.h
page.h PAGE_ALIGN(): correctly handle 64-bit values on 32-bit architectures 2008-07-24 10:47:21 -07:00
param.h asm-{alpha,h8300,um,v850,xtensa}/param.h: unbreak HZ for userspace 2008-05-14 19:11:14 -07:00
pci-bridge.h
pci.h PCI: remove pci_dac_dma_... APIs 2007-07-11 16:02:11 -07:00
percpu.h
pgalloc.h [XTENSA] Fix non-existent pte_token_t typedef to pgtable_t 2008-02-13 16:25:09 -08:00
pgtable.h mm: introduce pte_special pte bit 2008-04-28 08:58:23 -07:00
platform.h Don't include linux/config.h from anywhere else in include/ 2006-04-26 12:56:16 +01:00
poll.h Consolidate asm/poll.h 2007-05-11 08:29:34 -07:00
posix_types.h asm-*/posix_types.h: scrub __GLIBC__ 2008-02-08 09:22:34 -08:00
processor.h [XTENSA] Add support for configurable registers and coprocessors 2008-02-13 17:41:43 -08:00
ptrace.h [XTENSA] Add support for configurable registers and coprocessors 2008-02-13 17:41:43 -08:00
regs.h [XTENSA] Add support for configurable registers and coprocessors 2008-02-13 17:41:43 -08:00
resource.h
rmap.h
rwsem.h [PATCH] lockdep: remove RWSEM_DEBUG remnants 2006-07-03 15:27:01 -07:00
scatterlist.h Add CONFIG_DEBUG_SG sg validation 2007-10-22 21:20:03 +02:00
sections.h
segment.h
semaphore.h Generic semaphore implementation 2008-04-17 10:42:34 -04:00
sembuf.h [PATCH] xtensa: remove extra header files 2006-12-10 09:55:39 -08:00
serial.h
setup.h
shmbuf.h [PATCH] xtensa: fix system call interface 2006-12-10 09:55:39 -08:00
shmparam.h [XTENSA] clean-up header files 2007-05-31 17:47:01 -07:00
sigcontext.h [XTENSA] Add support for configurable registers and coprocessors 2008-02-13 17:41:43 -08:00
siginfo.h fix file specification in comments 2006-10-03 23:01:26 +02:00
signal.h [PATCH] irq-flags: XTENSA: Use the new IRQF_ constants 2006-07-02 13:58:49 -07:00
smp.h
socket.h [NET]: Introducing socket mark socket option. 2008-01-31 19:27:19 -08:00
sockios.h [NET]: Introduce SIOCGSTAMPNS ioctl to get timestamps with nanosec resolution 2007-04-25 22:24:04 -07:00
spinlock.h
stat.h [XTENSA] Clean up stat structs. 2008-02-13 17:27:03 -08:00
statfs.h
string.h
syscall.h [XTENSA] Fix fadvise64_64 2007-08-27 13:53:32 -07:00
system.h [XTENSA] Add support for configurable registers and coprocessors 2008-02-13 17:41:43 -08:00
termbits.h [patch 1/2] Xtensa: enable arbitary tty speed setting ioctls 2007-08-27 13:54:25 -07:00
termios.h [patch 1/2] Xtensa: enable arbitary tty speed setting ioctls 2007-08-27 13:54:25 -07:00
thread_info.h [XTENSA] Add support for configurable registers and coprocessors 2008-02-13 17:41:43 -08:00
timex.h [XTENSA] Add volatile keyword to asm statements accessing counter registers 2008-02-13 17:24:47 -08:00
tlb.h add mm argument to pte/pmd/pud/pgd_free 2008-02-05 09:44:18 -08:00
tlbflush.h remove unused flush_tlb_pgtables 2007-10-19 11:53:34 -07:00
topology.h
types.h xtensa: types: use <asm-generic/int-*.h> for the xtensa architecture 2008-05-02 16:18:42 -07:00
uaccess.h [XTENSA] Fix clobbered register in asm macro 2008-02-13 17:06:41 -08:00
ucontext.h
unaligned.h kernel: Move arches to use common unaligned access 2008-04-29 08:06:27 -07:00
unistd.h fix xtensa timerfd breakage 2008-02-08 15:33:32 -08:00
user.h
vga.h [PATCH] vgacon: make VGA_MAP_MEM take size, remove extra use 2006-06-22 15:05:58 -07:00
xor.h