linux/drivers/message/i2o
Tejun Heo 5a0e3ad6af include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files.  percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.

percpu.h -> slab.h dependency is about to be removed.  Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability.  As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.

  http://userweb.kernel.org/~tj/misc/slabh-sweep.py

The script does the followings.

* Scan files for gfp and slab usages and update includes such that
  only the necessary includes are there.  ie. if only gfp is used,
  gfp.h, if slab is used, slab.h.

* When the script inserts a new include, it looks at the include
  blocks and try to put the new include such that its order conforms
  to its surrounding.  It's put in the include block which contains
  core kernel includes, in the same order that the rest are ordered -
  alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
  doesn't seem to be any matching order.

* If the script can't find a place to put a new include (mostly
  because the file doesn't have fitting include block), it prints out
  an error message indicating which .h file needs to be added to the
  file.

The conversion was done in the following steps.

1. The initial automatic conversion of all .c files updated slightly
   over 4000 files, deleting around 700 includes and adding ~480 gfp.h
   and ~3000 slab.h inclusions.  The script emitted errors for ~400
   files.

2. Each error was manually checked.  Some didn't need the inclusion,
   some needed manual addition while adding it to implementation .h or
   embedding .c file was more appropriate for others.  This step added
   inclusions to around 150 files.

3. The script was run again and the output was compared to the edits
   from #2 to make sure no file was left behind.

4. Several build tests were done and a couple of problems were fixed.
   e.g. lib/decompress_*.c used malloc/free() wrappers around slab
   APIs requiring slab.h to be added manually.

5. The script was run on all .h files but without automatically
   editing them as sprinkling gfp.h and slab.h inclusions around .h
   files could easily lead to inclusion dependency hell.  Most gfp.h
   inclusion directives were ignored as stuff from gfp.h was usually
   wildly available and often used in preprocessor macros.  Each
   slab.h inclusion directive was examined and added manually as
   necessary.

6. percpu.h was updated not to include slab.h.

7. Build test were done on the following configurations and failures
   were fixed.  CONFIG_GCOV_KERNEL was turned off for all tests (as my
   distributed build env didn't work with gcov compiles) and a few
   more options had to be turned off depending on archs to make things
   build (like ipr on powerpc/64 which failed due to missing writeq).

   * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
   * powerpc and powerpc64 SMP allmodconfig
   * sparc and sparc64 SMP allmodconfig
   * ia64 SMP allmodconfig
   * s390 SMP allmodconfig
   * alpha SMP allmodconfig
   * um on x86_64 SMP allmodconfig

8. percpu.h modifications were reverted so that it could be applied as
   a separate patch and serve as bisection point.

Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.

Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
2010-03-30 22:02:32 +09:00
..
bus-osm.c [PATCH] kernel-doc: fix fusion and i2o docs 2006-12-07 08:39:40 -08:00
config-osm.c [PATCH] I2O: Optimizing 2006-01-06 08:33:54 -08:00
core.h [PATCH] i2o_exec_exit and i2o_driver_exit should not be __exit. 2006-12-13 09:05:47 -08:00
debug.c i2o debug output cleanup 2007-07-17 10:23:06 -07:00
device.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core-2.6 2009-01-06 17:02:07 -08:00
driver.c i2o: remove extraneous kernel-doc 2009-01-06 15:59:21 -08:00
exec-osm.c i2o: Update my address 2009-01-05 18:28:04 -08:00
i2o_block.c include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h 2010-03-30 22:02:32 +09:00
i2o_block.h [PATCH] slab: remove kmem_cache_t 2006-12-07 08:39:25 -08:00
i2o_config.c include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h 2010-03-30 22:02:32 +09:00
i2o_proc.c include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h 2010-03-30 22:02:32 +09:00
i2o_scsi.c trivial: fix then -> than typos in comments and documentation 2009-01-06 11:28:06 +01:00
iop.c include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h 2010-03-30 22:02:32 +09:00
Kconfig Introduce CONFIG_VIRT_TO_BUS 2007-07-16 09:05:42 -07:00
Makefile i2o: Fix 32/64bit DMA locking 2008-10-16 11:21:38 -07:00
memory.c dma-mapping: replace all DMA_32BIT_MASK macro with DMA_BIT_MASK(32) 2009-04-07 08:31:11 -07:00
pci.c include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h 2010-03-30 22:02:32 +09:00
README Convert files to UTF-8 and some cleanups 2007-10-19 23:21:04 +02:00
README.ioctl spelling: s/retreive/retrieve/ 2006-01-10 00:10:13 +01:00

	Linux I2O Support	(c) Copyright 1999 Red Hat Software
					and others.

	This program is free software; you can redistribute it and/or
	modify it under the terms of the GNU General Public License
	as published by the Free Software Foundation; either version
	2 of the License, or (at your option) any later version.

AUTHORS (so far)

Alan Cox, Building Number Three Ltd.
	Core code, SCSI and Block OSMs

Steve Ralston, LSI Logic Corp.
	Debugging SCSI and Block OSM

Deepak Saxena, Intel Corp.
	Various core/block extensions
	/proc interface, bug fixes
	Ioctl interfaces for control
	Debugging LAN OSM

Philip Rumpf
	Fixed assorted dumb SMP locking bugs

Juha Sievanen, University of Helsinki Finland
	LAN OSM code
	/proc interface to LAN class
	Bug fixes
	Core code extensions

Auvo Häkkinen, University of Helsinki Finland
	LAN OSM code
	/Proc interface to LAN class
	Bug fixes
	Core code extensions

Taneli Vähäkangas, University of Helsinki Finland
	Fixes to i2o_config

CREDITS

	This work was made possible by 

Red Hat Software
	Funding for the Building #3 part of the project

Symbios Logic (Now LSI)
	Host adapters, hints, known to work platforms when I hit
	compatibility problems

BoxHill Corporation
	Loan of initial FibreChannel disk array used for development work.

European Comission
	Funding the work done by the University of Helsinki

SysKonnect
        Loan of FDDI and Gigabit Ethernet cards

ASUSTeK
        Loan of I2O motherboard 

STATUS:

o	The core setup works within limits.
o	The scsi layer seems to almost work. 
           I'm still chasing down the hang bug.
o	The block OSM is mostly functional
o	LAN OSM works with FDDI and Ethernet cards.

TO DO:

General:
o	Provide hidden address space if asked
o	Long term message flow control
o	PCI IOP's without interrupts are not supported yet
o	Push FAIL handling into the core
o	DDM control interfaces for module load etc
o       Add I2O 2.0 support (Deffered to 2.5 kernel)

Block:
o	Multiple major numbers
o	Read ahead and cache handling stuff. Talk to Ingo and people
o	Power management
o	Finish Media changers

SCSI:
o	Find the right way to associate drives/luns/busses

Lan:	
o	Performance tuning
o	Test Fibre Channel code

Tape:
o	Anyone seen anything implementing this ?
           (D.S: Will attempt to do so if spare cycles permit)