mirror of
https://github.com/torvalds/linux.git
synced 2024-12-12 06:02:38 +00:00
59ae1d127a
A common pattern with skb_put() is to just want to memcpy()
some data into the new space, introduce skb_put_data() for
this.
An spatch similar to the one for skb_put_zero() converts many
of the places using it:
@@
identifier p, p2;
expression len, skb, data;
type t, t2;
@@
(
-p = skb_put(skb, len);
+p = skb_put_data(skb, data, len);
|
-p = (t)skb_put(skb, len);
+p = skb_put_data(skb, data, len);
)
(
p2 = (t2)p;
-memcpy(p2, data, len);
|
-memcpy(p, data, len);
)
@@
type t, t2;
identifier p, p2;
expression skb, data;
@@
t *p;
...
(
-p = skb_put(skb, sizeof(t));
+p = skb_put_data(skb, data, sizeof(t));
|
-p = (t *)skb_put(skb, sizeof(t));
+p = skb_put_data(skb, data, sizeof(t));
)
(
p2 = (t2)p;
-memcpy(p2, data, sizeof(*p));
|
-memcpy(p, data, sizeof(*p));
)
@@
expression skb, len, data;
@@
-memcpy(skb_put(skb, len), data, len);
+skb_put_data(skb, data, len);
(again, manually post-processed to retain some comments)
Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
|
||
|---|---|---|
| .. | ||
| cfg80211.c | ||
| hfa384x_usb.c | ||
| hfa384x.h | ||
| Kconfig | ||
| Makefile | ||
| p80211conv.c | ||
| p80211conv.h | ||
| p80211hdr.h | ||
| p80211ioctl.h | ||
| p80211metadef.h | ||
| p80211metastruct.h | ||
| p80211mgmt.h | ||
| p80211msg.h | ||
| p80211netdev.c | ||
| p80211netdev.h | ||
| p80211req.c | ||
| p80211req.h | ||
| p80211types.h | ||
| p80211wep.c | ||
| prism2fw.c | ||
| prism2mgmt.c | ||
| prism2mgmt.h | ||
| prism2mib.c | ||
| prism2sta.c | ||
| prism2usb.c | ||
| README | ||
TODO: - checkpatch.pl cleanups - sparse warnings - move to use the in-kernel wireless stack Please send any patches or complaints about this driver to Greg Kroah-Hartman <greg@kroah.com> and don't bother the upstream wireless kernel developers about it, they want nothing to do with it.