mirror of
https://github.com/torvalds/linux.git
synced 2024-12-14 23:25:54 +00:00
e37559b22c
The vb2 core ignores any return code from the stop_streaming op.
And there really isn't anything it can do anyway in case of an error.
So change the return type to void and update any drivers that implement it.
The int return gave drivers the idea that this operation could actually
fail, but that's really not the case.
The pwc amd sdr-msi3101 drivers both had this construction:
if (mutex_lock_interruptible(&s->v4l2_lock))
return -ERESTARTSYS;
This has been updated to just call mutex_lock(). The stop_streaming op
expects this to really stop streaming and I very much doubt this will
work reliably if stop_streaming just returns without really stopping the
DMA.
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Pawel Osciak <pawel@osciak.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
21 lines
790 B
C
21 lines
790 B
C
/*
|
|
em28xx-video.c - driver for Empia EM2800/EM2820/2840 USB
|
|
video capture devices
|
|
|
|
Copyright (C) 2013-2014 Mauro Carvalho Chehab <m.chehab@samsung.com>
|
|
|
|
This program is free software; you can redistribute it and/or modify
|
|
it under the terms of the GNU General Public License as published by
|
|
the Free Software Foundation version 2 of the License.
|
|
|
|
This program is distributed in the hope that it will be useful,
|
|
but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
GNU General Public License for more details.
|
|
*/
|
|
|
|
|
|
int em28xx_start_analog_streaming(struct vb2_queue *vq, unsigned int count);
|
|
void em28xx_stop_vbi_streaming(struct vb2_queue *vq);
|
|
extern struct vb2_ops em28xx_vbi_qops;
|