mirror of
https://github.com/torvalds/linux.git
synced 2024-12-15 23:51:46 +00:00
c407cd008f
Change snprintf to scnprintf. There are generally two cases where using snprintf causes problems. 1) Uses of size += snprintf(buf, SIZE - size, fmt, ...) In this case, if snprintf would have written more characters than what the buffer size (SIZE) is, then size will end up larger than SIZE. In later uses of snprintf, SIZE - size will result in a negative number, leading to problems. Note that size might already be too large by using size = snprintf before the code reaches a case of size += snprintf. 2) If size is ultimately used as a length parameter for a copy back to user space, then it will potentially allow for a buffer overflow and information disclosure when size is greater than SIZE. When the size is used to index the buffer directly, we can have memory corruption. This also means when size = snprintf... is used, it may also cause problems since size may become large. Copying to userspace is mitigated by the HARDENED_USERCOPY kernel configuration. The solution to these issues is to use scnprintf which returns the number of characters actually written to the buffer, so the size variable will never exceed SIZE. Signed-off-by: Silvio Cesare <silvio.cesare@gmail.com> Cc: Timur Tabi <timur@kernel.org> Cc: Nicolin Chen <nicoleotsuka@gmail.com> Cc: Mark Brown <broonie@kernel.org> Cc: Xiubo Li <Xiubo.Lee@gmail.com> Cc: Fabio Estevam <fabio.estevam@nxp.com> Cc: Dan Carpenter <dan.carpenter@oracle.com> Cc: Kees Cook <keescook@chromium.org> Cc: Will Deacon <will.deacon@arm.com> Cc: Greg KH <greg@kroah.com> Signed-off-by: Willy Tarreau <w@1wt.eu> Acked-by: Nicolin Chen <nicoleotsuka@gmail.com> Reviewed-by: Kees Cook <keescook@chromium.org> Signed-off-by: Mark Brown <broonie@kernel.org> |
||
|---|---|---|
| .. | ||
| efika-audio-fabric.c | ||
| eukrea-tlv320.c | ||
| fsl_asrc_dma.c | ||
| fsl_asrc.c | ||
| fsl_asrc.h | ||
| fsl_dma.c | ||
| fsl_dma.h | ||
| fsl_esai.c | ||
| fsl_esai.h | ||
| fsl_sai.c | ||
| fsl_sai.h | ||
| fsl_spdif.c | ||
| fsl_spdif.h | ||
| fsl_ssi_dbg.c | ||
| fsl_ssi.c | ||
| fsl_ssi.h | ||
| fsl_utils.c | ||
| fsl_utils.h | ||
| fsl-asoc-card.c | ||
| imx-audmux.c | ||
| imx-audmux.h | ||
| imx-es8328.c | ||
| imx-mc13783.c | ||
| imx-pcm-dma.c | ||
| imx-pcm-fiq.c | ||
| imx-pcm.h | ||
| imx-sgtl5000.c | ||
| imx-spdif.c | ||
| imx-ssi.c | ||
| imx-ssi.h | ||
| Kconfig | ||
| Makefile | ||
| mpc5200_dma.c | ||
| mpc5200_dma.h | ||
| mpc5200_psc_ac97.c | ||
| mpc5200_psc_i2s.c | ||
| mpc8610_hpcd.c | ||
| mx27vis-aic32x4.c | ||
| p1022_ds.c | ||
| p1022_rdk.c | ||
| pcm030-audio-fabric.c | ||
| phycore-ac97.c | ||
| wm1133-ev1.c | ||