mirror of
https://github.com/torvalds/linux.git
synced 2024-12-28 22:02:28 +00:00
e324654294
Many ARM sub-architectures use prompts followed by "if" conditional,
but it is wrong.
Please notice the difference between
config ARCH_FOO
bool "Foo SoCs" if ARCH_MULTI_V7
and
config ARCH_FOO
bool "Foo SoCs"
depends on ARCH_MULTI_V7
These two are *not* equivalent!
In the former statement, it is not ARCH_FOO, but its prompt that
depends on ARCH_MULTI_V7. So, it is completely valid that ARCH_FOO
is selected by another, but ARCH_MULTI_V7 is still disabled. As it is
not unmet dependency, Kconfig never warns. This is probably not what
you want.
The former should be used only when you need to do so, and you really
understand what you are doing. (In most cases, it should be wrong!)
For enabling/disabling sub-architectures, the latter is always correct.
As a good side effect, this commit fixes some entries over 80 columns
(mach-imx, mach-integrator, mach-mbevu).
[Arnd: I note that there is not really a bug here, according to
the discussion that followed, but I can see value in being consistent
and in making the lines shorter]
Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Acked-by: Nicolas Ferre <nicolas.ferre@atmel.com>
Acked-by: Heiko Stuebner <heiko@sntech.de>
Acked-by: Patrice Chotard <patrice.chotard@st.com>
Acked-by: Liviu Dudau <Liviu.Dudau@arm.com>
Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Acked-by: Jun Nie <jun.nie@linaro.org>
Acked-by: Matthias Brugger <matthias.bgg@gmail.com>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Acked-by: Shawn Guo <shawnguo@kernel.org>
Acked-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Acked-by: Krzysztof Halasa <khc@piap.pl>
Acked-by: Maxime Coquelin <maxime.coquelin@st.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
58 lines
1.2 KiB
Plaintext
58 lines
1.2 KiB
Plaintext
config ARCH_HISI
|
|
bool "Hisilicon SoC Support"
|
|
depends on ARCH_MULTI_V7
|
|
select ARM_AMBA
|
|
select ARM_GIC
|
|
select ARM_TIMER_SP804
|
|
select POWER_RESET
|
|
select POWER_RESET_HISI
|
|
select POWER_SUPPLY
|
|
|
|
if ARCH_HISI
|
|
|
|
menu "Hisilicon platform type"
|
|
|
|
config ARCH_HI3xxx
|
|
bool "Hisilicon Hi36xx family"
|
|
depends on ARCH_MULTI_V7
|
|
select CACHE_L2X0
|
|
select HAVE_ARM_SCU if SMP
|
|
select HAVE_ARM_TWD if SMP
|
|
select PINCTRL
|
|
select PINCTRL_SINGLE
|
|
help
|
|
Support for Hisilicon Hi36xx SoC family
|
|
|
|
config ARCH_HIP01
|
|
bool "Hisilicon HIP01 family"
|
|
depends on ARCH_MULTI_V7
|
|
select HAVE_ARM_SCU if SMP
|
|
select HAVE_ARM_TWD if SMP
|
|
select ARM_GLOBAL_TIMER
|
|
help
|
|
Support for Hisilicon HIP01 SoC family
|
|
|
|
config ARCH_HIP04
|
|
bool "Hisilicon HiP04 Cortex A15 family"
|
|
depends on ARCH_MULTI_V7
|
|
select ARM_ERRATA_798181 if SMP
|
|
select HAVE_ARM_ARCH_TIMER
|
|
select MCPM if SMP
|
|
select MCPM_QUAD_CLUSTER if SMP
|
|
help
|
|
Support for Hisilicon HiP04 SoC family
|
|
|
|
config ARCH_HIX5HD2
|
|
bool "Hisilicon X5HD2 family"
|
|
depends on ARCH_MULTI_V7
|
|
select CACHE_L2X0
|
|
select HAVE_ARM_SCU if SMP
|
|
select HAVE_ARM_TWD if SMP
|
|
select PINCTRL
|
|
select PINCTRL_SINGLE
|
|
help
|
|
Support for Hisilicon HIX5HD2 SoC family
|
|
endmenu
|
|
|
|
endif
|