Eric Dumazet d293958a85 net/smc: do not leave a dangling sk pointer in __smc_create() ... Thanks to commit 4bbd360a50 ("socket: Print pf->create() when it does not clear sock->sk on failure."), syzbot found an issue with AF_SMC: smc_create must clear sock->sk on failure, family: 43, type: 1, protocol: 0 WARNING: CPU: 0 PID: 5827 at net/socket.c:1565 __sock_create+0x96f/0xa30 net/socket.c:1563 Modules linked in: CPU: 0 UID: 0 PID: 5827 Comm: syz-executor259 Not tainted 6.12.0-rc6-next-20241106-syzkaller #0 Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 09/13/2024 RIP: 0010:__sock_create+0x96f/0xa30 net/socket.c:1563 Code: 03 00 74 08 4c 89 e7 e8 4f 3b 85 f8 49 8b 34 24 48 c7 c7 40 89 0c 8d 8b 54 24 04 8b 4c 24 0c 44 8b 44 24 08 e8 32 78 db f7 90 <0f> 0b 90 90 e9 d3 fd ff ff 89 e9 80 e1 07 fe c1 38 c1 0f 8c ee f7 RSP: 0018:ffffc90003e4fda0 EFLAGS: 00010246 RAX: 099c6f938c7f4700 RBX: 1ffffffff1a595fd RCX: ffff888034823c00 RDX: 0000000000000000 RSI: 0000000000000000 RDI: 0000000000000000 RBP: 00000000ffffffe9 R08: ffffffff81567052 R09: 1ffff920007c9f50 R10: dffffc0000000000 R11: fffff520007c9f51 R12: ffffffff8d2cafe8 R13: 1ffffffff1a595fe R14: ffffffff9a789c40 R15: ffff8880764298c0 FS: 000055557b518380(0000) GS:ffff8880b8600000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: 00007fa62ff43225 CR3: 0000000031628000 CR4: 00000000003526f0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 Call Trace: <TASK> sock_create net/socket.c:1616 [inline] __sys_socket_create net/socket.c:1653 [inline] __sys_socket+0x150/0x3c0 net/socket.c:1700 __do_sys_socket net/socket.c:1714 [inline] __se_sys_socket net/socket.c:1712 [inline] For reference, see commit 2d859aff77 ("Merge branch 'do-not-leave-dangling-sk-pointers-in-pf-create-functions'") Fixes: d25a92ccae ("net/smc: Introduce IPPROTO_SMC") Signed-off-by: Eric Dumazet <edumazet@google.com> Cc: Ignat Korchagin <ignat@cloudflare.com> Cc: D. Wythe <alibuda@linux.alibaba.com> Cc: Dust Li <dust.li@linux.alibaba.com> Reviewed-by: Kuniyuki Iwashima <kuniyu@amazon.com> Reviewed-by: Wenjia Zhang <wenjia@linux.ibm.com> Link: https://patch.msgid.link/20241106221922.1544045-1-edumazet@google.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>		2024-11-07 11:31:14 -08:00
..
af_smc.c	net/smc: do not leave a dangling sk pointer in __smc_create()	2024-11-07 11:31:14 -08:00
Kconfig
Makefile	net/smc: Introduce IPPROTO_SMC	2024-06-17 13:14:09 +01:00
smc_cdc.c	net/smc: adapt cursor update when sndbuf and peer DMB are merged	2024-04-30 13:24:48 +02:00
smc_cdc.h
smc_clc.c
smc_clc.h	net/smc: Use static_assert() to check struct sizes	2024-08-12 18:41:42 -07:00
smc_close.c
smc_close.h
smc_core.c	net/smc: introduce statistics for ringbufs usage of net namespace	2024-08-20 11:38:23 +02:00
smc_core.h	net/smc: introduce statistics for allocated ringbufs of link group	2024-08-20 11:38:23 +02:00
smc_diag.c
smc_ib.c	net/smc: Fix lookup of netdev by using ib_device_get_netdev()	2024-11-07 11:24:19 -08:00
smc_ib.h
smc_inet.c	net/smc: fix lacks of icsk_syn_mss with IPPROTO_SMC	2024-10-10 08:48:11 -07:00
smc_inet.h	net/smc: Introduce IPPROTO_SMC	2024-06-17 13:14:09 +01:00
smc_ism.c	net/smc: add operations to merge sndbuf with peer DMB	2024-04-30 13:24:48 +02:00
smc_ism.h	net/smc: add operations to merge sndbuf with peer DMB	2024-04-30 13:24:48 +02:00
smc_llc.c
smc_llc.h
smc_loopback.c	net/smc: implement DMB-merged operations of loopback-ism	2024-04-30 13:24:49 +02:00
smc_loopback.h	net/smc: remove unreferenced header in smc_loopback.h file	2024-07-31 11:48:58 +01:00
smc_netlink.c
smc_netlink.h
smc_netns.h
smc_pnet.c	net/smc: Fix lookup of netdev by using ib_device_get_netdev()	2024-11-07 11:24:19 -08:00
smc_pnet.h
smc_rx.c
smc_rx.h
smc_stats.c	net/smc: introduce statistics for ringbufs usage of net namespace	2024-08-20 11:38:23 +02:00
smc_stats.h	net/smc: introduce statistics for ringbufs usage of net namespace	2024-08-20 11:38:23 +02:00
smc_sysctl.c	net/smc: add sysctl for smc_limit_hs	2024-09-10 12:11:04 +02:00
smc_sysctl.h
smc_tracepoint.c
smc_tracepoint.h	tracing/treewide: Remove second parameter of __assign_str()	2024-05-22 20:14:47 -04:00
smc_tx.c
smc_tx.h
smc_wr.c	net/smc: Fix memory leak when using percpu refs	2024-10-14 17:32:05 -07:00
smc_wr.h
smc.h	net/smc: prevent NULL pointer dereference in txopt_get	2024-08-30 13:26:12 +01:00