Amir Goldstein 55bf882c7f fanotify: fix merging marks masks with FAN_ONDIR ... Change the logic of FAN_ONDIR in two ways that are similar to the logic of FAN_EVENT_ON_CHILD, that was fixed in commit 54a307ba8d ("fanotify: fix logic of events on child"): 1. The flag is meaningless in ignore mask 2. The flag refers only to events in the mask of the mark where it is set This is what the fanotify_mark.2 man page says about FAN_ONDIR: "Without this flag, only events for files are created." It doesn't say anything about setting this flag in ignore mask to stop getting events on directories nor can I think of any setup where this capability would be useful. Currently, when marks masks are merged, the FAN_ONDIR flag set in one mark affects the events that are set in another mark's mask and this behavior causes unexpected results. For example, a user adds a mark on a directory with mask FAN_ATTRIB | FAN_ONDIR and a mount mark with mask FAN_OPEN (without FAN_ONDIR). An opendir() of that directory (which is inside that mount) generates a FAN_OPEN event even though neither of the marks requested to get open events on directories. Link: https://lore.kernel.org/r/20200319151022.31456-10-amir73il@gmail.com Signed-off-by: Amir Goldstein <amir73il@gmail.com> Signed-off-by: Jan Kara <jack@suse.cz>		2020-03-24 12:06:32 +01:00
..
dnotify	selinux/stable-5.4 PR 20190917	2019-09-23 11:21:04 -07:00
fanotify	fanotify: fix merging marks masks with FAN_ONDIR	2020-03-24 12:06:32 +01:00
inotify	fsnotify: replace inode pointer with an object id	2020-03-24 11:28:00 +01:00
fdinfo.c	fsnotify/fdinfo: exportfs_encode_inode_fh() takes pointer as 4th argument	2019-10-17 10:32:59 +02:00
fdinfo.h	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
fsnotify.c	fsnotify: simplify arguments passing to fsnotify_parent()	2020-03-23 18:22:48 +01:00
fsnotify.h	fsnotify: move declaration of fsnotify_mark_connector_cachep to fsnotify.h	2019-10-17 10:31:12 +02:00
group.c	notify: export symbols for use by the knfsd file cache	2019-08-19 11:00:39 -04:00
Kconfig	treewide: Add SPDX license identifier - Makefile/Kconfig	2019-05-21 10:50:46 +02:00
Makefile	License cleanup: add SPDX GPL-2.0 license identifier to files with no license	2017-11-02 11:10:55 +01:00
mark.c	notify: export symbols for use by the knfsd file cache	2019-08-19 11:00:39 -04:00
notification.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 18	2019-05-21 11:28:46 +02:00