Eric Dumazet 55667441c8 net/flow_dissector: switch to siphash ... UDP IPv6 packets auto flowlabels are using a 32bit secret (static u32 hashrnd in net/core/flow_dissector.c) and apply jhash() over fields known by the receivers. Attackers can easily infer the 32bit secret and use this information to identify a device and/or user, since this 32bit secret is only set at boot time. Really, using jhash() to generate cookies sent on the wire is a serious security concern. Trying to change the rol32(hash, 16) in ip6_make_flowlabel() would be a dead end. Trying to periodically change the secret (like in sch_sfq.c) could change paths taken in the network for long lived flows. Let's switch to siphash, as we did in commit df453700e8 ("inet: switch IP ID generator to siphash") Using a cryptographically strong pseudo random function will solve this privacy issue and more generally remove other weak points in the stack. Packet schedulers using skb_get_hash_perturb() benefit from this change. Fixes: b56774163f ("ipv6: Enable auto flow labels by default") Fixes: 42240901f7 ("ipv6: Implement different admin modes for automatic flow labels") Fixes: 67800f9b1f ("ipv6: Call skb_get_hash_flowi6 to get skb->hash in ip6_make_flowlabel") Fixes: cb1ce2ef38 ("ipv6: Implement automatic flow label generation on transmit") Signed-off-by: Eric Dumazet <edumazet@google.com> Reported-by: Jonathan Berger <jonathann1@walla.com> Reported-by: Amit Klein <aksecurity@gmail.com> Reported-by: Benny Pinkas <benny@pinkas.net> Cc: Tom Herbert <tom@herbertland.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2019-10-23 20:13:22 -07:00
..
act_api.c	net: avoid potential infinite loop in tc_ctl_action()	2019-10-15 20:20:22 -07:00
act_bpf.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_connmark.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_csum.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_ct.c	netfilter: update include directives.	2019-09-13 12:33:06 +02:00
act_ctinfo.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_gact.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_ife.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_ipt.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_meta_mark.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
act_meta_skbprio.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
act_meta_skbtcindex.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
act_mirred.c	act_mirred: Fix mirred_init_module error handling	2019-10-09 19:19:35 -07:00
act_mpls.c	net/sched: fix corrupted L2 header with MPLS 'push' and 'pop' actions	2019-10-15 17:14:48 -07:00
act_nat.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_pedit.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_police.c	net_sched: act_police: add 2 new attributes to support police 64bit rate and peakrate	2019-09-06 15:02:16 +02:00
act_sample.c	net/sched: act_sample: don't push mac header on ip6gre ingress	2019-09-20 17:01:59 -07:00
act_simple.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_skbedit.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_skbmod.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_tunnel_key.c	net_sched: fix a NULL pointer deref in ipt action	2019-08-27 15:05:58 -07:00
act_vlan.c	Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net	2019-09-02 11:20:17 -07:00
cls_api.c	net_sched: fix backward compatibility for TCA_KIND	2019-10-08 16:21:58 -07:00
cls_basic.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_bpf.c	net: sched: refactor block offloads counter usage	2019-08-26 14:17:43 -07:00
cls_cgroup.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_flow.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_flower.c	net: sched: flower: don't take rtnl lock for cls hw offloads API	2019-08-26 14:17:43 -07:00
cls_fw.c	net: sched: remove NET_CLS_IND config option	2019-06-15 14:06:13 -07:00
cls_matchall.c	net: sched: cls_matchall: cleanup flow_action before deallocating	2019-08-30 15:12:05 -07:00
cls_route.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_rsvp6.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_rsvp.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_rsvp.h	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
cls_tcindex.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
cls_u32.c	net: sched: refactor block offloads counter usage	2019-08-26 14:17:43 -07:00
em_canid.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 11	2019-05-21 11:28:45 +02:00
em_cmp.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
em_ipset.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
em_ipt.c	net: sched: em_ipt: add support for addrtype matching	2019-06-29 11:15:12 -07:00
em_meta.c	tcp: annotate sk->sk_wmem_queued lockless reads	2019-10-13 10:13:08 -07:00
em_nbyte.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
em_text.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
em_u32.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
ematch.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
Kconfig	net/sched: Set default of CONFIG_NET_TC_SKB_EXT to N	2019-09-27 20:08:28 +02:00
Makefile	net/sched: Introduce action ct	2019-07-09 12:11:59 -07:00
sch_api.c	net_sched: fix backward compatibility for TCA_KIND	2019-10-08 16:21:58 -07:00
sch_atm.c	treewide: Add SPDX license identifier for more missed files	2019-05-21 10:50:45 +02:00
sch_blackhole.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_cake.c	netlink: make validation more configurable for future strictness	2019-04-27 17:07:21 -04:00
sch_cbq.c	sch_cbq: validate TCA_CBQ_WRROPT to avoid crash	2019-09-30 11:07:46 -07:00
sch_cbs.c	net: sched: cbs: Avoid division by zero when calculating the port rate	2019-10-01 09:51:39 -07:00
sch_choke.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sch_codel.c	net: sched: Fix a possible null-pointer dereference in dequeue_func()	2019-07-29 09:46:58 -07:00
sch_drr.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sch_dsmark.c	sch_dsmark: fix potential NULL deref in dsmark_init()	2019-10-04 18:28:30 -07:00
sch_etf.c	sched: etf: Fix ordering of packets with same txtime	2019-10-15 20:32:04 -07:00
sch_fifo.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_fq_codel.c	fq_codel: remove set but not used variables 'prev_ecn_mark' and 'prev_drop_count'	2019-08-08 22:32:19 -07:00
sch_fq.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_generic.c	net_sched: let qdisc_put() accept NULL pointer	2019-09-15 20:54:14 +02:00
sch_gred.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_hfsc.c	netlink: make validation more configurable for future strictness	2019-04-27 17:07:21 -04:00
sch_hhf.c	net/flow_dissector: switch to siphash	2019-10-23 20:13:22 -07:00
sch_htb.c	net: sched: sch_htb: don't call qdisc_put() while holding tree lock	2019-09-27 12:13:55 +02:00
sch_ingress.c	net: flow_offload: rename TCF_BLOCK_BINDER_TYPE_* to FLOW_BLOCK_BINDER_TYPE_*	2019-07-09 14:38:50 -07:00
sch_mq.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sch_mqprio.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sch_multiq.c	net: sched: multiq: don't call qdisc_put() while holding tree lock	2019-09-27 12:13:55 +02:00
sch_netem.c	net: netem: correct the parent's backlog when corrupted packet was dropped	2019-10-19 12:12:36 -07:00
sch_pie.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 235	2019-06-19 17:09:07 +02:00
sch_plug.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_prio.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_qfq.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500	2019-06-19 17:09:55 +02:00
sch_red.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_sfb.c	net/flow_dissector: switch to siphash	2019-10-23 20:13:22 -07:00
sch_sfq.c	net/flow_dissector: switch to siphash	2019-10-23 20:13:22 -07:00
sch_skbprio.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_taprio.c	net: sched: taprio: fix -Wmissing-prototypes warnings	2019-10-22 13:35:07 -07:00
sch_tbf.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00
sch_teql.c	treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152	2019-05-30 11:26:32 -07:00