Roman Mashak 51d4740f88 net sched actions: return explicit error when tunnel_key mode is not specified ... If set/unset mode of the tunnel_key action is not provided, ->init() still returns 0, and the caller proceeds with bogus 'struct tc_action *' object, this results in crash: % tc actions add action tunnel_key src_ip 1.1.1.1 dst_ip 2.2.2.1 id 7 index 1 [ 35.805515] general protection fault: 0000 [#1] SMP PTI [ 35.806161] Modules linked in: act_tunnel_key kvm_intel kvm irqbypass crct10dif_pclmul crc32_pclmul ghash_clmulni_intel pcbc aesni_intel aes_x86_64 crypto_simd glue_helper cryptd serio_raw [ 35.808233] CPU: 1 PID: 428 Comm: tc Not tainted 4.16.0-rc4+ #286 [ 35.808929] RIP: 0010:tcf_action_init+0x90/0x190 [ 35.809457] RSP: 0018:ffffb8edc068b9a0 EFLAGS: 00010206 [ 35.810053] RAX: 1320c000000a0003 RBX: 0000000000000001 RCX: 0000000000000000 [ 35.810866] RDX: 0000000000000070 RSI: 0000000000007965 RDI: ffffb8edc068b910 [ 35.811660] RBP: ffffb8edc068b9d0 R08: 0000000000000000 R09: ffffb8edc068b808 [ 35.812463] R10: ffffffffc02bf040 R11: 0000000000000040 R12: ffffb8edc068bb38 [ 35.813235] R13: 0000000000000000 R14: 0000000000000000 R15: ffffb8edc068b910 [ 35.814006] FS: 00007f3d0d8556c0(0000) GS:ffff91d1dbc40000(0000) knlGS:0000000000000000 [ 35.814881] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 35.815540] CR2: 000000000043f720 CR3: 0000000019248001 CR4: 00000000001606a0 [ 35.816457] Call Trace: [ 35.817158] tc_ctl_action+0x11a/0x220 [ 35.817795] rtnetlink_rcv_msg+0x23d/0x2e0 [ 35.818457] ? __slab_alloc+0x1c/0x30 [ 35.819079] ? __kmalloc_node_track_caller+0xb1/0x2b0 [ 35.819544] ? rtnl_calcit.isra.30+0xe0/0xe0 [ 35.820231] netlink_rcv_skb+0xce/0x100 [ 35.820744] netlink_unicast+0x164/0x220 [ 35.821500] netlink_sendmsg+0x293/0x370 [ 35.822040] sock_sendmsg+0x30/0x40 [ 35.822508] ___sys_sendmsg+0x2c5/0x2e0 [ 35.823149] ? pagecache_get_page+0x27/0x220 [ 35.823714] ? filemap_fault+0xa2/0x640 [ 35.824423] ? page_add_file_rmap+0x108/0x200 [ 35.825065] ? alloc_set_pte+0x2aa/0x530 [ 35.825585] ? finish_fault+0x4e/0x70 [ 35.826140] ? __handle_mm_fault+0xbc1/0x10d0 [ 35.826723] ? __sys_sendmsg+0x41/0x70 [ 35.827230] __sys_sendmsg+0x41/0x70 [ 35.827710] do_syscall_64+0x68/0x120 [ 35.828195] entry_SYSCALL_64_after_hwframe+0x3d/0xa2 [ 35.828859] RIP: 0033:0x7f3d0ca4da67 [ 35.829331] RSP: 002b:00007ffc9f284338 EFLAGS: 00000246 ORIG_RAX: 000000000000002e [ 35.830304] RAX: ffffffffffffffda RBX: 00007ffc9f284460 RCX: 00007f3d0ca4da67 [ 35.831247] RDX: 0000000000000000 RSI: 00007ffc9f2843b0 RDI: 0000000000000003 [ 35.832167] RBP: 000000005aa6a7a9 R08: 0000000000000001 R09: 0000000000000000 [ 35.833075] R10: 00000000000005f1 R11: 0000000000000246 R12: 0000000000000000 [ 35.833997] R13: 00007ffc9f2884c0 R14: 0000000000000001 R15: 0000000000674640 [ 35.834923] Code: 24 30 bb 01 00 00 00 45 31 f6 eb 5e 8b 50 08 83 c2 07 83 e2 fc 83 c2 70 49 8b 07 48 8b 40 70 48 85 c0 74 10 48 89 14 24 4c 89 ff <ff> d0 48 8b 14 24 48 01 c2 49 01 d6 45 85 ed 74 05 41 83 47 2c [ 35.837442] RIP: tcf_action_init+0x90/0x190 RSP: ffffb8edc068b9a0 [ 35.838291] ---[ end trace a095c06ee4b97a26 ]--- Fixes: d0f6dd8a91 ("net/sched: Introduce act_tunnel_key") Signed-off-by: Roman Mashak <mrv@mojatatu.com> Acked-by: Cong Wang <xiyou.wangcong@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>		2018-03-15 14:43:41 -04:00
..
6lowpan
9p	virtio: bugfixes	2018-02-15 14:29:27 -08:00
802
8021q	net: delete /proc THIS_MODULE references	2018-01-16 15:01:33 -05:00
appletalk	net: delete /proc THIS_MODULE references	2018-01-16 15:01:33 -05:00
atm	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
ax25	net: delete /proc THIS_MODULE references	2018-01-16 15:01:33 -05:00
batman-adv	batman-adv: Fix internal interface indices types	2018-02-25 20:19:34 +01:00
bluetooth	Bluetooth: Fix missing encryption refresh on Security Request	2018-03-01 19:55:56 +01:00
bpf	bpf: fix null pointer deref in bpf_prog_test_run_xdp	2018-02-01 07:43:56 -08:00
bridge	netfilter: bridge: ebt_among: add more missing match size checks	2018-03-11 21:24:49 +01:00
caif	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
can	can: migrate documentation to restructured text	2018-01-26 10:46:44 +01:00
ceph	libceph, ceph: avoid memory leak when specifying same option several times	2018-02-26 16:19:30 +01:00
core	net: use skb_to_full_sk() in skb_update_prio()	2018-03-14 12:53:23 -04:00
dcb
dccp	dccp: check sk for closed state in dccp_sendmsg()	2018-03-07 13:38:56 -05:00
decnet	dn_getsockoptdecnet: move nf_{get/set}sockopt outside sock lock	2018-02-16 15:46:15 -05:00
dns_resolver	afs: Support the AFS dynamic root	2018-02-06 14:43:37 +00:00
dsa	net: dsa: Fix dsa_is_user_port() test inversion	2018-03-12 21:04:55 -04:00
ethernet
hsr
ieee802154	ieee802154: 6lowpan: fix possible NULL deref in lowpan_device_event()	2018-03-09 11:19:26 -05:00
ife
ipv4	ipv4: lock mtu in fnhe when received PMTU < net.ipv4.route.min_pmtu	2018-03-14 13:37:36 -04:00
ipv6	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec	2018-03-13 10:38:07 -04:00
iucv	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
kcm	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
key	af_key: Fix memory leak in key_notify_policy.	2018-01-10 09:45:11 +01:00
l2tp	l2tp: fix races with ipv4-mapped ipv6 addresses	2018-03-12 15:11:09 -04:00
l3mdev
lapb
llc	net: delete /proc THIS_MODULE references	2018-01-16 15:01:33 -05:00
mac80211	mac80211: drop frames with unexpected DS bits from fast-rx to slow path	2018-02-23 12:13:17 +01:00
mac802154
mpls	net: rename skb_gso_validate_mtu -> skb_gso_validate_network_len	2018-03-04 17:49:17 -05:00
ncsi	net/ncsi: Don't take any action on HNCDSC AEN	2017-12-18 14:50:11 -05:00
netfilter	netfilter: nf_tables: release flowtable hooks	2018-03-11 21:24:56 +01:00
netlabel
netlink	netlink: put module reference if dump start fails	2018-02-22 14:01:38 -05:00
netrom	net: delete /proc THIS_MODULE references	2018-01-16 15:01:33 -05:00
nfc	NFC: llcp: Limit size of SDP URI	2018-02-16 15:16:05 -05:00
nsh
openvswitch	openvswitch: meter: fix the incorrect calculation of max delta_t	2018-03-11 22:48:59 -04:00
packet	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
phonet	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
psample
qrtr	qrtr: add MODULE_ALIAS macro to smd	2018-02-26 15:07:04 -05:00
rds	rds: Incorrect reference counting in TCP socket creation	2018-03-02 09:40:27 -05:00
rfkill	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
rose	net: delete /proc THIS_MODULE references	2018-01-16 15:01:33 -05:00
rxrpc	rxrpc: Fix send in rxrpc_send_data_packet()	2018-02-22 15:37:47 -05:00
sched	net sched actions: return explicit error when tunnel_key mode is not specified	2018-03-15 14:43:41 -04:00
sctp	net: use skb_is_gso_sctp() instead of open-coding	2018-03-09 11:41:47 -05:00
smc	net/smc: simplify wait when closing listen socket	2018-03-15 09:49:13 -04:00
strparser	strparser: Call sock_owned_by_user_nocheck	2017-12-28 14:28:22 -05:00
sunrpc	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
switchdev
tipc	tipc: correct initial value for group congestion flag	2018-02-27 11:46:03 -05:00
tls	tls: Use correct sk->sk_prot for IPV6	2018-02-27 14:41:48 -05:00
unix	net: af_unix: fix typo in UNIX_SKB_FRAGS_SZ comment	2018-02-13 12:21:45 -05:00
vmw_vsock	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
wimax
wireless	cfg80211: add missing dependency to CFG80211 suboptions	2018-02-27 10:54:12 +01:00
x25
xfrm	Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/klassert/ipsec	2018-03-13 10:38:07 -04:00
compat.c
Kconfig	Staging/IIO patches for 4.16-rc1	2018-02-01 09:51:57 -08:00
Makefile	ipx: move Novell IPX protocol support into staging	2017-11-28 13:55:00 +01:00
socket.c	sock_diag: request _diag module only when the family or proto has been registered	2018-03-12 11:03:42 -04:00
sysctl_net.c