Christian Brauner 0ede61d858 file: convert to SLAB_TYPESAFE_BY_RCU ... In recent discussions around some performance improvements in the file handling area we discussed switching the file cache to rely on SLAB_TYPESAFE_BY_RCU which allows us to get rid of call_rcu() based freeing for files completely. This is a pretty sensitive change overall but it might actually be worth doing. The main downside is the subtlety. The other one is that we should really wait for Jann's patch to land that enables KASAN to handle SLAB_TYPESAFE_BY_RCU UAFs. Currently it doesn't but a patch for this exists. With SLAB_TYPESAFE_BY_RCU objects may be freed and reused multiple times which requires a few changes. So it isn't sufficient anymore to just acquire a reference to the file in question under rcu using atomic_long_inc_not_zero() since the file might have already been recycled and someone else might have bumped the reference. In other words, callers might see reference count bumps from newer users. For this reason it is necessary to verify that the pointer is the same before and after the reference count increment. This pattern can be seen in get_file_rcu() and __files_get_rcu(). In addition, it isn't possible to access or check fields in struct file without first aqcuiring a reference on it. Not doing that was always very dodgy and it was only usable for non-pointer data in struct file. With SLAB_TYPESAFE_BY_RCU it is necessary that callers first acquire a reference under rcu or they must hold the files_lock of the fdtable. Failing to do either one of this is a bug. Thanks to Jann for pointing out that we need to ensure memory ordering between reallocations and pointer check by ensuring that all subsequent loads have a dependency on the second load in get_file_rcu() and providing a fixup that was folded into this patch. Cc: Jann Horn <jannh@google.com> Suggested-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Christian Brauner <brauner@kernel.org>		2023-10-19 11:02:48 +02:00
..
9p	- Some swap cleanups from Ma Wupeng ("fix WARN_ON in add_to_avail_list")	2023-08-29 14:25:26 -07:00
adfs	for-6.6/block-2023-08-28	2023-08-29 20:21:42 -07:00
affs	for-6.6/block-2023-08-28	2023-08-29 20:21:42 -07:00
afs	- Some swap cleanups from Ma Wupeng ("fix WARN_ON in add_to_avail_list")	2023-08-29 14:25:26 -07:00
autofs	v6.6-vfs.autofs	2023-08-28 11:39:14 -07:00
befs	for-6.6/block-2023-08-28	2023-08-29 20:21:42 -07:00
bfs	for-6.6/block-2023-08-28	2023-08-29 20:21:42 -07:00
btrfs	- Some swap cleanups from Ma Wupeng ("fix WARN_ON in add_to_avail_list")	2023-08-29 14:25:26 -07:00
cachefiles	- Some swap cleanups from Ma Wupeng ("fix WARN_ON in add_to_avail_list")	2023-08-29 14:25:26 -07:00
ceph	Mixed with some fixes and cleanups, this brings in reasonably complete	2023-09-06 12:10:15 -07:00
coda	v6.6-vfs.ctime	2023-08-28 09:31:32 -07:00
configfs	configfs: convert to ctime accessor functions	2023-07-13 10:28:05 +02:00
cramfs	v6.6-vfs.super	2023-08-28 11:04:18 -07:00
crypto
debugfs	Char/Misc driver changes for 6.6-rc1	2023-09-01 09:53:54 -07:00
devpts	v6.6-vfs.misc	2023-08-28 10:17:14 -07:00
dlm	dlm: fix plock lookup when using multiple lockspaces	2023-08-25 10:31:39 -05:00
ecryptfs	v6.6-vfs.misc	2023-08-28 10:17:14 -07:00
efivarfs	efivarfs: convert to ctime accessor functions	2023-07-13 10:28:06 +02:00
efs	for-6.6/block-2023-08-28	2023-08-29 20:21:42 -07:00
erofs	- Some swap cleanups from Ma Wupeng ("fix WARN_ON in add_to_avail_list")	2023-08-29 14:25:26 -07:00
exfat	for-6.6/block-2023-08-28	2023-08-29 20:21:42 -07:00
exportfs	exportfs: remove kernel-doc warnings in exportfs	2023-08-29 17:45:22 -04:00
ext2	\n	2023-08-30 12:10:50 -07:00
ext4	Many ext4 and jbd2 cleanups and bug fixes for v6.6-rc1.	2023-08-31 15:18:15 -07:00
f2fs	f2fs update for 6.6-rc1	2023-09-02 15:37:59 -07:00
fat	for-6.6/block-2023-08-28	2023-08-29 20:21:42 -07:00
freevxfs	for-6.6/block-2023-08-28	2023-08-29 20:21:42 -07:00
fscache
fuse	fuse update for 6.6	2023-09-05 12:45:55 -07:00
gfs2	file: convert to SLAB_TYPESAFE_BY_RCU	2023-10-19 11:02:48 +02:00
hfs	for-6.6/block-2023-08-28	2023-08-29 20:21:42 -07:00
hfsplus	for-6.6/block-2023-08-28	2023-08-29 20:21:42 -07:00
hostfs	hostfs: convert to ctime accessor functions	2023-07-24 10:30:00 +02:00
hpfs	for-6.6/block-2023-08-28	2023-08-29 20:21:42 -07:00
hugetlbfs	- Some swap cleanups from Ma Wupeng ("fix WARN_ON in add_to_avail_list")	2023-08-29 14:25:26 -07:00
iomap	for-6.6/block-2023-08-28	2023-08-29 20:21:42 -07:00
isofs	for-6.6/block-2023-08-28	2023-08-29 20:21:42 -07:00
jbd2	Many ext4 and jbd2 cleanups and bug fixes for v6.6-rc1.	2023-08-31 15:18:15 -07:00
jffs2	jffs2: convert to ctime accessor functions	2023-07-24 10:30:01 +02:00
jfs	A few small fixes	2023-08-31 15:25:01 -07:00
kernfs	Driver core changes for 6.6-rc1	2023-09-01 09:43:18 -07:00
lockd	SUNRPC: Add enum svc_auth_status	2023-08-29 17:45:22 -04:00
minix	for-6.6/block-2023-08-28	2023-08-29 20:21:42 -07:00
netfs
nfs	fs: add a new SB_I_NOUMASK flag	2023-10-19 11:02:47 +02:00
nfs_common
nfsd	NFSD 6.6 Release Notes	2023-08-31 15:32:18 -07:00
nilfs2	for-6.6/block-2023-08-28	2023-08-29 20:21:42 -07:00
nls	nls: Hide new NLS_UCS2_UTILS	2023-08-31 12:07:34 -05:00
notify	file: convert to SLAB_TYPESAFE_BY_RCU	2023-10-19 11:02:48 +02:00
ntfs	for-6.6/block-2023-08-28	2023-08-29 20:21:42 -07:00
ntfs3	ntfs3: drop inode references in ntfs_put_super()	2023-09-07 10:23:37 -07:00
ocfs2	Many ext4 and jbd2 cleanups and bug fixes for v6.6-rc1.	2023-08-31 15:18:15 -07:00
omfs	for-6.6/block-2023-08-28	2023-08-29 20:21:42 -07:00
openpromfs	openpromfs: convert to ctime accessor functions	2023-07-24 10:30:03 +02:00
orangefs	fs: drop the timespec64 argument from update_time	2023-08-11 09:04:57 +02:00
overlayfs	overlayfs update for 6.6	2023-08-30 11:54:09 -07:00
proc	file: convert to SLAB_TYPESAFE_BY_RCU	2023-10-19 11:02:48 +02:00
pstore	pstore fix for v6.6-rc1	2023-09-02 10:45:17 -07:00
qnx4	for-6.6/block-2023-08-28	2023-08-29 20:21:42 -07:00
qnx6	for-6.6/block-2023-08-28	2023-08-29 20:21:42 -07:00
quota	\n	2023-08-30 12:10:50 -07:00
ramfs	ramfs: convert to ctime accessor functions	2023-07-24 10:30:04 +02:00
reiserfs	for-6.6/block-2023-08-28	2023-08-29 20:21:42 -07:00
romfs	for-6.6/block-2023-08-28	2023-08-29 20:21:42 -07:00
smb	six smb3 client fixes, one fix for nls Kconfig, one minor spnego registry update	2023-09-09 19:56:23 -07:00
squashfs	squashfs: convert to ctime accessor functions	2023-07-24 10:30:05 +02:00
sysfs
sysv	for-6.6/block-2023-08-28	2023-08-29 20:21:42 -07:00
tracefs	Tracing updates for 6.6:	2023-09-01 16:34:25 -07:00
ubifs	fs: drop the timespec64 argument from update_time	2023-08-11 09:04:57 +02:00
udf	\n	2023-08-30 12:10:50 -07:00
ufs	for-6.6/block-2023-08-28	2023-08-29 20:21:42 -07:00
unicode
vboxsf	v6.6-vfs.ctime	2023-08-28 09:31:32 -07:00
verity	fsverity: skip PKCS#7 parser when keyring is empty	2023-08-20 10:33:43 -07:00
xfs	New code for 6.6:	2023-08-30 12:34:12 -07:00
zonefs	New code for 6.6:	2023-08-28 11:59:52 -07:00
aio.c	Add x86 shadow stack support	2023-08-31 12:20:12 -07:00
anon_inodes.c
attr.c	v6.6-vfs.misc	2023-08-28 10:17:14 -07:00
bad_inode.c	fs: drop the timespec64 argument from update_time	2023-08-11 09:04:57 +02:00
binfmt_elf_fdpic.c	binfmt_elf_fdpic: support 64-bit systems	2023-08-23 14:17:42 -07:00
binfmt_elf_test.c
binfmt_elf.c
binfmt_flat.c
binfmt_misc.c	fs: convert to ctime accessor functions	2023-07-13 10:28:04 +02:00
binfmt_script.c
buffer.c	for-6.6/block-2023-08-28	2023-08-29 20:21:42 -07:00
char_dev.c
compat_binfmt_elf.c
coredump.c
d_path.c
dax.c	mm: remove enum page_entry_size	2023-08-24 16:20:30 -07:00
dcache.c	fs/dcache: Replace printk and WARN_ON by WARN	2023-08-19 13:41:11 +02:00
direct-io.c
drop_caches.c	fs: drop_caches: draining pages before dropping caches	2023-08-18 10:12:11 -07:00
eventfd.c
eventpoll.c	epoll: simplify ep_alloc()	2023-07-26 14:56:07 +02:00
exec.c	- An extensive rework of kexec and crash Kconfig from Eric DeVolder	2023-08-29 14:53:51 -07:00
fcntl.c
fhandle.c
file_table.c	file: convert to SLAB_TYPESAFE_BY_RCU	2023-10-19 11:02:48 +02:00
file.c	file: convert to SLAB_TYPESAFE_BY_RCU	2023-10-19 11:02:48 +02:00
filesystems.c
fs_context.c	v6.6-vfs.misc	2023-08-28 10:17:14 -07:00
fs_parser.c
fs_pin.c
fs_struct.c	kill do_each_thread()	2023-08-21 13:46:25 -07:00
fs_types.c
fs-writeback.c	super: make locking naming consistent	2023-08-21 14:36:57 +02:00
fsopen.c	fs: add FSCONFIG_CMD_CREATE_EXCL	2023-08-14 18:48:02 +02:00
init.c	fs: add a new SB_I_NOUMASK flag	2023-10-19 11:02:47 +02:00
inode.c	fs: rename __mnt_{want,drop}_write*() helpers	2023-09-11 15:05:50 +02:00
internal.h	vfs: shave work on failed file open	2023-10-19 11:02:48 +02:00
ioctl.c	v6.6-vfs.super	2023-08-28 11:04:18 -07:00
Kconfig	for-6.6/block-2023-08-28	2023-08-29 20:21:42 -07:00
Kconfig.binfmt	riscv: support the elf-fdpic binfmt loader	2023-08-23 14:17:43 -07:00
kernel_read_file.c	fs: Fix kernel-doc warnings	2023-08-19 12:12:12 +02:00
libfs.c	Many ext4 and jbd2 cleanups and bug fixes for v6.6-rc1.	2023-08-31 15:18:15 -07:00
locks.c	NFSD 6.6 Release Notes	2023-08-31 15:32:18 -07:00
Makefile	fs: add CONFIG_BUFFER_HEAD	2023-08-02 09:13:09 -06:00
mbcache.c
mnt_idmapping.c
mount.h
mpage.c
namei.c	vfs: shave work on failed file open	2023-10-19 11:02:48 +02:00
namespace.c	fs: export mnt_{get,put}_write_access() to modules	2023-09-11 15:05:52 +02:00
nsfs.c	fs: convert to ctime accessor functions	2023-07-13 10:28:04 +02:00
open.c	fs: rename __mnt_{want,drop}_write*() helpers	2023-09-11 15:05:50 +02:00
pipe.c	fs/pipe: use spinlock in pipe_read() only if there is a watch_queue	2023-10-19 11:02:48 +02:00
pnode.c
pnode.h
posix_acl.c	fs: convert to ctime accessor functions	2023-07-13 10:28:04 +02:00
proc_namespace.c
read_write.c	fs: Fix one kernel-doc comment	2023-08-15 08:32:45 +02:00
readdir.c	vfs: get rid of old '->iterate' directory operation	2023-08-06 15:08:35 +02:00
remap_range.c
select.c
seq_file.c
signalfd.c
splice.c	- Some swap cleanups from Ma Wupeng ("fix WARN_ON in add_to_avail_list")	2023-08-29 14:25:26 -07:00
stack.c	fs: convert to ctime accessor functions	2023-07-13 10:28:04 +02:00
stat.c	vfs: mostly undo glibc turning 'fstat()' into 'fstatat(AT_EMPTY_PATH)'	2023-09-07 09:40:30 -07:00
statfs.c
super.c	fs: export sget_dev()	2023-08-31 12:47:15 +02:00
sync.c
sysctls.c
timerfd.c
userfaultfd.c	mm: userfaultfd: remove stale comment about core dump locking	2023-08-24 16:20:27 -07:00
utimes.c
xattr.c	tmpfs,xattr: GFP_KERNEL_ACCOUNT for simple xattrs	2023-08-22 10:57:46 +02:00