Arnd Bergmann 608f729c31 scsi: qla4xxx: avoid freeing unallocated dma memory ... Clang -Wuninitialized notices that on is_qla40XX we never allocate any DMA memory in get_fw_boot_info() but attempt to free it anyway: drivers/scsi/qla4xxx/ql4_os.c:5915:7: error: variable 'buf_dma' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] if (!(val & 0x07)) { ^~~~~~~~~~~~~ drivers/scsi/qla4xxx/ql4_os.c:5985:47: note: uninitialized use occurs here dma_free_coherent(&ha->pdev->dev, size, buf, buf_dma); ^~~~~~~ drivers/scsi/qla4xxx/ql4_os.c:5915:3: note: remove the 'if' if its condition is always true if (!(val & 0x07)) { ^~~~~~~~~~~~~~~~~~~ drivers/scsi/qla4xxx/ql4_os.c:5885:20: note: initialize the variable 'buf_dma' to silence this warning dma_addr_t buf_dma; ^ = 0 Skip the call to dma_free_coherent() here. Fixes: 2a991c2159 ("[SCSI] qla4xxx: Boot from SAN support for open-iscsi") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Nathan Chancellor <natechancellor@gmail.com> Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>		2019-03-25 22:17:26 -04:00
..
Kconfig
Makefile
ql4_83xx.c
ql4_83xx.h
ql4_attr.c
ql4_bsg.c
ql4_bsg.h
ql4_dbg.c
ql4_dbg.h
ql4_def.h	scsi: qla4xxx: skip error recovery in case of register disconnect.	2018-02-13 21:35:41 -05:00
ql4_fw.h
ql4_glbl.h
ql4_init.c	cross-tree: phase out dma_zalloc_coherent()	2019-01-08 07:58:37 -05:00
ql4_inline.h
ql4_iocb.c
ql4_isr.c
ql4_mbx.c	cross-tree: phase out dma_zalloc_coherent()	2019-01-08 07:58:37 -05:00
ql4_nvram.c
ql4_nvram.h
ql4_nx.c	cross-tree: phase out dma_zalloc_coherent()	2019-01-08 07:58:37 -05:00
ql4_nx.h	scsi: qla4xxx: Move an array from a .h into a .c file	2018-02-12 11:43:24 -05:00
ql4_os.c	scsi: qla4xxx: avoid freeing unallocated dma memory	2019-03-25 22:17:26 -04:00
ql4_version.h