mirror of
https://github.com/torvalds/linux.git
synced 2024-11-26 06:02:05 +00:00
d93cca2f31
Commit656e9007ef("asm-generic: avoid __generic_cmpxchg_local warnings") introduced a typo that means the code is incorrect for 32 bit values. It will work fine for postive numbers, but will fail for negative numbers on a system where longs are 64 bit. Fixes:656e9007ef("asm-generic: avoid __generic_cmpxchg_local warnings") Signed-off-by: David McKay <david.mckay@codasip.com> Signed-off-by: Stuart Menefy <stuart.menefy@codasip.com> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
69 lines
1.5 KiB
C
69 lines
1.5 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef __ASM_GENERIC_CMPXCHG_LOCAL_H
|
|
#define __ASM_GENERIC_CMPXCHG_LOCAL_H
|
|
|
|
#include <linux/types.h>
|
|
#include <linux/irqflags.h>
|
|
|
|
extern unsigned long wrong_size_cmpxchg(volatile void *ptr)
|
|
__noreturn;
|
|
|
|
/*
|
|
* Generic version of __cmpxchg_local (disables interrupts). Takes an unsigned
|
|
* long parameter, supporting various types of architectures.
|
|
*/
|
|
static inline unsigned long __generic_cmpxchg_local(volatile void *ptr,
|
|
unsigned long old, unsigned long new, int size)
|
|
{
|
|
unsigned long flags, prev;
|
|
|
|
/*
|
|
* Sanity checking, compile-time.
|
|
*/
|
|
if (size == 8 && sizeof(unsigned long) != 8)
|
|
wrong_size_cmpxchg(ptr);
|
|
|
|
raw_local_irq_save(flags);
|
|
switch (size) {
|
|
case 1: prev = *(u8 *)ptr;
|
|
if (prev == (old & 0xffu))
|
|
*(u8 *)ptr = (new & 0xffu);
|
|
break;
|
|
case 2: prev = *(u16 *)ptr;
|
|
if (prev == (old & 0xffffu))
|
|
*(u16 *)ptr = (new & 0xffffu);
|
|
break;
|
|
case 4: prev = *(u32 *)ptr;
|
|
if (prev == (old & 0xffffffffu))
|
|
*(u32 *)ptr = (new & 0xffffffffu);
|
|
break;
|
|
case 8: prev = *(u64 *)ptr;
|
|
if (prev == old)
|
|
*(u64 *)ptr = (u64)new;
|
|
break;
|
|
default:
|
|
wrong_size_cmpxchg(ptr);
|
|
}
|
|
raw_local_irq_restore(flags);
|
|
return prev;
|
|
}
|
|
|
|
/*
|
|
* Generic version of __cmpxchg64_local. Takes an u64 parameter.
|
|
*/
|
|
static inline u64 __generic_cmpxchg64_local(volatile void *ptr,
|
|
u64 old, u64 new)
|
|
{
|
|
u64 prev;
|
|
unsigned long flags;
|
|
|
|
raw_local_irq_save(flags);
|
|
prev = *(u64 *)ptr;
|
|
if (prev == old)
|
|
*(u64 *)ptr = new;
|
|
raw_local_irq_restore(flags);
|
|
return prev;
|
|
}
|
|
|
|
#endif
|