Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-11-24 13:11:40 +00:00
Code Issues Packages Projects Releases Wiki Activity
4d73644bc3
linux/drivers/block/paride
History
Arnd Bergmann dec63a4dec paride: make 'verbose' parameter an 'int' again 
gcc-6.0 found an ancient bug in the paride driver, which had a
"module_param(verbose, bool, 0);" since before 2.6.12, but actually uses
it to accept '0', '1' or '2' as arguments:

  drivers/block/paride/pd.c: In function 'pd_init_dev_parms':
  drivers/block/paride/pd.c:298:29: warning: comparison of constant '1' with boolean expression is always false [-Wbool-compare]
   #define DBMSG(msg) ((verbose>1)?(msg):NULL)

In 2012, Rusty did a cleanup patch that also changed the type of the
variable to 'bool', which introduced what is now a gcc warning.

This changes the type back to 'int' and adapts the module_param() line
instead, so it should work as documented in case anyone ever cares about
running the ancient driver with debugging.

Fixes: 90ab5ee941 ("module_param: make bool parameters really bool (drivers & misc)")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Rusty Russell <rusty@rustcorp.com.au>
Cc: Tim Waugh <tim@cyberelk.net>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: Jens Axboe <axboe@fb.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
2016-03-15 16:55:16 -07:00
..
aten.c [PATCH] paride_register(): shuffle return values 2006-12-07 08:39:33 -08:00
bpck6.c module_param: make bool parameters really bool (drivers & misc) 2012-01-13 09:32:20 +10:30
bpck.c [PATCH] paride_register(): shuffle return values 2006-12-07 08:39:33 -08:00
comm.c [PATCH] paride_register(): shuffle return values 2006-12-07 08:39:33 -08:00
dstr.c [PATCH] paride_register(): shuffle return values 2006-12-07 08:39:33 -08:00
epat.c [PATCH] paride_register(): shuffle return values 2006-12-07 08:39:33 -08:00
epia.c [PATCH] paride_register(): shuffle return values 2006-12-07 08:39:33 -08:00
fit2.c [PATCH] paride_register(): shuffle return values 2006-12-07 08:39:33 -08:00
fit3.c [PATCH] paride_register(): shuffle return values 2006-12-07 08:39:33 -08:00
friq.c [PATCH] paride_register(): shuffle return values 2006-12-07 08:39:33 -08:00
frpw.c [PATCH] paride_register(): shuffle return values 2006-12-07 08:39:33 -08:00
kbic.c [PATCH] paride_register(): shuffle return values 2006-12-07 08:39:33 -08:00
Kconfig drivers/block/paride: remove depends on CONFIG_EXPERIMENTAL 2013-01-21 14:52:42 -08:00
ktti.c [PATCH] paride_register(): shuffle return values 2006-12-07 08:39:33 -08:00
Makefile
mkd
on20.c [PATCH] paride_register(): shuffle return values 2006-12-07 08:39:33 -08:00
on26.c [PATCH] paride_register(): shuffle return values 2006-12-07 08:39:33 -08:00
paride.c paride: use new parport device model 2015-06-01 07:10:23 +09:00
paride.h paride: use new parport device model 2015-06-01 07:10:23 +09:00
pcd.c paride: use new parport device model 2015-06-01 07:10:23 +09:00
pd.c paride: make 'verbose' parameter an 'int' again 2016-03-15 16:55:16 -07:00
pf.c paride: use new parport device model 2015-06-01 07:10:23 +09:00
pg.c paride: use new parport device model 2015-06-01 07:10:23 +09:00
ppc6lnx.c
pseudo.h
pt.c paride: make 'verbose' parameter an 'int' again 2016-03-15 16:55:16 -07:00
Transition-notes