Leon Romanovsky 4b658d1bbc RDMA/ucma: Check that device is connected prior to access it ... Add missing check that device is connected prior to access it. [ 55.358652] BUG: KASAN: null-ptr-deref in rdma_init_qp_attr+0x4a/0x2c0 [ 55.359389] Read of size 8 at addr 00000000000000b0 by task qp/618 [ 55.360255] [ 55.360432] CPU: 1 PID: 618 Comm: qp Not tainted 4.16.0-rc1-00071-gcaf61b1b8b88 #91 [ 55.361693] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.11.0-0-g63451fca13-prebuilt.qemu-project.org 04/01/2014 [ 55.363264] Call Trace: [ 55.363833] dump_stack+0x5c/0x77 [ 55.364215] kasan_report+0x163/0x380 [ 55.364610] ? rdma_init_qp_attr+0x4a/0x2c0 [ 55.365238] rdma_init_qp_attr+0x4a/0x2c0 [ 55.366410] ucma_init_qp_attr+0x111/0x200 [ 55.366846] ? ucma_notify+0xf0/0xf0 [ 55.367405] ? _get_random_bytes+0xea/0x1b0 [ 55.367846] ? urandom_read+0x2f0/0x2f0 [ 55.368436] ? kmem_cache_alloc_trace+0xd2/0x1e0 [ 55.369104] ? refcount_inc_not_zero+0x9/0x60 [ 55.369583] ? refcount_inc+0x5/0x30 [ 55.370155] ? rdma_create_id+0x215/0x240 [ 55.370937] ? _copy_to_user+0x4f/0x60 [ 55.371620] ? mem_cgroup_commit_charge+0x1f5/0x290 [ 55.372127] ? _copy_from_user+0x5e/0x90 [ 55.372720] ucma_write+0x174/0x1f0 [ 55.373090] ? ucma_close_id+0x40/0x40 [ 55.373805] ? __lru_cache_add+0xa8/0xd0 [ 55.374403] __vfs_write+0xc4/0x350 [ 55.374774] ? kernel_read+0xa0/0xa0 [ 55.375173] ? fsnotify+0x899/0x8f0 [ 55.375544] ? fsnotify_unmount_inodes+0x170/0x170 [ 55.376689] ? __fsnotify_update_child_dentry_flags+0x30/0x30 [ 55.377522] ? handle_mm_fault+0x174/0x320 [ 55.378169] vfs_write+0xf7/0x280 [ 55.378864] SyS_write+0xa1/0x120 [ 55.379270] ? SyS_read+0x120/0x120 [ 55.379643] ? mm_fault_error+0x180/0x180 [ 55.380071] ? task_work_run+0x7d/0xd0 [ 55.380910] ? __task_pid_nr_ns+0x120/0x140 [ 55.381366] ? SyS_read+0x120/0x120 [ 55.381739] do_syscall_64+0xeb/0x250 [ 55.382143] entry_SYSCALL_64_after_hwframe+0x21/0x86 [ 55.382841] RIP: 0033:0x7fc2ef803e99 [ 55.383227] RSP: 002b:00007fffcc5f3be8 EFLAGS: 00000217 ORIG_RAX: 0000000000000001 [ 55.384173] RAX: ffffffffffffffda RBX: 0000000000000000 RCX: 00007fc2ef803e99 [ 55.386145] RDX: 0000000000000057 RSI: 0000000020000080 RDI: 0000000000000003 [ 55.388418] RBP: 00007fffcc5f3c00 R08: 0000000000000000 R09: 0000000000000000 [ 55.390542] R10: 0000000000000000 R11: 0000000000000217 R12: 0000000000400480 [ 55.392916] R13: 00007fffcc5f3cf0 R14: 0000000000000000 R15: 0000000000000000 [ 55.521088] Code: e5 4d 1e ff 48 89 df 44 0f b6 b3 b8 01 00 00 e8 65 50 1e ff 4c 8b 2b 49 8d bd b0 00 00 00 e8 56 50 1e ff 41 0f b6 c6 48 c1 e0 04 <49> 03 85 b0 00 00 00 48 8d 78 08 48 89 04 24 e8 3a 4f 1e ff 48 [ 55.525980] RIP: rdma_init_qp_attr+0x52/0x2c0 RSP: ffff8801e2c2f9d8 [ 55.532648] CR2: 00000000000000b0 [ 55.534396] ---[ end trace 70cee64090251c0b ]--- Fixes: 7521663857 ("RDMA/cma: Export rdma cm interface to userspace") Fixes: d541e45500 ("IB/core: Convert ah_attr from OPA to IB when copying to user") Reported-by: <syzbot+7b62c837c2516f8f38c8@syzkaller.appspotmail.com> Signed-off-by: Leon Romanovsky <leonro@mellanox.com> Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>		2018-03-27 14:10:45 -06:00
..
addr.c	RDMA/rdma_cm: Fix use after free race with process_one_req	2018-03-27 13:19:01 -06:00
agent.c	IB/core: Rename ib_destroy_ah to rdma_destroy_ah	2017-05-01 14:32:43 -04:00
agent.h
cache.c	{net, IB}/mlx5: Manage port association for multiport RoCE	2018-01-08 11:42:22 -07:00
cgroup.c	IB/core: added support to use rdma cgroup controller	2017-01-10 11:14:27 -05:00
cm_msgs.h
cm.c	RDMA/cm: Fix access to uninitialized variable	2018-01-28 14:07:16 -07:00
cma_configfs.c	IB/cma: use strlcpy() instead of strncpy()	2018-01-15 15:33:21 -07:00
cma.c	RDMA/ucma: Fix access to non-initialized CM_ID object	2018-03-14 16:22:55 -04:00
core_priv.h	RDMA/restrack: don't use uaccess_kernel()	2018-02-16 10:18:11 -07:00
cq.c	RDMA/core: Reduce poll batch for direct cq polling	2018-03-06 20:08:39 -07:00
device.c	RDMA/restrack: Move restrack_clean to be symmetrical to restrack_init	2018-03-21 14:22:22 -06:00
fmr_pool.c	infiniband: fix core/fmr_pool.c kernel-doc notation	2018-01-10 22:00:34 -07:00
iwcm.c	RDMA/netlink: Fix general protection fault	2017-12-07 15:28:07 -05:00
iwcm.h	iw_cm: free cm_id resources on the last deref	2016-08-02 13:15:18 -04:00
iwpm_msg.c	RDMA/iwpm: Properly mark end of NL messages	2017-09-29 11:32:42 -04:00
iwpm_util.c	RDMA/iwpm: Fix uninitialized error code in iwpm_send_mapinfo()	2017-12-13 10:55:49 -07:00
iwpm_util.h	iwpm: crash fix for large connections test	2016-03-16 13:48:32 -04:00
mad_priv.h
mad_rmpp.c	IB/mad: Change slid in RMPP recv from 16 to 32 bits	2017-08-08 14:47:18 -04:00
mad_rmpp.h
mad.c	drivers: infiniband: remove duplicate includes	2017-12-22 09:39:35 -07:00
Makefile	RDMA/restrack: Add general infrastructure to track RDMA resources	2018-01-29 20:21:39 -07:00
mr_pool.c	IB/core: add a simple MR pool	2016-05-13 13:37:18 -04:00
multicast.c	IB/core: Define 'ib' and 'roce' rdma_ah_attr types	2017-05-01 14:32:43 -04:00
netlink.c	RDMA/netlink: Simplify code of autoload modules	2018-01-02 13:36:57 -07:00
nldev.c	RDMA/nldev: missing error code in nldev_res_get_doit()	2018-02-01 15:24:32 -07:00
opa_smi.h
packer.c	IB/core: trivial prink cleanup.	2016-03-03 10:20:25 -05:00
rdma_core.c	IB/uverbs: Fix unbalanced unlock on error path for rdma_explicit_destroy	2018-02-15 15:31:26 -07:00
rdma_core.h	IB/core: Add new ioctl interface	2017-08-31 08:35:09 -04:00
restrack.c	RDMA/restrack: don't use uaccess_kernel()	2018-02-16 10:18:11 -07:00
roce_gid_mgmt.c	{net, IB}/mlx5: Manage port association for multiport RoCE	2018-01-08 11:42:22 -07:00
rw.c	IB/core: remove redundant check on prot_sg_cnt	2017-10-10 10:49:45 -04:00
sa_query.c	IB/core: Fix possible crash to access NULL netdev	2018-03-07 15:15:40 -05:00
sa.h
security.c	Merge branch 'from-rc' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git	2017-12-27 21:50:46 -07:00
smi.c
smi.h
sysfs.c	IB/core: Fix two kernel warnings triggered by rxe registration	2018-01-03 17:26:59 -07:00
ucm.c	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
ucma.c	RDMA/ucma: Check that device is connected prior to access it	2018-03-27 14:10:45 -06:00
ud_header.c	IB/core: trivial prink cleanup.	2016-03-03 10:20:25 -05:00
umem_odp.c	RDMA/umem: Avoid partial declaration of non-static function	2017-11-10 13:02:12 -05:00
umem.c	IB/umem: Fix use of npages/nmap fields	2017-12-18 15:37:06 -07:00
user_mad.c	vfs: do bulk POLL* -> EPOLL* replacement	2018-02-11 14:34:03 -08:00
uverbs_cmd.c	RDMA/uverbs: Fix kernel panic while using XRC_TGT QP type	2018-02-21 13:52:19 -05:00
uverbs_ioctl_merge.c	IB/uverbs: Fix method merging in uverbs_ioctl_merge	2018-02-15 14:59:45 -07:00
uverbs_ioctl.c	IB/uverbs: Fix possible oops with duplicate ioctl attributes	2018-02-15 14:59:46 -07:00
uverbs_main.c	RDMA/uverbs: Protect from command mask overflow	2018-02-15 15:31:26 -07:00
uverbs_marshall.c	IB/core: Convert OPA AH to IB for Extended LIDs only	2017-11-13 15:53:57 -05:00
uverbs_std_types.c	IB/uverbs: Use u64_to_user_ptr() not a union	2018-02-15 14:59:45 -07:00
uverbs.h	IB/uverbs: Allow CQ moderation with modify CQ	2017-11-13 16:59:22 -05:00
verbs.c	RDMA/restrack: don't use uaccess_kernel()	2018-02-16 10:18:11 -07:00