mirror of
https://github.com/torvalds/linux.git
synced 2024-11-24 21:21:41 +00:00
a986a05de9
Having multiple loadable modules with the same name cannot work
with modprobe, and having both net/qrtr/smd.ko and drivers/soc/qcom/smd.ko
results in a (somewhat cryptic) build error:
ERROR: "qcom_smd_driver_unregister" [net/qrtr/smd.ko] undefined!
ERROR: "qcom_smd_driver_register" [net/qrtr/smd.ko] undefined!
ERROR: "qcom_smd_set_drvdata" [net/qrtr/smd.ko] undefined!
ERROR: "qcom_smd_send" [net/qrtr/smd.ko] undefined!
ERROR: "qcom_smd_get_drvdata" [net/qrtr/smd.ko] undefined!
ERROR: "qcom_smd_driver_unregister" [drivers/soc/qcom/wcnss_ctrl.ko] undefined!
ERROR: "qcom_smd_driver_register" [drivers/soc/qcom/wcnss_ctrl.ko] undefined!
ERROR: "qcom_smd_set_drvdata" [drivers/soc/qcom/wcnss_ctrl.ko] undefined!
ERROR: "qcom_smd_send" [drivers/soc/qcom/wcnss_ctrl.ko] undefined!
ERROR: "qcom_smd_get_drvdata" [drivers/soc/qcom/wcnss_ctrl.ko] undefined!
Also, the qrtr driver uses the SMD interface and has a Kconfig dependency,
but also allows for compile-testing when SMD is disabled. However, if
with QCOM_SMD=m and COMPILE_TEST=y we can end up with QRTR_SMD=y and
that fails with a related link error.
The changes the dependency so we can still compile-test the driver but
not have it built-in if SMD is a module, to avoid running in the broken
configuration, and changes the Makefile to provide the driver under
a different module name.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: bdabad3e36 ("net: Add Qualcomm IPC router")
Signed-off-by: David S. Miller <davem@davemloft.net>
25 lines
657 B
Plaintext
25 lines
657 B
Plaintext
# Qualcomm IPC Router configuration
|
|
#
|
|
|
|
config QRTR
|
|
tristate "Qualcomm IPC Router support"
|
|
depends on ARCH_QCOM || COMPILE_TEST
|
|
---help---
|
|
Say Y if you intend to use Qualcomm IPC router protocol. The
|
|
protocol is used to communicate with services provided by other
|
|
hardware blocks in the system.
|
|
|
|
In order to do service lookups, a userspace daemon is required to
|
|
maintain a service listing.
|
|
|
|
if QRTR
|
|
|
|
config QRTR_SMD
|
|
tristate "SMD IPC Router channels"
|
|
depends on QCOM_SMD || (COMPILE_TEST && QCOM_SMD=n)
|
|
---help---
|
|
Say Y here to support SMD based ipcrouter channels. SMD is the
|
|
most common transport for IPC Router.
|
|
|
|
endif # QRTR
|