mirror of
https://github.com/torvalds/linux.git
synced 2024-11-25 05:32:00 +00:00
9722c3b66e
The of_property_for_each_u32() macro needs five parameters, two of which
are primarily meant as internal variables for the macro itself (in the
for() clause). Yet these two parameters are used by a few drivers, and this
can be considered misuse or at least bad practice.
Now that the kernel uses C11 to build, these two parameters can be avoided
by declaring them internally, thus changing this pattern:
struct property *prop;
const __be32 *p;
u32 val;
of_property_for_each_u32(np, "xyz", prop, p, val) { ... }
to this:
u32 val;
of_property_for_each_u32(np, "xyz", val) { ... }
However two variables cannot be declared in the for clause even with C11,
so declare one struct that contain the two variables we actually need. As
the variables inside this struct are not meant to be used by users of this
macro, give the struct instance the noticeable name "_it" so it is visible
during code reviews, helping to avoid new code to use it directly.
Most usages are trivially converted as they do not use those two
parameters, as expected. The non-trivial cases are:
- drivers/clk/clk.c, of_clk_get_parent_name(): easily doable anyway
- drivers/clk/clk-si5351.c, si5351_dt_parse(): this is more complex as the
checks had to be replicated in a different way, making code more verbose
and somewhat uglier, but I refrained from a full rework to keep as much
of the original code untouched having no hardware to test my changes
All the changes have been build tested. The few for which I have the
hardware have been runtime-tested too.
Reviewed-by: Andre Przywara <andre.przywara@arm.com> # drivers/clk/sunxi/clk-simple-gates.c, drivers/clk/sunxi/clk-sun8i-bus-gates.c
Acked-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> # drivers/gpio/gpio-brcmstb.c
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> # drivers/irqchip/irq-atmel-aic-common.c
Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> # drivers/iio/adc/ti_am335x_adc.c
Acked-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com> # drivers/pwm/pwm-samsung.c
Acked-by: Richard Leitner <richard.leitner@linux.dev> # drivers/usb/misc/usb251xb.c
Acked-by: Mark Brown <broonie@kernel.org> # sound/soc/codecs/arizona.c
Reviewed-by: Richard Fitzgerald <rf@opensource.cirrus.com> # sound/soc/codecs/arizona.c
Acked-by: Michael Ellerman <mpe@ellerman.id.au> # arch/powerpc/sysdev/xive/spapr.c
Acked-by: Stephen Boyd <sboyd@kernel.org> # clk
Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
Acked-by: Lee Jones <lee@kernel.org>
Link: https://lore.kernel.org/r/20240724-of_property_for_each_u32-v3-1-bea82ce429e2@bootlin.com
Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
108 lines
2.6 KiB
C
108 lines
2.6 KiB
C
// SPDX-License-Identifier: GPL-2.0-or-later
|
|
/*
|
|
* Copyright (C) 2015 Jens Kuske <jenskuske@gmail.com>
|
|
*
|
|
* Based on clk-simple-gates.c, which is:
|
|
* Copyright 2015 Maxime Ripard
|
|
*
|
|
* Maxime Ripard <maxime.ripard@free-electrons.com>
|
|
*/
|
|
|
|
#include <linux/clk-provider.h>
|
|
#include <linux/io.h>
|
|
#include <linux/of.h>
|
|
#include <linux/of_address.h>
|
|
#include <linux/slab.h>
|
|
#include <linux/spinlock.h>
|
|
|
|
static DEFINE_SPINLOCK(gates_lock);
|
|
|
|
static void __init sun8i_h3_bus_gates_init(struct device_node *node)
|
|
{
|
|
static const char * const names[] = { "ahb1", "ahb2", "apb1", "apb2" };
|
|
enum { AHB1, AHB2, APB1, APB2, PARENT_MAX } clk_parent;
|
|
const char *parents[PARENT_MAX];
|
|
struct clk_onecell_data *clk_data;
|
|
const char *clk_name;
|
|
struct resource res;
|
|
void __iomem *clk_reg;
|
|
void __iomem *reg;
|
|
int number, i;
|
|
u8 clk_bit;
|
|
int index;
|
|
|
|
reg = of_io_request_and_map(node, 0, of_node_full_name(node));
|
|
if (IS_ERR(reg))
|
|
return;
|
|
|
|
for (i = 0; i < ARRAY_SIZE(names); i++) {
|
|
int idx = of_property_match_string(node, "clock-names",
|
|
names[i]);
|
|
if (idx < 0)
|
|
return;
|
|
|
|
parents[i] = of_clk_get_parent_name(node, idx);
|
|
}
|
|
|
|
clk_data = kmalloc(sizeof(struct clk_onecell_data), GFP_KERNEL);
|
|
if (!clk_data)
|
|
goto err_unmap;
|
|
|
|
number = of_property_count_u32_elems(node, "clock-indices");
|
|
of_property_read_u32_index(node, "clock-indices", number - 1, &number);
|
|
|
|
clk_data->clks = kcalloc(number + 1, sizeof(struct clk *), GFP_KERNEL);
|
|
if (!clk_data->clks)
|
|
goto err_free_data;
|
|
|
|
i = 0;
|
|
of_property_for_each_u32(node, "clock-indices", index) {
|
|
of_property_read_string_index(node, "clock-output-names",
|
|
i, &clk_name);
|
|
|
|
if (index == 17 || (index >= 29 && index <= 31))
|
|
clk_parent = AHB2;
|
|
else if (index <= 63 || index >= 128)
|
|
clk_parent = AHB1;
|
|
else if (index >= 64 && index <= 95)
|
|
clk_parent = APB1;
|
|
else if (index >= 96 && index <= 127)
|
|
clk_parent = APB2;
|
|
else {
|
|
WARN_ON(true);
|
|
continue;
|
|
}
|
|
|
|
clk_reg = reg + 4 * (index / 32);
|
|
clk_bit = index % 32;
|
|
|
|
clk_data->clks[index] = clk_register_gate(NULL, clk_name,
|
|
parents[clk_parent],
|
|
0, clk_reg, clk_bit,
|
|
0, &gates_lock);
|
|
i++;
|
|
|
|
if (IS_ERR(clk_data->clks[index])) {
|
|
WARN_ON(true);
|
|
continue;
|
|
}
|
|
}
|
|
|
|
clk_data->clk_num = number + 1;
|
|
of_clk_add_provider(node, of_clk_src_onecell_get, clk_data);
|
|
|
|
return;
|
|
|
|
err_free_data:
|
|
kfree(clk_data);
|
|
err_unmap:
|
|
iounmap(reg);
|
|
of_address_to_resource(node, 0, &res);
|
|
release_mem_region(res.start, resource_size(&res));
|
|
}
|
|
|
|
CLK_OF_DECLARE(sun8i_h3_bus_gates, "allwinner,sun8i-h3-bus-gates-clk",
|
|
sun8i_h3_bus_gates_init);
|
|
CLK_OF_DECLARE(sun8i_a83t_bus_gates, "allwinner,sun8i-a83t-bus-gates-clk",
|
|
sun8i_h3_bus_gates_init);
|