mirror of
https://github.com/torvalds/linux.git
synced 2024-12-30 14:52:05 +00:00
b1b3f49ce4
As suggested by Andrew Morton:
This is a pet peeve of mine. Any time there's a long list of items
(header file inclusions, kconfig entries, array initalisers, etc) and
someone wants to add a new item, they *always* go and stick it at the
end of the list.
Guys, don't do this. Either put the new item into a randomly-chosen
position or, probably better, alphanumerically sort the list.
lets sort all our select statements alphanumerically. This commit was
created by the following perl:
while (<>) {
while (/\\\s*$/) {
$_ .= <>;
}
undef %selects if /^\s*config\s+/;
if (/^\s+select\s+(\w+).*/) {
if (defined($selects{$1})) {
if ($selects{$1} eq $_) {
print STDERR "Warning: removing duplicated $1 entry\n";
} else {
print STDERR "Error: $1 differently selected\n".
"\tOld: $selects{$1}\n".
"\tNew: $_\n";
exit 1;
}
}
$selects{$1} = $_;
next;
}
if (%selects and (/^\s*$/ or /^\s+help/ or /^\s+---help---/ or
/^endif/ or /^endchoice/)) {
foreach $k (sort (keys %selects)) {
print "$selects{$k}";
}
undef %selects;
}
print;
}
if (%selects) {
foreach $k (sort (keys %selects)) {
print "$selects{$k}";
}
}
It found two duplicates:
Warning: removing duplicated S5P_SETUP_MIPIPHY entry
Warning: removing duplicated HARDIRQS_SW_RESEND entry
and they are identical duplicates, hence the shrinkage in the diffstat
of two lines.
We have four testers reporting success of this change (Tony, Stephen,
Linus and Sekhar.)
Acked-by: Jason Cooper <jason@lakedaemon.net>
Acked-by: Tony Lindgren <tony@atomide.com>
Acked-by: Stephen Warren <swarren@nvidia.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Sekhar Nori <nsekhar@ti.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
103 lines
2.0 KiB
Plaintext
103 lines
2.0 KiB
Plaintext
# arch/arm/mach-s5p64x0/Kconfig
|
|
#
|
|
# Copyright (c) 2009-2010 Samsung Electronics Co., Ltd.
|
|
# http://www.samsung.com/
|
|
#
|
|
# Licensed under GPLv2
|
|
|
|
if ARCH_S5P64X0
|
|
|
|
config CPU_S5P6440
|
|
bool
|
|
select S5P_HRT
|
|
select S5P_SLEEP if PM
|
|
select SAMSUNG_DMADEV
|
|
select SAMSUNG_WAKEMASK if PM
|
|
help
|
|
Enable S5P6440 CPU support
|
|
|
|
config CPU_S5P6450
|
|
bool
|
|
select S5P_HRT
|
|
select S5P_SLEEP if PM
|
|
select SAMSUNG_DMADEV
|
|
select SAMSUNG_WAKEMASK if PM
|
|
help
|
|
Enable S5P6450 CPU support
|
|
|
|
config S5P64X0_SETUP_FB_24BPP
|
|
bool
|
|
help
|
|
Common setup code for S5P64X0 based boards with a LCD display
|
|
through RGB interface.
|
|
|
|
config S5P64X0_SETUP_I2C1
|
|
bool
|
|
help
|
|
Common setup code for i2c bus 1.
|
|
|
|
config S5P64X0_SETUP_SPI
|
|
bool
|
|
help
|
|
Common setup code for SPI GPIO configurations
|
|
|
|
config S5P64X0_SETUP_SDHCI_GPIO
|
|
bool
|
|
help
|
|
Common setup code for SDHCI gpio.
|
|
|
|
# machine support
|
|
|
|
config MACH_SMDK6440
|
|
bool "SMDK6440"
|
|
select CPU_S5P6440
|
|
select S3C_DEV_FB
|
|
select S3C_DEV_HSMMC
|
|
select S3C_DEV_HSMMC1
|
|
select S3C_DEV_HSMMC2
|
|
select S3C_DEV_I2C1
|
|
select S3C_DEV_RTC
|
|
select S3C_DEV_WDT
|
|
select S5P64X0_SETUP_FB_24BPP
|
|
select S5P64X0_SETUP_I2C1
|
|
select S5P64X0_SETUP_SDHCI_GPIO
|
|
select SAMSUNG_DEV_ADC
|
|
select SAMSUNG_DEV_BACKLIGHT
|
|
select SAMSUNG_DEV_PWM
|
|
select SAMSUNG_DEV_TS
|
|
help
|
|
Machine support for the Samsung SMDK6440
|
|
|
|
config MACH_SMDK6450
|
|
bool "SMDK6450"
|
|
select CPU_S5P6450
|
|
select S3C_DEV_FB
|
|
select S3C_DEV_HSMMC
|
|
select S3C_DEV_HSMMC1
|
|
select S3C_DEV_HSMMC2
|
|
select S3C_DEV_I2C1
|
|
select S3C_DEV_RTC
|
|
select S3C_DEV_WDT
|
|
select S5P64X0_SETUP_FB_24BPP
|
|
select S5P64X0_SETUP_I2C1
|
|
select S5P64X0_SETUP_SDHCI_GPIO
|
|
select SAMSUNG_DEV_ADC
|
|
select SAMSUNG_DEV_BACKLIGHT
|
|
select SAMSUNG_DEV_PWM
|
|
select SAMSUNG_DEV_TS
|
|
help
|
|
Machine support for the Samsung SMDK6450
|
|
|
|
menu "Use 8-bit SDHCI bus width"
|
|
|
|
config S5P64X0_SD_CH1_8BIT
|
|
bool "SDHCI Channel 1 (Slot 1)"
|
|
depends on MACH_SMDK6450 || MACH_SMDK6440
|
|
help
|
|
Support SDHCI Channel 1 8-bit bus.
|
|
If selected, Channel 2 is disabled.
|
|
|
|
endmenu
|
|
|
|
endif
|