mirror of
https://github.com/torvalds/linux.git
synced 2024-12-02 17:11:33 +00:00
0e862838f2
Currently, there is a mess with the prototypes of the non-atomic bitops across the different architectures: ret bool, int, unsigned long nr int, long, unsigned int, unsigned long addr volatile unsigned long *, volatile void * Thankfully, it doesn't provoke any bugs, but can sometimes make the compiler angry when it's not handy at all. Adjust all the prototypes to the following standard: ret bool retval can be only 0 or 1 nr unsigned long native; signed makes no sense addr volatile unsigned long * bitmaps are arrays of ulongs Next, some architectures don't define 'arch_' versions as they don't support instrumentation, others do. To make sure there is always the same set of callables present and to ease any potential future changes, make them all follow the rule: * architecture-specific files define only 'arch_' versions; * non-prefixed versions can be defined only in asm-generic files; and place the non-prefixed definitions into a new file in asm-generic to be included by non-instrumented architectures. Finally, add some static assertions in order to prevent people from making a mess in this room again. I also used the %__always_inline attribute consistently, so that they always get resolved to the actual operations. Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Alexander Lobakin <alexandr.lobakin@intel.com> Acked-by: Mark Rutland <mark.rutland@arm.com> Reviewed-by: Yury Norov <yury.norov@gmail.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Yury Norov <yury.norov@gmail.com>
20 lines
646 B
C
20 lines
646 B
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
#ifndef _ASM_GENERIC_BITOPS_NON_ATOMIC_H_
|
|
#define _ASM_GENERIC_BITOPS_NON_ATOMIC_H_
|
|
|
|
#include <asm-generic/bitops/generic-non-atomic.h>
|
|
|
|
#define arch___set_bit generic___set_bit
|
|
#define arch___clear_bit generic___clear_bit
|
|
#define arch___change_bit generic___change_bit
|
|
|
|
#define arch___test_and_set_bit generic___test_and_set_bit
|
|
#define arch___test_and_clear_bit generic___test_and_clear_bit
|
|
#define arch___test_and_change_bit generic___test_and_change_bit
|
|
|
|
#define arch_test_bit generic_test_bit
|
|
|
|
#include <asm-generic/bitops/non-instrumented-non-atomic.h>
|
|
|
|
#endif /* _ASM_GENERIC_BITOPS_NON_ATOMIC_H_ */
|