mirror of
https://github.com/torvalds/linux.git
synced 2024-12-25 12:21:37 +00:00
3e737e3943
The kernel provides a __packed definition to abstract away from the compiler specific attributes tag. Convert all packed structures in VSP1 to use it. The GCC documentation [0] describes this attribute as "the structure or union is placed to minimize the memory required". The Keil compiler documentation at [1] warns that the use of this attribute can cause a performance penalty in the event that the compiler can not deduce the allignment of each field. Careful examination of the object code generated both with and without this attribute shows that these structures are accessed identically and are not affected by any performance penalty. The structures are correctly aligned and padded to match the needs of the hardware already. This patch does not serve to make a decision as to the use of the attribute, but purely to clean up the code to use the kernel defined abstraction as per [2]. [0] https://gcc.gnu.org/onlinedocs/gcc/Common-Type-Attributes.html#index-packed-type-attribute [1] http://www.keil.com/support/man/docs/armcc/armcc_chr1359124230195.htm [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/include/linux/compiler-gcc.h?h=v4.16-rc5#n92 Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org> |
||
|---|---|---|
| .. | ||
| Makefile | ||
| vsp1_brx.c | ||
| vsp1_brx.h | ||
| vsp1_clu.c | ||
| vsp1_clu.h | ||
| vsp1_dl.c | ||
| vsp1_dl.h | ||
| vsp1_drm.c | ||
| vsp1_drm.h | ||
| vsp1_drv.c | ||
| vsp1_entity.c | ||
| vsp1_entity.h | ||
| vsp1_hgo.c | ||
| vsp1_hgo.h | ||
| vsp1_hgt.c | ||
| vsp1_hgt.h | ||
| vsp1_histo.c | ||
| vsp1_histo.h | ||
| vsp1_hsit.c | ||
| vsp1_hsit.h | ||
| vsp1_lif.c | ||
| vsp1_lif.h | ||
| vsp1_lut.c | ||
| vsp1_lut.h | ||
| vsp1_pipe.c | ||
| vsp1_pipe.h | ||
| vsp1_regs.h | ||
| vsp1_rpf.c | ||
| vsp1_rwpf.c | ||
| vsp1_rwpf.h | ||
| vsp1_sru.c | ||
| vsp1_sru.h | ||
| vsp1_uds.c | ||
| vsp1_uds.h | ||
| vsp1_uif.c | ||
| vsp1_uif.h | ||
| vsp1_video.c | ||
| vsp1_video.h | ||
| vsp1_wpf.c | ||
| vsp1.h | ||