mirror of
https://github.com/torvalds/linux.git
synced 2024-12-01 08:31:37 +00:00
5c9c5d7f26
In gb_interface_create, &intf->mode_switch_completion is bound with
gb_interface_mode_switch_work. Then it will be started by
gb_interface_request_mode_switch. Here is the relevant code.
if (!queue_work(system_long_wq, &intf->mode_switch_work)) {
...
}
If we call gb_interface_release to make cleanup, there may be an
unfinished work. This function will call kfree to free the object
"intf". However, if gb_interface_mode_switch_work is scheduled to
run after kfree, it may cause use-after-free error as
gb_interface_mode_switch_work will use the object "intf".
The possible execution flow that may lead to the issue is as follows:
CPU0 CPU1
| gb_interface_create
| gb_interface_request_mode_switch
gb_interface_release |
kfree(intf) (free) |
| gb_interface_mode_switch_work
| mutex_lock(&intf->mutex) (use)
Fix it by canceling the work before kfree.
Signed-off-by: Sicong Huang <congei42@163.com>
Link: https://lore.kernel.org/r/20240416080313.92306-1-congei42@163.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
|
||
|---|---|---|
| .. | ||
| arpc.h | ||
| bundle.c | ||
| connection.c | ||
| control.c | ||
| core.c | ||
| debugfs.c | ||
| es2.c | ||
| gb-beagleplay.c | ||
| greybus_trace.h | ||
| hd.c | ||
| interface.c | ||
| Kconfig | ||
| Makefile | ||
| manifest.c | ||
| module.c | ||
| operation.c | ||
| svc_watchdog.c | ||
| svc.c | ||