mirror of
https://github.com/torvalds/linux.git
synced 2024-12-30 14:52:05 +00:00
3d564047a5
This patch starts the removal of a very old, very broken piece of code. This stems from the problem of passing a userspace buffer into read() or write() on the host. If that buffer had not yet been faulted in, read and write will return -EFAULT. To avoid this problem, the solution was to fault the buffer in before the system call by touching the pages that hold the buffer by doing a copy-user of a byte to each page. This is obviously bogus, but it does usually work, in tt mode, since the kernel and process are in the same address space and userspace addresses can be accessed directly in the kernel. In skas mode, where the kernel and process are in separate address spaces, it is completely bogus because the userspace address, which is invalid in the kernel, is passed into the system call instead of the corresponding physical address, which would be valid. Here, it appears that this code, on every host read() or write(), tries to fault in a random process page. This doesn't seem to cause any correctness problems, but there is a performance impact. This patch, and the ones following, result in a 10-15% performance gain on a kernel build. This code can't be immediately tossed out because when it is, you can't log in. Apparently, there is some code in the console driver which depends on this somehow. However, we can start removing it by switching the code which does I/O using kernel addresses to using plain read() and write(). This patch introduces os_read_file_k and os_write_file_k for use with kernel buffers and converts all call locations which use obvious kernel buffers to use them. These include I/O using buffers which are local variables which are on the stack or kmalloc-ed. Later patches will handle the less obvious cases, followed by a mass conversion back to the original interface. Signed-off-by: Jeff Dike <jdike@linux.intel.com> Cc: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
131 lines
2.5 KiB
C
131 lines
2.5 KiB
C
/*
|
|
* Copyright (C) 2002 Jeff Dike (jdike@karaya.com)
|
|
* Licensed under the GPL
|
|
*/
|
|
|
|
#include <stdio.h>
|
|
#include <unistd.h>
|
|
#include <errno.h>
|
|
#include "user.h"
|
|
#include "mconsole.h"
|
|
#include "os.h"
|
|
#include "choose-mode.h"
|
|
#include "mode.h"
|
|
|
|
struct dog_data {
|
|
int stdin;
|
|
int stdout;
|
|
int close_me[2];
|
|
};
|
|
|
|
static void pre_exec(void *d)
|
|
{
|
|
struct dog_data *data = d;
|
|
|
|
dup2(data->stdin, 0);
|
|
dup2(data->stdout, 1);
|
|
dup2(data->stdout, 2);
|
|
os_close_file(data->stdin);
|
|
os_close_file(data->stdout);
|
|
os_close_file(data->close_me[0]);
|
|
os_close_file(data->close_me[1]);
|
|
}
|
|
|
|
int start_watchdog(int *in_fd_ret, int *out_fd_ret, char *sock)
|
|
{
|
|
struct dog_data data;
|
|
int in_fds[2], out_fds[2], pid, n, err;
|
|
char pid_buf[sizeof("nnnnn\0")], c;
|
|
char *pid_args[] = { "/usr/bin/uml_watchdog", "-pid", pid_buf, NULL };
|
|
char *mconsole_args[] = { "/usr/bin/uml_watchdog", "-mconsole", NULL,
|
|
NULL };
|
|
char **args = NULL;
|
|
|
|
err = os_pipe(in_fds, 1, 0);
|
|
if(err < 0){
|
|
printk("harddog_open - os_pipe failed, err = %d\n", -err);
|
|
goto out;
|
|
}
|
|
|
|
err = os_pipe(out_fds, 1, 0);
|
|
if(err < 0){
|
|
printk("harddog_open - os_pipe failed, err = %d\n", -err);
|
|
goto out_close_in;
|
|
}
|
|
|
|
data.stdin = out_fds[0];
|
|
data.stdout = in_fds[1];
|
|
data.close_me[0] = out_fds[1];
|
|
data.close_me[1] = in_fds[0];
|
|
|
|
if(sock != NULL){
|
|
mconsole_args[2] = sock;
|
|
args = mconsole_args;
|
|
}
|
|
else {
|
|
/* XXX The os_getpid() is not SMP correct */
|
|
sprintf(pid_buf, "%d", CHOOSE_MODE(tracing_pid, os_getpid()));
|
|
args = pid_args;
|
|
}
|
|
|
|
pid = run_helper(pre_exec, &data, args, NULL);
|
|
|
|
os_close_file(out_fds[0]);
|
|
os_close_file(in_fds[1]);
|
|
|
|
if(pid < 0){
|
|
err = -pid;
|
|
printk("harddog_open - run_helper failed, errno = %d\n", -err);
|
|
goto out_close_out;
|
|
}
|
|
|
|
n = os_read_file_k(in_fds[0], &c, sizeof(c));
|
|
if(n == 0){
|
|
printk("harddog_open - EOF on watchdog pipe\n");
|
|
helper_wait(pid);
|
|
err = -EIO;
|
|
goto out_close_out;
|
|
}
|
|
else if(n < 0){
|
|
printk("harddog_open - read of watchdog pipe failed, "
|
|
"err = %d\n", -n);
|
|
helper_wait(pid);
|
|
err = n;
|
|
goto out_close_out;
|
|
}
|
|
*in_fd_ret = in_fds[0];
|
|
*out_fd_ret = out_fds[1];
|
|
return 0;
|
|
|
|
out_close_in:
|
|
os_close_file(in_fds[0]);
|
|
os_close_file(in_fds[1]);
|
|
out_close_out:
|
|
os_close_file(out_fds[0]);
|
|
os_close_file(out_fds[1]);
|
|
out:
|
|
return err;
|
|
}
|
|
|
|
void stop_watchdog(int in_fd, int out_fd)
|
|
{
|
|
os_close_file(in_fd);
|
|
os_close_file(out_fd);
|
|
}
|
|
|
|
int ping_watchdog(int fd)
|
|
{
|
|
int n;
|
|
char c = '\n';
|
|
|
|
n = os_write_file_k(fd, &c, sizeof(c));
|
|
if(n != sizeof(c)){
|
|
printk("ping_watchdog - write failed, err = %d\n", -n);
|
|
if(n < 0)
|
|
return n;
|
|
return -EIO;
|
|
}
|
|
return 1;
|
|
|
|
}
|