mirror of
https://github.com/torvalds/linux.git
synced 2024-12-21 10:31:54 +00:00
25d4affb0c
Coverity complains about werid stuff at the debug logic: CID 113542 (#1 of 1): Out-of-bounds access (ARRAY_VS_SINGLETON)10. callee_ptr_arith: Passing buf to function flexcop_i2c_write4 which uses it as an array. This might corrupt or misinterpret adjacent memory locations. Instead of directly addressing the issue there, let's rework at the logic there. On newer kernels, KERN_CONT does nothing, as the previous message won't wait for a continuation. Also, both flexcop_i2c_read4() and flexcop_i2c_write4(), called by it, will print stuff if (debug &4). So, the way it is is too buggy. There are two kinds of debug stuff there: deb_i2c() and a code hidden under #ifdef DUMP_I2C_MESSAGES, with can't be selected without touching the source code. Also, if both debug & 0x4 and DUMP_I2C_MESSAGES, flexcop_i2c_request() will emit two debug messages per call with different data, with sounds messy. Simplify it by getting rid of DUMP_I2C_MESSAGES and adding a new flag to debug (0x40), and making the debug logic there more consistent. Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com> Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
32 lines
902 B
C
32 lines
902 B
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* Linux driver for digital TV devices equipped with B2C2 FlexcopII(b)/III
|
|
* flexcop.h - private header file for all flexcop-chip-source files
|
|
* see flexcop.c for copyright information
|
|
*/
|
|
#ifndef __FLEXCOP_H__
|
|
#define __FLEXCOP_H__
|
|
|
|
#define FC_LOG_PREFIX "b2c2-flexcop"
|
|
#include "flexcop-common.h"
|
|
|
|
extern int b2c2_flexcop_debug;
|
|
|
|
/* debug */
|
|
#ifdef CONFIG_DVB_B2C2_FLEXCOP_DEBUG
|
|
#define dprintk(level,args...) \
|
|
do { if ((b2c2_flexcop_debug & level)) printk(args); } while (0)
|
|
#else
|
|
#define dprintk(level,args...)
|
|
#endif
|
|
|
|
#define deb_info(args...) dprintk(0x01, args)
|
|
#define deb_tuner(args...) dprintk(0x02, args)
|
|
#define deb_i2c(args...) dprintk(0x04, args)
|
|
#define deb_ts(args...) dprintk(0x08, args)
|
|
#define deb_sram(args...) dprintk(0x10, args)
|
|
#define deb_rdump(args...) dprintk(0x20, args)
|
|
#define deb_i2c_dump(args...) dprintk(0x40, args)
|
|
|
|
#endif
|