David Howells 3d1d4aa0cc cachefiles: Fix signed/unsigned mixup ... In __cachefiles_prepare_write(), the start and pos variables were made unsigned 64-bit so that the casts in the checking could be got rid of - which should be fine since absolute file offsets can't be negative, except that an error code may be obtained from vfs_llseek(), which *would* be negative. This breaks the error check. Fix this for now by reverting pos and start to be signed and putting back the casts. Unfortunately, the error value checks cannot be replaced with IS_ERR_VALUE() as long might be 32-bits. Fixes: 7097c96411 ("cachefiles: Fix __cachefiles_prepare_write()") Reported-by: Simon Horman <horms@kernel.org> Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202401071152.DbKqMQMu-lkp@intel.com/ Signed-off-by: David Howells <dhowells@redhat.com> Reviewed-by: Simon Horman <horms@kernel.org> Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com> cc: Yiqun Leng <yqleng@linux.alibaba.com> cc: Jia Zhu <zhujia.zj@bytedance.com> cc: Jeff Layton <jlayton@kernel.org> cc: linux-cachefs@redhat.com cc: linux-erofs@lists.ozlabs.org cc: linux-fsdevel@vger.kernel.org cc: linux-mm@kvack.org		2024-01-09 13:32:44 +00:00
..
cache.c	cachefiles: Check that the backing filesystem supports tmpfiles	2022-01-21 21:36:28 +00:00
daemon.c	cachefiles: enable on-demand read mode	2022-05-18 00:11:18 +08:00
error_inject.c	fs/cachefiles: simplify one-level sysctl registration for cachefiles_sysctls	2023-04-13 11:49:35 -07:00
interface.c	fs: port vfs_*() helpers to struct mnt_idmap	2023-01-18 17:51:45 +01:00
internal.h	netfs, cachefiles: Pass upper bound length to allow expansion	2023-12-28 09:45:25 +00:00
io.c	cachefiles: Fix signed/unsigned mixup	2024-01-09 13:32:44 +00:00
Kconfig	netfs, fscache: Combine fscache with netfs	2023-12-24 15:08:46 +00:00
key.c	cachefiles: Implement key to filename encoding	2022-01-07 13:42:16 +00:00
main.c	cachefiles: Implement object lifecycle funcs	2022-01-07 13:42:08 +00:00
Makefile	cachefiles: notify the user daemon when looking up cookie	2022-05-18 00:11:17 +08:00
namei.c	mm, netfs, fscache: stop read optimisation when folio removed from pagecache	2023-08-18 10:12:13 -07:00
ondemand.c	netfs, cachefiles: Pass upper bound length to allow expansion	2023-12-28 09:45:25 +00:00
security.c	cachefiles: Add security derivation	2022-01-07 13:41:14 +00:00
volume.c	fscache, cachefiles: Store the volume coherency data	2022-01-07 13:43:03 +00:00
xattr.c	fs: port ->permission() to pass mnt_idmap	2023-01-19 09:24:28 +01:00