Yang Shi 37f0b47c51 mm: khugepaged: fix the arguments order in khugepaged_collapse_file trace point ... The "addr" and "is_shmem" arguments have different order in TP_PROTO and TP_ARGS. This resulted in the incorrect trace result: text-hugepage-644429 [276] 392092.878683: mm_khugepaged_collapse_file: mm=0xffff20025d52c440, hpage_pfn=0x200678c00, index=512, addr=1, is_shmem=0, filename=text-hugepage, nr=512, result=failed The value of "addr" is wrong because it was treated as bool value, the type of is_shmem. Fix the order in TP_PROTO to keep "addr" is before "is_shmem" since the original patch review suggested this order to achieve best packing. And use "lx" for "addr" instead of "ld" in TP_printk because address is typically shown in hex. After the fix, the trace result looks correct: text-hugepage-7291 [004] 128.627251: mm_khugepaged_collapse_file: mm=0xffff0001328f9500, hpage_pfn=0x20016ea00, index=512, addr=0x400000, is_shmem=0, filename=text-hugepage, nr=512, result=failed Link: https://lkml.kernel.org/r/20241012011702.1084846-1-yang@os.amperecomputing.com Fixes: 4c9473e87e ("mm/khugepaged: add tracepoint to collapse_file()") Signed-off-by: Yang Shi <yang@os.amperecomputing.com> Cc: Gautam Menghani <gautammenghani201@gmail.com> Cc: Steven Rostedt (Google) <rostedt@goodmis.org> Cc: <stable@vger.kernel.org> [6.2+] Signed-off-by: Andrew Morton <akpm@linux-foundation.org>		2024-10-17 00:28:09 -07:00
..
events	mm: khugepaged: fix the arguments order in khugepaged_collapse_file trace point	2024-10-17 00:28:09 -07:00
misc	NFS: trace: show TIMEDOUT instead of 0x6e	2024-09-01 10:04:55 -04:00
stages	tracing/treewide: Remove second parameter of __assign_str()	2024-05-22 20:14:47 -04:00
bpf_probe.h	bpf: pass whole link instead of prog when triggering raw tracepoint	2024-03-19 23:05:33 -07:00
define_custom_trace.h
define_trace.h
perf.h	perf/tracing: Use stage6 of tracing to not duplicate macros	2023-01-25 10:31:24 -05:00
syscall.h
trace_custom_events.h
trace_events.h