mirror of
https://github.com/torvalds/linux.git
synced 2024-12-26 21:02:19 +00:00
9abffc6f2e
mcryptd_enqueue_request() grabs the per-CPU queue struct and protects access to it with disabled preemption. Then it schedules a worker on the same CPU. The worker in mcryptd_queue_worker() guards access to the same per-CPU variable with disabled preemption. If we take CPU-hotplug into account then it is possible that between queue_work_on() and the actual invocation of the worker the CPU goes down and the worker will be scheduled on _another_ CPU. And here the preempt_disable() protection does not work anymore. The easiest thing is to add a spin_lock() to guard access to the list. Another detail: mcryptd_queue_worker() is not processing more than MCRYPTD_BATCH invocation in a row. If there are still items left, then it will invoke queue_work() to proceed with more later. *I* would suggest to simply drop that check because it does not use a system workqueue and the workqueue is already marked as "CPU_INTENSIVE". And if preemption is required then the scheduler should do it. However if queue_work() is used then the work item is marked as CPU unbound. That means it will try to run on the local CPU but it may run on another CPU as well. Especially with CONFIG_DEBUG_WQ_FORCE_RR_CPU=y. Again, the preempt_disable() won't work here but lock which was introduced will help. In order to keep work-item on the local CPU (and avoid RR) I changed it to queue_work_on(). Cc: stable@vger.kernel.org Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
115 lines
2.4 KiB
C
115 lines
2.4 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* Software async multibuffer crypto daemon headers
|
|
*
|
|
* Author:
|
|
* Tim Chen <tim.c.chen@linux.intel.com>
|
|
*
|
|
* Copyright (c) 2014, Intel Corporation.
|
|
*/
|
|
|
|
#ifndef _CRYPTO_MCRYPT_H
|
|
#define _CRYPTO_MCRYPT_H
|
|
|
|
#include <linux/crypto.h>
|
|
#include <linux/kernel.h>
|
|
#include <crypto/hash.h>
|
|
|
|
struct mcryptd_ahash {
|
|
struct crypto_ahash base;
|
|
};
|
|
|
|
static inline struct mcryptd_ahash *__mcryptd_ahash_cast(
|
|
struct crypto_ahash *tfm)
|
|
{
|
|
return (struct mcryptd_ahash *)tfm;
|
|
}
|
|
|
|
struct mcryptd_cpu_queue {
|
|
struct crypto_queue queue;
|
|
spinlock_t q_lock;
|
|
struct work_struct work;
|
|
};
|
|
|
|
struct mcryptd_queue {
|
|
struct mcryptd_cpu_queue __percpu *cpu_queue;
|
|
};
|
|
|
|
struct mcryptd_instance_ctx {
|
|
struct crypto_spawn spawn;
|
|
struct mcryptd_queue *queue;
|
|
};
|
|
|
|
struct mcryptd_hash_ctx {
|
|
struct crypto_ahash *child;
|
|
struct mcryptd_alg_state *alg_state;
|
|
};
|
|
|
|
struct mcryptd_tag {
|
|
/* seq number of request */
|
|
unsigned seq_num;
|
|
/* arrival time of request */
|
|
unsigned long arrival;
|
|
unsigned long expire;
|
|
int cpu;
|
|
};
|
|
|
|
struct mcryptd_hash_request_ctx {
|
|
struct list_head waiter;
|
|
crypto_completion_t complete;
|
|
struct mcryptd_tag tag;
|
|
struct crypto_hash_walk walk;
|
|
u8 *out;
|
|
int flag;
|
|
struct ahash_request areq;
|
|
};
|
|
|
|
struct mcryptd_ahash *mcryptd_alloc_ahash(const char *alg_name,
|
|
u32 type, u32 mask);
|
|
struct crypto_ahash *mcryptd_ahash_child(struct mcryptd_ahash *tfm);
|
|
struct ahash_request *mcryptd_ahash_desc(struct ahash_request *req);
|
|
void mcryptd_free_ahash(struct mcryptd_ahash *tfm);
|
|
void mcryptd_flusher(struct work_struct *work);
|
|
|
|
enum mcryptd_req_type {
|
|
MCRYPTD_NONE,
|
|
MCRYPTD_UPDATE,
|
|
MCRYPTD_FINUP,
|
|
MCRYPTD_DIGEST,
|
|
MCRYPTD_FINAL
|
|
};
|
|
|
|
struct mcryptd_alg_cstate {
|
|
unsigned long next_flush;
|
|
unsigned next_seq_num;
|
|
bool flusher_engaged;
|
|
struct delayed_work flush;
|
|
int cpu;
|
|
struct mcryptd_alg_state *alg_state;
|
|
void *mgr;
|
|
spinlock_t work_lock;
|
|
struct list_head work_list;
|
|
struct list_head flush_list;
|
|
};
|
|
|
|
struct mcryptd_alg_state {
|
|
struct mcryptd_alg_cstate __percpu *alg_cstate;
|
|
unsigned long (*flusher)(struct mcryptd_alg_cstate *cstate);
|
|
};
|
|
|
|
/* return delay in jiffies from current time */
|
|
static inline unsigned long get_delay(unsigned long t)
|
|
{
|
|
long delay;
|
|
|
|
delay = (long) t - (long) jiffies;
|
|
if (delay <= 0)
|
|
return 0;
|
|
else
|
|
return (unsigned long) delay;
|
|
}
|
|
|
|
void mcryptd_arm_flusher(struct mcryptd_alg_cstate *cstate, unsigned long delay);
|
|
|
|
#endif
|