mirror of
https://github.com/torvalds/linux.git
synced 2024-12-26 12:52:30 +00:00
2b97e2201e
KERNEL_VERSION: 2.6.37
common.c in function ssize_t si470x_fops_read.
1. First mutex_lock on &radio->lock in line 441
2. Second in line 462
I think that mutex in line 462 is not needed.
433static ssize_t si470x_fops_read(struct file *file, char __user *buf,
434 size_t count, loff_t *ppos)
435{
....
441 mutex_lock(&radio->lock);
442 if ((radio->registers[SYSCONFIG1] & SYSCONFIG1_RDS) == 0)
443 si470x_rds_on(radio);
444
445 /* block if no new data available */
446 while (radio->wr_index == radio->rd_index) {
447 if (file->f_flags & O_NONBLOCK) {
448 retval = -EWOULDBLOCK;
449 goto done;
450 }
451 if (wait_event_interruptible(radio->read_queue,
452 radio->wr_index != radio->rd_index) < 0) {
453 retval = -EINTR;
454 goto done;
455 }
456 }
457
458 /* calculate block count from byte count */
459 count /= 3;
460
461 /* copy RDS block out of internal buffer and to user buffer */
462 mutex_lock(&radio->lock);
Found by Linux Device Drivers Verification Project
Remove second mutex.
Signed-off-by: Alexander Strakh <strakh@ispras.ru>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
|
||
|---|---|---|
| .. | ||
| si470x | ||
| dsbr100.c | ||
| Kconfig | ||
| Makefile | ||
| radio-aimslab.c | ||
| radio-aztech.c | ||
| radio-cadet.c | ||
| radio-gemtek.c | ||
| radio-maestro.c | ||
| radio-maxiradio.c | ||
| radio-miropcm20.c | ||
| radio-mr800.c | ||
| radio-rtrack2.c | ||
| radio-sf16fmi.c | ||
| radio-sf16fmr2.c | ||
| radio-si4713.c | ||
| radio-tea5764.c | ||
| radio-terratec.c | ||
| radio-timb.c | ||
| radio-trust.c | ||
| radio-typhoon.c | ||
| radio-wl1273.c | ||
| radio-zoltrix.c | ||
| saa7706h.c | ||
| si4713-i2c.c | ||
| si4713-i2c.h | ||
| tef6862.c | ||