mirror of
https://github.com/torvalds/linux.git
synced 2024-11-27 06:31:52 +00:00
453431a549
As said by Linus: A symmetric naming is only helpful if it implies symmetries in use. Otherwise it's actively misleading. In "kzalloc()", the z is meaningful and an important part of what the caller wants. In "kzfree()", the z is actively detrimental, because maybe in the future we really _might_ want to use that "memfill(0xdeadbeef)" or something. The "zero" part of the interface isn't even _relevant_. The main reason that kzfree() exists is to clear sensitive information that should not be leaked to other future users of the same memory objects. Rename kzfree() to kfree_sensitive() to follow the example of the recently added kvfree_sensitive() and make the intention of the API more explicit. In addition, memzero_explicit() is used to clear the memory to make sure that it won't get optimized away by the compiler. The renaming is done by using the command sequence: git grep -w --name-only kzfree |\ xargs sed -i 's/kzfree/kfree_sensitive/' followed by some editing of the kfree_sensitive() kerneldoc and adding a kzfree backward compatibility macro in slab.h. [akpm@linux-foundation.org: fs/crypto/inline_crypt.c needs linux/slab.h] [akpm@linux-foundation.org: fix fs/crypto/inline_crypt.c some more] Suggested-by: Joe Perches <joe@perches.com> Signed-off-by: Waiman Long <longman@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Acked-by: David Howells <dhowells@redhat.com> Acked-by: Michal Hocko <mhocko@suse.com> Acked-by: Johannes Weiner <hannes@cmpxchg.org> Cc: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> Cc: James Morris <jmorris@namei.org> Cc: "Serge E. Hallyn" <serge@hallyn.com> Cc: Joe Perches <joe@perches.com> Cc: Matthew Wilcox <willy@infradead.org> Cc: David Rientjes <rientjes@google.com> Cc: Dan Carpenter <dan.carpenter@oracle.com> Cc: "Jason A . Donenfeld" <Jason@zx2c4.com> Link: http://lkml.kernel.org/r/20200616154311.12314-3-longman@redhat.com Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
127 lines
2.7 KiB
C
127 lines
2.7 KiB
C
/* mpiutil.ac - Utility functions for MPI
|
|
* Copyright (C) 1998, 1999 Free Software Foundation, Inc.
|
|
*
|
|
* This file is part of GnuPG.
|
|
*
|
|
* GnuPG is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* GnuPG is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA
|
|
*/
|
|
|
|
#include "mpi-internal.h"
|
|
|
|
/****************
|
|
* Note: It was a bad idea to use the number of limbs to allocate
|
|
* because on a alpha the limbs are large but we normally need
|
|
* integers of n bits - So we should chnage this to bits (or bytes).
|
|
*
|
|
* But mpi_alloc is used in a lot of places :-)
|
|
*/
|
|
MPI mpi_alloc(unsigned nlimbs)
|
|
{
|
|
MPI a;
|
|
|
|
a = kmalloc(sizeof *a, GFP_KERNEL);
|
|
if (!a)
|
|
return a;
|
|
|
|
if (nlimbs) {
|
|
a->d = mpi_alloc_limb_space(nlimbs);
|
|
if (!a->d) {
|
|
kfree(a);
|
|
return NULL;
|
|
}
|
|
} else {
|
|
a->d = NULL;
|
|
}
|
|
|
|
a->alloced = nlimbs;
|
|
a->nlimbs = 0;
|
|
a->sign = 0;
|
|
a->flags = 0;
|
|
a->nbits = 0;
|
|
return a;
|
|
}
|
|
EXPORT_SYMBOL_GPL(mpi_alloc);
|
|
|
|
mpi_ptr_t mpi_alloc_limb_space(unsigned nlimbs)
|
|
{
|
|
size_t len = nlimbs * sizeof(mpi_limb_t);
|
|
|
|
if (!len)
|
|
return NULL;
|
|
|
|
return kmalloc(len, GFP_KERNEL);
|
|
}
|
|
|
|
void mpi_free_limb_space(mpi_ptr_t a)
|
|
{
|
|
if (!a)
|
|
return;
|
|
|
|
kfree_sensitive(a);
|
|
}
|
|
|
|
void mpi_assign_limb_space(MPI a, mpi_ptr_t ap, unsigned nlimbs)
|
|
{
|
|
mpi_free_limb_space(a->d);
|
|
a->d = ap;
|
|
a->alloced = nlimbs;
|
|
}
|
|
|
|
/****************
|
|
* Resize the array of A to NLIMBS. the additional space is cleared
|
|
* (set to 0) [done by m_realloc()]
|
|
*/
|
|
int mpi_resize(MPI a, unsigned nlimbs)
|
|
{
|
|
void *p;
|
|
|
|
if (nlimbs <= a->alloced)
|
|
return 0; /* no need to do it */
|
|
|
|
if (a->d) {
|
|
p = kmalloc_array(nlimbs, sizeof(mpi_limb_t), GFP_KERNEL);
|
|
if (!p)
|
|
return -ENOMEM;
|
|
memcpy(p, a->d, a->alloced * sizeof(mpi_limb_t));
|
|
kfree_sensitive(a->d);
|
|
a->d = p;
|
|
} else {
|
|
a->d = kcalloc(nlimbs, sizeof(mpi_limb_t), GFP_KERNEL);
|
|
if (!a->d)
|
|
return -ENOMEM;
|
|
}
|
|
a->alloced = nlimbs;
|
|
return 0;
|
|
}
|
|
|
|
void mpi_free(MPI a)
|
|
{
|
|
if (!a)
|
|
return;
|
|
|
|
if (a->flags & 4)
|
|
kfree_sensitive(a->d);
|
|
else
|
|
mpi_free_limb_space(a->d);
|
|
|
|
if (a->flags & ~7)
|
|
pr_info("invalid flag value in mpi\n");
|
|
kfree(a);
|
|
}
|
|
EXPORT_SYMBOL_GPL(mpi_free);
|
|
|
|
MODULE_DESCRIPTION("Multiprecision maths library");
|
|
MODULE_LICENSE("GPL");
|