mirror of
https://github.com/torvalds/linux.git
synced 2024-11-25 13:41:51 +00:00
46b6fc5380
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. The function mtu3_remove() can only return a non-zero value if ssusb->dr_mode is neiter USB_DR_MODE_PERIPHERAL nor USB_DR_MODE_HOST nor USB_DR_MODE_OTG. In this case however the probe callback doesn't succeed and so the remove callback isn't called at all. So the code branch resulting in this error path could just be dropped were it not for the compiler choking on "enumeration value 'USB_DR_MODE_UNKNOWN' not handled in switch [-Werror=switch]". So instead replace this code path by a WARN_ON and then mtu3_remove() be converted to return void trivially. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20231020151537.2202675-2-u.kleine-koenig@pengutronix.de Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> |
||
|---|---|---|
| .. | ||
| Kconfig | ||
| Makefile | ||
| mtu3_core.c | ||
| mtu3_debug.h | ||
| mtu3_debugfs.c | ||
| mtu3_dr.c | ||
| mtu3_dr.h | ||
| mtu3_gadget_ep0.c | ||
| mtu3_gadget.c | ||
| mtu3_host.c | ||
| mtu3_hw_regs.h | ||
| mtu3_plat.c | ||
| mtu3_qmu.c | ||
| mtu3_qmu.h | ||
| mtu3_trace.c | ||
| mtu3_trace.h | ||
| mtu3.h | ||