Filipe Manana 3131400230 Btrfs: fix page reading in extent_same ioctl leading to csum errors ... In the extent_same ioctl, we were grabbing the pages (locked) and attempting to read them without bothering about any concurrent IO against them. That is, we were not checking for any ongoing ordered extents nor waiting for them to complete, which leads to a race where the extent_same() code gets a checksum verification error when it reads the pages, producing a message like the following in dmesg and making the operation fail to user space with -ENOMEM: [18990.161265] BTRFS warning (device sdc): csum failed ino 259 off 495616 csum 685204116 expected csum 1515870868 Fix this by using btrfs_readpage() for reading the pages instead of extent_read_full_page_nolock(), which waits for any concurrent ordered extents to complete and locks the io range. Also do better error handling and don't treat all failures as -ENOMEM, as that's clearly misleasing, becoming identical to the checks and operation of prepare_uptodate_page(). The use of extent_read_full_page_nolock() was required before commit f441460202 ("btrfs: fix deadlock with extent-same and readpage"), as we had the range locked in an inode's io tree before attempting to read the pages. Fixes: f441460202 ("btrfs: fix deadlock with extent-same and readpage") Cc: stable@vger.kernel.org # 4.2+ Signed-off-by: Filipe Manana <fdmanana@suse.com>		2016-02-03 19:27:10 +00:00
..
tests	btrfs: tests: switch to GFP_KERNEL	2016-01-22 10:28:24 +01:00
acl.c	btrfs: use GFP_KERNEL for xattr and acl allocations	2015-12-03 15:03:44 +01:00
async-thread.c	btrfs: async-thread: Fix a use-after-free error for trace	2016-01-25 16:50:26 -08:00
async-thread.h	btrfs: async_thread: Fix workqueue 'max_active' value when initializing	2015-08-31 11:46:40 -07:00
backref.c	btrfs: fix iterator with update error in backref.c	2016-01-15 19:27:18 +01:00
backref.h	btrfs: cleanup, remove inode_item_info helper	2015-01-14 19:23:47 +01:00
btrfs_inode.h	btrfs: put delayed item hook into inode	2016-01-07 14:26:58 +01:00
check-integrity.c	btrfs: use list_for_each_entry* in check-integrity.c	2016-01-07 14:38:42 +01:00
check-integrity.h
compression.c	Merge branch 'akpm' (patches from Andrew)	2015-11-07 14:32:45 -08:00
compression.h	btrfs: constify structs with op functions or static definitions	2015-02-16 18:48:44 +01:00
ctree.c	Merge branch 'misc-cleanups-4.5' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus-4.5	2016-01-11 06:08:37 -08:00
ctree.h	btrfs: merge functions for wait snapshot creation	2016-01-20 07:22:13 -08:00
delayed-inode.c	btrfs: zero out delayed node upon allocation	2016-01-07 14:30:17 +01:00
delayed-inode.h
delayed-ref.c	btrfs: better packing of btrfs_delayed_extent_op	2016-01-07 14:26:58 +01:00
delayed-ref.h	btrfs: better packing of btrfs_delayed_extent_op	2016-01-07 14:26:58 +01:00
dev-replace.c	btrfs: cleanup, stop casting for extent_map->lookup everywhere	2016-01-15 19:22:28 +01:00
dev-replace.h
dir-item.c	Btrfs: make xattr replace operations atomic	2014-11-20 17:20:07 -08:00
disk-io.c	Merge branch 'dev/fst-followup' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus-4.5	2016-01-27 05:48:23 -08:00
disk-io.h	Merge branch 'misc-cleanups-4.5' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus-4.5	2016-01-11 06:08:37 -08:00
export.c	BTRFS: support NFSv2 export	2015-10-06 06:55:23 -07:00
export.h
extent_io.c	Merge branch 'misc-cleanups-4.5' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus-4.5	2016-01-11 06:08:37 -08:00
extent_io.h	Merge branch 'freespace-4.5' into for-linus-4.5	2015-12-23 13:29:09 -08:00
extent_map.c	btrfs: cleanup, stop casting for extent_map->lookup everywhere	2016-01-15 19:22:28 +01:00
extent_map.h	btrfs: cleanup, stop casting for extent_map->lookup everywhere	2016-01-15 19:22:28 +01:00
extent-tree.c	btrfs: Fix no_space in write and rm loop	2016-01-20 07:22:14 -08:00
file-item.c	btrfs: cleanup, use enum values for btrfs_path reada	2016-01-07 15:01:15 +01:00
file.c	btrfs: delete unused argument in btrfs_copy_from_user	2016-01-20 07:22:13 -08:00
free-space-cache.c	Merge branch 'misc-cleanups-4.5' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus-4.5	2016-01-11 06:08:37 -08:00
free-space-cache.h	btrfs: constify remaining structs with function pointers	2016-01-07 15:01:14 +01:00
free-space-tree.c	Revert "btrfs: synchronize incompat feature bits with sysfs files"	2016-01-29 08:19:37 -08:00
free-space-tree.h	Btrfs: implement the free space B-tree	2015-12-17 12:16:47 -08:00
hash.c	btrfs: LLVMLinux: Remove VLAIS	2014-10-14 10:51:22 +02:00
hash.h
inode-item.c	Btrfs: consolidate btrfs_error() to btrfs_std_error()	2015-09-29 16:30:00 +02:00
inode-map.c	Merge branch 'misc-for-4.5' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus-4.5	2016-01-19 18:21:30 -08:00
inode-map.h	Btrfs: Initialize btrfs_root->highest_objectid when loading tree root and subvolume roots	2016-01-15 19:25:02 +01:00
inode.c	Btrfs: fix race between fsync and lockless direct IO writes	2016-01-25 16:50:26 -08:00
ioctl.c	Btrfs: fix page reading in extent_same ioctl leading to csum errors	2016-02-03 19:27:10 +00:00
Kconfig	rcu: Make SRCU optional by using CONFIG_SRCU	2015-01-06 11:04:29 -08:00
locking.c	btrfs: cleanup, remove stray return statements	2016-01-07 14:30:52 +01:00
locking.h	btrfs: fix lockups from btrfs_clear_path_blocking	2014-11-19 10:34:35 -08:00
lzo.c	btrfs: constify structs with op functions or static definitions	2015-02-16 18:48:44 +01:00
Makefile	Btrfs: add free space tree sanity tests	2015-12-17 12:16:47 -08:00
math.h	btrfs: cleanup 64bit/32bit divs, compile time constants	2015-03-03 17:23:57 +01:00
ordered-data.c	Btrfs: change how we wait for pending ordered extents	2015-10-21 18:51:40 -07:00
ordered-data.h	Btrfs: change how we wait for pending ordered extents	2015-10-21 18:51:40 -07:00
orphan.c	btrfs: kill the key type accessor helpers	2014-09-17 13:37:12 -07:00
print-tree.c	btrfs: remove parameter blocksize from read_tree_block	2014-10-02 17:14:50 +02:00
print-tree.h
props.c	btrfs: cleanup iterating over prop_handlers array	2015-10-21 18:28:48 +02:00
props.h
qgroup.c	btrfs: qgroup: account shared subtree during snapshot delete	2015-11-25 05:27:33 -08:00
qgroup.h	btrfs: qgroup: Check if qgroup reserved space leaked	2015-10-21 18:41:10 -07:00
raid56.c	btrfs: raid56: Use raid_write_end_io for scrub	2016-01-20 07:22:18 -08:00
raid56.h	Btrfs: add RAID 5/6 BTRFS_RBIO_REBUILD_MISSING operation	2015-08-09 07:34:26 -07:00
rcu-string.h
reada.c	btrfs: reada: Fix returned errno code	2015-10-21 18:29:50 +02:00
relocation.c	btrfs: add free space tree to the cow-only list	2016-01-25 16:48:07 +01:00
root-tree.c	Merge branch 'cleanups/for-4.4' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus-4.4	2015-10-21 18:21:40 -07:00
scrub.c	btrfs: Fix calculation of rbio->dbitmap's size calculation	2016-01-20 07:22:15 -08:00
send.c	Btrfs: send, don't BUG_ON() when an empty symlink is found	2015-12-31 18:08:20 +00:00
send.h	Btrfs: use linux/sizes.h to represent constants	2016-01-07 14:38:02 +01:00
struct-funcs.c
super.c	Revert "btrfs: synchronize incompat feature bits with sysfs files"	2016-01-29 08:19:37 -08:00
sysfs.c	btrfs: sysfs: check initialization state before updating features	2016-01-27 05:40:10 -08:00
sysfs.h	btrfs: sysfs: introduce helper for syncing bits with sysfs files	2016-01-21 18:50:40 +01:00
transaction.c	Merge branch 'misc-cleanups-4.5' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus-4.5	2016-01-11 06:08:37 -08:00
transaction.h	btrfs: preallocate path for snapshot creation at ioctl time	2016-01-07 15:20:55 +01:00
tree-defrag.c	Btrfs: fix locking bugs when defragging leaves	2015-12-18 02:51:32 +00:00
tree-log.c	Btrfs: fix race between fsync and lockless direct IO writes	2016-01-25 16:50:26 -08:00
tree-log.h	Btrfs: fix metadata inconsistencies after directory fsync	2015-03-26 17:56:23 -07:00
ulist.c	btrfs: ulist: Add ulist_del() function.	2015-06-10 09:26:17 -07:00
ulist.h	btrfs: ulist: Add ulist_del() function.	2015-06-10 09:26:17 -07:00
uuid-tree.c	Btrfs: make btrfs_search_forward return with nodes unlocked	2014-09-17 13:38:02 -07:00
volumes.c	Revert "btrfs: synchronize incompat feature bits with sysfs files"	2016-01-29 08:19:37 -08:00
volumes.h	Merge branch 'misc-cleanups-4.5' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus-4.5	2016-01-11 06:08:37 -08:00
xattr.c	Merge branch 'misc-for-4.5' of git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux into for-linus-4.5	2016-01-11 05:59:32 -08:00
xattr.h
zlib.c	btrfs: constify structs with op functions or static definitions	2015-02-16 18:48:44 +01:00