Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-20 10:01:56 +00:00
Code Issues Packages Projects Releases Wiki Activity
30a6a62fc3
linux/drivers/staging/cx25821
History
Mauro Carvalho Chehab 64561a3883 V4L/DVB: Fix unlock logic at medusa_video_init 
As reported by Dan Carpenter:
> This was my patch:  "cx25821: fix double unlock in medusa_video_init()"
>
> It accidentally got merged two times.  The version from the staging tree
> is not correct.  Please can you revert it:
> 7a02f549fc "Staging: cx25821: fix double
> unlock in medusa_video_init()"

After reviewing the logic at the function, instead of just adding a patch to
revert the wrong one, the better is to apply a different logic: add a goto
that will always unlock and return the error.

This simplifies the code a little bit, and, instead of just return -EINVAL,
it will return the error condition reported by the called functions.

This patch is folded with another patch from Dan that added one missing
goto.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
2010-05-19 12:59:16 -03:00
..
cx25821-alsa.c V4L/DVB: cx25821: fix coding style issues in cx25821-alsa.c 2010-05-19 12:58:34 -03:00
cx25821-audio-upstream.c V4L/DVB: cx25821-audio-upstream.c: Fixed some checkpatch.pl warnings/errors 2010-05-18 00:51:02 -03:00
cx25821-audio-upstream.h V4L/DVB (12733): cx25821: some CodingStyle fixes 2009-09-18 23:47:38 -03:00
cx25821-audio.h V4L/DVB (12733): cx25821: some CodingStyle fixes 2009-09-18 23:47:38 -03:00
cx25821-audups11.c V4L/DVB: v4l2-common: simplify prio utility functions 2010-05-19 12:58:54 -03:00
cx25821-biffuncs.h V4L/DVB (12733): cx25821: some CodingStyle fixes 2009-09-18 23:47:38 -03:00
cx25821-cards.c V4L/DVB: staging:cx2581: fixes coding style issues in cx25821-cards.c 2010-05-19 12:58:35 -03:00
cx25821-core.c V4L/DVB: cx25821: prepend cx25821_ to video exported symbols 2010-05-18 00:51:17 -03:00
cx25821-gpio.c V4L/DVB: cx25821: fix coding style issues in cx25821-gpio.c 2010-05-18 00:51:14 -03:00
cx25821-gpio.h V4L/DVB (12733): cx25821: some CodingStyle fixes 2009-09-18 23:47:38 -03:00
cx25821-i2c.c V4L/DVB: staging:cx25821:fixes coding styles in cx25821-i2c.c 2010-05-19 12:58:36 -03:00
cx25821-medusa-defines.h V4L/DVB (12733): cx25821: some CodingStyle fixes 2009-09-18 23:47:38 -03:00
cx25821-medusa-reg.h V4L/DVB (12733): cx25821: some CodingStyle fixes 2009-09-18 23:47:38 -03:00
cx25821-medusa-video.c V4L/DVB: Fix unlock logic at medusa_video_init 2010-05-19 12:59:16 -03:00
cx25821-medusa-video.h V4L/DVB (12733): cx25821: some CodingStyle fixes 2009-09-18 23:47:38 -03:00
cx25821-reg.h V4L/DVB (12733): cx25821: some CodingStyle fixes 2009-09-18 23:47:38 -03:00
cx25821-sram.h V4L/DVB (12733): cx25821: some CodingStyle fixes 2009-09-18 23:47:38 -03:00
cx25821-video0.c V4L/DVB: v4l2-common: simplify prio utility functions 2010-05-19 12:58:54 -03:00
cx25821-video1.c V4L/DVB: v4l2-common: simplify prio utility functions 2010-05-19 12:58:54 -03:00
cx25821-video2.c V4L/DVB: v4l2-common: simplify prio utility functions 2010-05-19 12:58:54 -03:00
cx25821-video3.c V4L/DVB: v4l2-common: simplify prio utility functions 2010-05-19 12:58:54 -03:00
cx25821-video4.c V4L/DVB: v4l2-common: simplify prio utility functions 2010-05-19 12:58:54 -03:00
cx25821-video5.c V4L/DVB: v4l2-common: simplify prio utility functions 2010-05-19 12:58:54 -03:00
cx25821-video6.c V4L/DVB: v4l2-common: simplify prio utility functions 2010-05-19 12:58:54 -03:00
cx25821-video7.c V4L/DVB: v4l2-common: simplify prio utility functions 2010-05-19 12:58:54 -03:00
cx25821-video-upstream-ch2.c include cleanup: Update gfp.h and slab.h includes to prepare for breaking implicit slab.h inclusion from percpu.h 2010-03-30 22:02:32 +09:00
cx25821-video-upstream-ch2.h V4L/DVB (12733): cx25821: some CodingStyle fixes 2009-09-18 23:47:38 -03:00
cx25821-video-upstream.c V4L/DVB: cx25821-video-upstream.c: Added severity to printk calls 2010-05-19 12:58:36 -03:00
cx25821-video-upstream.h V4L/DVB (12733): cx25821: some CodingStyle fixes 2009-09-18 23:47:38 -03:00
cx25821-video.c V4L/DVB: v4l2-common: simplify prio utility functions 2010-05-19 12:58:54 -03:00
cx25821-video.h V4L/DVB: cx25821: prepend cx25821_ to video exported symbols 2010-05-18 00:51:17 -03:00
cx25821-videoioctl.c V4L/DVB: v4l2-common: simplify prio utility functions 2010-05-19 12:58:54 -03:00
cx25821-vidups9.c V4L/DVB: v4l2-common: simplify prio utility functions 2010-05-19 12:58:54 -03:00
cx25821-vidups10.c V4L/DVB: v4l2-common: simplify prio utility functions 2010-05-19 12:58:54 -03:00
cx25821.h V4L/DVB (12733): cx25821: some CodingStyle fixes 2009-09-18 23:47:38 -03:00
Kconfig V4L/DVB (12732): cx25821: fix bad whitespacing 2009-09-18 23:47:37 -03:00
Makefile V4L/DVB (12851): cx25821/Makefile: Cleanup 2009-09-19 00:13:35 -03:00
README V4L/DVB (12847): cx25821: Add README with todo list 2009-09-19 00:13:32 -03:00

README 

Todo:
	- checkpatch.pl cleanups
	- sparse cleanups

Please send patches to linux-media@vger.kernel.org