mirror of
https://github.com/torvalds/linux.git
synced 2024-11-23 20:51:44 +00:00
393dcd1f2b
Eliminate anonymous module_init() and module_exit(), which can lead to
confusion or ambiguity when reading System.map, crashes/oops/bugs,
or an initcall_debug log.
Give each of these init and exit functions unique driver-specific
names to eliminate the anonymous names.
Example 1: (System.map)
ffffffff832fc78c t init
ffffffff832fc79e t init
ffffffff832fc8f8 t init
Example 2: (initcall_debug log)
calling init+0x0/0x12 @ 1
initcall init+0x0/0x12 returned 0 after 15 usecs
calling init+0x0/0x60 @ 1
initcall init+0x0/0x60 returned 0 after 2 usecs
calling init+0x0/0x9a @ 1
initcall init+0x0/0x9a returned 0 after 74 usecs
Fixes: 80fd9cd52d ("usbip: vudc: Add VUDC main file")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Krzysztof Opasiak <k.opasiak@samsung.com>
Cc: Igor Kotrasinski <i.kotrasinsk@samsung.com>
Cc: Valentina Manea <valentina.manea.m@gmail.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Shuah Khan <skhan@linuxfoundation.org>
Cc: linux-usb@vger.kernel.org
Link: https://lore.kernel.org/r/20220316192010.19001-8-rdunlap@infradead.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
111 lines
2.5 KiB
C
111 lines
2.5 KiB
C
// SPDX-License-Identifier: GPL-2.0+
|
|
/*
|
|
* Copyright (C) 2015 Karol Kosik <karo9@interia.eu>
|
|
* Copyright (C) 2015-2016 Samsung Electronics
|
|
* Igor Kotrasinski <i.kotrasinsk@samsung.com>
|
|
* Krzysztof Opasiak <k.opasiak@samsung.com>
|
|
*/
|
|
|
|
#include <linux/device.h>
|
|
#include <linux/list.h>
|
|
#include <linux/module.h>
|
|
|
|
#include "vudc.h"
|
|
|
|
static unsigned int vudc_number = 1;
|
|
|
|
module_param_named(num, vudc_number, uint, S_IRUGO);
|
|
MODULE_PARM_DESC(num, "number of emulated controllers");
|
|
|
|
static struct platform_driver vudc_driver = {
|
|
.probe = vudc_probe,
|
|
.remove = vudc_remove,
|
|
.driver = {
|
|
.name = GADGET_NAME,
|
|
.dev_groups = vudc_groups,
|
|
},
|
|
};
|
|
|
|
static LIST_HEAD(vudc_devices);
|
|
|
|
static int __init vudc_init(void)
|
|
{
|
|
int retval = -ENOMEM;
|
|
int i;
|
|
struct vudc_device *udc_dev = NULL, *udc_dev2 = NULL;
|
|
|
|
if (usb_disabled())
|
|
return -ENODEV;
|
|
|
|
if (vudc_number < 1) {
|
|
pr_err("Number of emulated UDC must be no less than 1");
|
|
return -EINVAL;
|
|
}
|
|
|
|
retval = platform_driver_register(&vudc_driver);
|
|
if (retval < 0)
|
|
goto out;
|
|
|
|
for (i = 0; i < vudc_number; i++) {
|
|
udc_dev = alloc_vudc_device(i);
|
|
if (!udc_dev) {
|
|
retval = -ENOMEM;
|
|
goto cleanup;
|
|
}
|
|
|
|
retval = platform_device_add(udc_dev->pdev);
|
|
if (retval < 0) {
|
|
put_vudc_device(udc_dev);
|
|
goto cleanup;
|
|
}
|
|
|
|
list_add_tail(&udc_dev->dev_entry, &vudc_devices);
|
|
if (!platform_get_drvdata(udc_dev->pdev)) {
|
|
/*
|
|
* The udc was added successfully but its probe
|
|
* function failed for some reason.
|
|
*/
|
|
retval = -EINVAL;
|
|
goto cleanup;
|
|
}
|
|
}
|
|
goto out;
|
|
|
|
cleanup:
|
|
list_for_each_entry_safe(udc_dev, udc_dev2, &vudc_devices, dev_entry) {
|
|
list_del(&udc_dev->dev_entry);
|
|
/*
|
|
* Just do platform_device_del() here, put_vudc_device()
|
|
* calls the platform_device_put()
|
|
*/
|
|
platform_device_del(udc_dev->pdev);
|
|
put_vudc_device(udc_dev);
|
|
}
|
|
|
|
platform_driver_unregister(&vudc_driver);
|
|
out:
|
|
return retval;
|
|
}
|
|
module_init(vudc_init);
|
|
|
|
static void __exit vudc_cleanup(void)
|
|
{
|
|
struct vudc_device *udc_dev = NULL, *udc_dev2 = NULL;
|
|
|
|
list_for_each_entry_safe(udc_dev, udc_dev2, &vudc_devices, dev_entry) {
|
|
list_del(&udc_dev->dev_entry);
|
|
/*
|
|
* Just do platform_device_del() here, put_vudc_device()
|
|
* calls the platform_device_put()
|
|
*/
|
|
platform_device_del(udc_dev->pdev);
|
|
put_vudc_device(udc_dev);
|
|
}
|
|
platform_driver_unregister(&vudc_driver);
|
|
}
|
|
module_exit(vudc_cleanup);
|
|
|
|
MODULE_DESCRIPTION("USB over IP Device Controller");
|
|
MODULE_AUTHOR("Krzysztof Opasiak, Karol Kosik, Igor Kotrasinski");
|
|
MODULE_LICENSE("GPL");
|