Duoming Zhou f1e941dbf8 nfc: pn533: Fix use-after-free bugs caused by pn532_cmd_timeout ... When the pn532 uart device is detaching, the pn532_uart_remove() is called. But there are no functions in pn532_uart_remove() that could delete the cmd_timeout timer, which will cause use-after-free bugs. The process is shown below: (thread 1) | (thread 2) | pn532_uart_send_frame pn532_uart_remove | mod_timer(&pn532->cmd_timeout,...) ... | (wait a time) kfree(pn532) //FREE | pn532_cmd_timeout | pn532_uart_send_frame | pn532->... //USE This patch adds del_timer_sync() in pn532_uart_remove() in order to prevent the use-after-free bugs. What's more, the pn53x_unregister_nfc() is well synchronized, it sets nfc_dev->shutting_down to true and there are no syscalls could restart the cmd_timeout timer. Fixes: c656aa4c27 ("nfc: pn533: add UART phy driver") Signed-off-by: Duoming Zhou <duoming@zju.edu.cn> Signed-off-by: David S. Miller <davem@davemloft.net>		2022-08-22 14:51:30 +01:00
..
i2c.c	nfc: pn533: Constify pn533_phy_ops	2021-10-07 13:35:10 +01:00
Kconfig	treewide: replace '---help---' in Kconfig files with 'help'	2020-06-14 01:57:21 +09:00
Makefile	nfc: pn533: add UART phy driver	2019-10-29 21:05:26 -07:00
pn533.c	nfc: pn533: Fix buggy cleanup order	2022-05-18 13:58:13 +01:00
pn533.h	nfc: pn533: Constify pn533_phy_ops	2021-10-07 13:35:10 +01:00
uart.c	nfc: pn533: Fix use-after-free bugs caused by pn532_cmd_timeout	2022-08-22 14:51:30 +01:00
usb.c	nfc: pn533: Constify pn533_phy_ops	2021-10-07 13:35:10 +01:00