Minki/linux
1
0
Fork 1
mirror of https://github.com/torvalds/linux.git synced 2024-12-04 01:51:34 +00:00
Code Issues Packages Projects Releases Wiki Activity
2c114df071
linux/drivers/usb/renesas_usbhs
History
Yoshihiro Shimoda ea0efd687b usb: renesas_usbhs: getting residue from callback_result 
This driver assumed that dmaengine_tx_status() could return
the residue even if the transfer was completed. However,
this was not correct usage [1] and this caused to break getting
the residue after the commit 24461d9792 ("dmaengine:
virt-dma: Fix access after free in vchan_complete()") actually.
So, this is possible to get wrong received size if the usb
controller gets a short packet. For example, g_zero driver
causes "bad OUT byte" errors.

The usb-dmac driver will support the callback_result, so this
driver can use it to get residue correctly. Note that even if
the usb-dmac driver has not supported the callback_result yet,
this patch doesn't cause any side-effects.

[1]
https://lore.kernel.org/dmaengine/20200616165550.GP2324254@vkoul-mobl/

Reported-by: Hien Dang <hien.dang.eb@renesas.com>
Fixes: 24461d9792 ("dmaengine: virt-dma: Fix access after free in vchan_complete()")
Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Link: https://lore.kernel.org/r/1592482277-19563-1-git-send-email-yoshihiro.shimoda.uh@renesas.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2020-06-24 17:14:44 +02:00
..
common.c usb: renesas_usbhs: Switch to GPIO descriptor 2019-12-30 20:37:42 +01:00
common.h usb: renesas_usbhs: Use the correct style for SPDX License Identifier 2020-04-23 15:28:14 +02:00
fifo.c usb: renesas_usbhs: getting residue from callback_result 2020-06-24 17:14:44 +02:00
fifo.h usb: renesas_usbhs: getting residue from callback_result 2020-06-24 17:14:44 +02:00
Kconfig usb: remove redundant 'default n' from Kconfig-s 2019-05-21 10:06:22 +02:00
Makefile usb: renesas_usbhs: Add support for RZ/A2 2019-05-21 10:25:59 +02:00
mod_gadget.c Merge 5.4-rc6 into usb-next 2019-11-04 06:41:09 +01:00
mod_host.c usb: add a HCD_DMA flag instead of guestimating DMA capabilities 2019-08-21 10:03:35 -07:00
mod.c usb: renesas_usbhs: enable DVSE interrupt 2019-10-04 14:16:54 +02:00
mod.h usb: renesas_usbhs: Use the correct style for SPDX License Identifier 2020-04-23 15:28:14 +02:00
pipe.c usb: renesas_usbhs: gadget: Fix usb_ep_set_{halt,wedge}() behavior 2019-10-04 14:36:22 +02:00
pipe.h usb: renesas_usbhs: Use the correct style for SPDX License Identifier 2020-04-23 15:28:14 +02:00
rcar2.c phy: for 5.6 2020-01-17 07:52:26 +01:00
rcar2.h usb: renesas_usbhs: Use the correct style for SPDX License Identifier 2020-04-23 15:28:14 +02:00
rcar3.c usb: renesas_usbhs: Use renesas_usbhs_platform_info on of_device_id.data 2019-06-26 10:33:09 +08:00
rcar3.h usb: renesas_usbhs: Use the correct style for SPDX License Identifier 2020-04-23 15:28:14 +02:00
rza2.c phy: core: Add consumer device link support 2020-01-08 12:48:47 +05:30
rza.c usb: renesas_usbhs: Use renesas_usbhs_platform_info on of_device_id.data 2019-06-26 10:33:09 +08:00
rza.h usb: renesas_usbhs: Use the correct style for SPDX License Identifier 2020-04-23 15:28:14 +02:00