mirror of
https://github.com/torvalds/linux.git
synced 2024-11-30 08:01:59 +00:00
a9d9baa1e8
There are some callers in cpufreq hotplug notify path that the lowest function calls lock_cpu_hotplug(). The lock is already held during cpu_up() and cpu_down() calls when the notify calls are broadcast to registered clients. Ideally if possible, we could disable_preempt() at the highest caller and make sure we dont sleep in the path down in cpufreq->driver_target() calls but the calls are so intertwined and cumbersome to cleanup. Hence we consistently use lock_cpu_hotplug() and unlock_cpu_hotplug() in all places. - Removed export of cpucontrol semaphore and made it static. - removed explicit uses of up/down with lock_cpu_hotplug() so we can keep track of the the callers in same thread context and just keep refcounts without calling a down() that causes a deadlock. - Removed current_in_hotplug() uses - Removed PF_HOTPLUG_CPU in sched.h introduced for the current_in_hotplug() temporary workaround. Tested with insmod of cpufreq_stat.ko, and logical online/offline to make sure we dont have any hang situations. Signed-off-by: Ashok Raj <ashok.raj@intel.com> Cc: Zwane Mwaikambo <zwane@linuxpower.ca> Cc: Shaohua Li <shaohua.li@intel.com> Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
239 lines
4.9 KiB
C
239 lines
4.9 KiB
C
/* CPU control.
|
|
* (C) 2001, 2002, 2003, 2004 Rusty Russell
|
|
*
|
|
* This code is licenced under the GPL.
|
|
*/
|
|
#include <linux/proc_fs.h>
|
|
#include <linux/smp.h>
|
|
#include <linux/init.h>
|
|
#include <linux/notifier.h>
|
|
#include <linux/sched.h>
|
|
#include <linux/unistd.h>
|
|
#include <linux/cpu.h>
|
|
#include <linux/module.h>
|
|
#include <linux/kthread.h>
|
|
#include <linux/stop_machine.h>
|
|
#include <asm/semaphore.h>
|
|
|
|
/* This protects CPUs going up and down... */
|
|
static DECLARE_MUTEX(cpucontrol);
|
|
|
|
static struct notifier_block *cpu_chain;
|
|
|
|
#ifdef CONFIG_HOTPLUG_CPU
|
|
static struct task_struct *lock_cpu_hotplug_owner;
|
|
static int lock_cpu_hotplug_depth;
|
|
|
|
static int __lock_cpu_hotplug(int interruptible)
|
|
{
|
|
int ret = 0;
|
|
|
|
if (lock_cpu_hotplug_owner != current) {
|
|
if (interruptible)
|
|
ret = down_interruptible(&cpucontrol);
|
|
else
|
|
down(&cpucontrol);
|
|
}
|
|
|
|
/*
|
|
* Set only if we succeed in locking
|
|
*/
|
|
if (!ret) {
|
|
lock_cpu_hotplug_depth++;
|
|
lock_cpu_hotplug_owner = current;
|
|
}
|
|
|
|
return ret;
|
|
}
|
|
|
|
void lock_cpu_hotplug(void)
|
|
{
|
|
__lock_cpu_hotplug(0);
|
|
}
|
|
EXPORT_SYMBOL_GPL(lock_cpu_hotplug);
|
|
|
|
void unlock_cpu_hotplug(void)
|
|
{
|
|
if (--lock_cpu_hotplug_depth == 0) {
|
|
lock_cpu_hotplug_owner = NULL;
|
|
up(&cpucontrol);
|
|
}
|
|
}
|
|
EXPORT_SYMBOL_GPL(unlock_cpu_hotplug);
|
|
|
|
int lock_cpu_hotplug_interruptible(void)
|
|
{
|
|
return __lock_cpu_hotplug(1);
|
|
}
|
|
EXPORT_SYMBOL_GPL(lock_cpu_hotplug_interruptible);
|
|
#endif /* CONFIG_HOTPLUG_CPU */
|
|
|
|
/* Need to know about CPUs going up/down? */
|
|
int register_cpu_notifier(struct notifier_block *nb)
|
|
{
|
|
int ret;
|
|
|
|
if ((ret = lock_cpu_hotplug_interruptible()) != 0)
|
|
return ret;
|
|
ret = notifier_chain_register(&cpu_chain, nb);
|
|
unlock_cpu_hotplug();
|
|
return ret;
|
|
}
|
|
EXPORT_SYMBOL(register_cpu_notifier);
|
|
|
|
void unregister_cpu_notifier(struct notifier_block *nb)
|
|
{
|
|
lock_cpu_hotplug();
|
|
notifier_chain_unregister(&cpu_chain, nb);
|
|
unlock_cpu_hotplug();
|
|
}
|
|
EXPORT_SYMBOL(unregister_cpu_notifier);
|
|
|
|
#ifdef CONFIG_HOTPLUG_CPU
|
|
static inline void check_for_tasks(int cpu)
|
|
{
|
|
struct task_struct *p;
|
|
|
|
write_lock_irq(&tasklist_lock);
|
|
for_each_process(p) {
|
|
if (task_cpu(p) == cpu &&
|
|
(!cputime_eq(p->utime, cputime_zero) ||
|
|
!cputime_eq(p->stime, cputime_zero)))
|
|
printk(KERN_WARNING "Task %s (pid = %d) is on cpu %d\
|
|
(state = %ld, flags = %lx) \n",
|
|
p->comm, p->pid, cpu, p->state, p->flags);
|
|
}
|
|
write_unlock_irq(&tasklist_lock);
|
|
}
|
|
|
|
/* Take this CPU down. */
|
|
static int take_cpu_down(void *unused)
|
|
{
|
|
int err;
|
|
|
|
/* Ensure this CPU doesn't handle any more interrupts. */
|
|
err = __cpu_disable();
|
|
if (err < 0)
|
|
return err;
|
|
|
|
/* Force idle task to run as soon as we yield: it should
|
|
immediately notice cpu is offline and die quickly. */
|
|
sched_idle_next();
|
|
return 0;
|
|
}
|
|
|
|
int cpu_down(unsigned int cpu)
|
|
{
|
|
int err;
|
|
struct task_struct *p;
|
|
cpumask_t old_allowed, tmp;
|
|
|
|
if ((err = lock_cpu_hotplug_interruptible()) != 0)
|
|
return err;
|
|
|
|
if (num_online_cpus() == 1) {
|
|
err = -EBUSY;
|
|
goto out;
|
|
}
|
|
|
|
if (!cpu_online(cpu)) {
|
|
err = -EINVAL;
|
|
goto out;
|
|
}
|
|
|
|
err = notifier_call_chain(&cpu_chain, CPU_DOWN_PREPARE,
|
|
(void *)(long)cpu);
|
|
if (err == NOTIFY_BAD) {
|
|
printk("%s: attempt to take down CPU %u failed\n",
|
|
__FUNCTION__, cpu);
|
|
err = -EINVAL;
|
|
goto out;
|
|
}
|
|
|
|
/* Ensure that we are not runnable on dying cpu */
|
|
old_allowed = current->cpus_allowed;
|
|
tmp = CPU_MASK_ALL;
|
|
cpu_clear(cpu, tmp);
|
|
set_cpus_allowed(current, tmp);
|
|
|
|
p = __stop_machine_run(take_cpu_down, NULL, cpu);
|
|
if (IS_ERR(p)) {
|
|
/* CPU didn't die: tell everyone. Can't complain. */
|
|
if (notifier_call_chain(&cpu_chain, CPU_DOWN_FAILED,
|
|
(void *)(long)cpu) == NOTIFY_BAD)
|
|
BUG();
|
|
|
|
err = PTR_ERR(p);
|
|
goto out_allowed;
|
|
}
|
|
|
|
if (cpu_online(cpu))
|
|
goto out_thread;
|
|
|
|
/* Wait for it to sleep (leaving idle task). */
|
|
while (!idle_cpu(cpu))
|
|
yield();
|
|
|
|
/* This actually kills the CPU. */
|
|
__cpu_die(cpu);
|
|
|
|
/* Move it here so it can run. */
|
|
kthread_bind(p, get_cpu());
|
|
put_cpu();
|
|
|
|
/* CPU is completely dead: tell everyone. Too late to complain. */
|
|
if (notifier_call_chain(&cpu_chain, CPU_DEAD, (void *)(long)cpu)
|
|
== NOTIFY_BAD)
|
|
BUG();
|
|
|
|
check_for_tasks(cpu);
|
|
|
|
out_thread:
|
|
err = kthread_stop(p);
|
|
out_allowed:
|
|
set_cpus_allowed(current, old_allowed);
|
|
out:
|
|
unlock_cpu_hotplug();
|
|
return err;
|
|
}
|
|
#endif /*CONFIG_HOTPLUG_CPU*/
|
|
|
|
int __devinit cpu_up(unsigned int cpu)
|
|
{
|
|
int ret;
|
|
void *hcpu = (void *)(long)cpu;
|
|
|
|
if ((ret = lock_cpu_hotplug_interruptible()) != 0)
|
|
return ret;
|
|
|
|
if (cpu_online(cpu) || !cpu_present(cpu)) {
|
|
ret = -EINVAL;
|
|
goto out;
|
|
}
|
|
|
|
ret = notifier_call_chain(&cpu_chain, CPU_UP_PREPARE, hcpu);
|
|
if (ret == NOTIFY_BAD) {
|
|
printk("%s: attempt to bring up CPU %u failed\n",
|
|
__FUNCTION__, cpu);
|
|
ret = -EINVAL;
|
|
goto out_notify;
|
|
}
|
|
|
|
/* Arch-specific enabling code. */
|
|
ret = __cpu_up(cpu);
|
|
if (ret != 0)
|
|
goto out_notify;
|
|
if (!cpu_online(cpu))
|
|
BUG();
|
|
|
|
/* Now call notifier in preparation. */
|
|
notifier_call_chain(&cpu_chain, CPU_ONLINE, hcpu);
|
|
|
|
out_notify:
|
|
if (ret != 0)
|
|
notifier_call_chain(&cpu_chain, CPU_UP_CANCELED, hcpu);
|
|
out:
|
|
unlock_cpu_hotplug();
|
|
return ret;
|
|
}
|