Zhang Changzhong 2b8b2e3155 can: j1939: abort multipacket broadcast session when timeout occurs ... If timeout occurs, j1939_tp_rxtimer() first calls hrtimer_start() to restart rxtimer, and then calls __j1939_session_cancel() to set session->state = J1939_SESSION_WAITING_ABORT. At next timeout expiration, because of the J1939_SESSION_WAITING_ABORT session state j1939_tp_rxtimer() will call j1939_session_deactivate_activate_next() to deactivate current session, and rxtimer won't be set. But for multipacket broadcast session, __j1939_session_cancel() don't set session->state = J1939_SESSION_WAITING_ABORT, thus current session won't be deactivate and hrtimer_start() is called to start new rxtimer again and again. So fix it by moving session->state = J1939_SESSION_WAITING_ABORT out of if (!j1939_cb_is_broadcast(&session->skcb)) statement. Fixes: 9d71dd0c70 ("can: add support of SAE J1939 protocol") Signed-off-by: Zhang Changzhong <zhangchangzhong@huawei.com> Link: https://lore.kernel.org/r/1596599425-5534-4-git-send-email-zhangchangzhong@huawei.com Acked-by: Oleksij Rempel <o.rempel@pengutronix.de> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>		2020-08-15 11:12:58 +02:00
..
address-claim.c
bus.c
j1939-priv.h
Kconfig
main.c	can: j1939: warn if resources are still linked on destroy	2019-11-13 10:42:34 +01:00
Makefile
socket.c	can: j1939: socket: j1939_sk_bind(): make sure ml_priv is allocated	2020-08-14 12:38:47 +02:00
transport.c	can: j1939: abort multipacket broadcast session when timeout occurs	2020-08-15 11:12:58 +02:00