linux/drivers/scsi/lpfc
James Smart 2ade92ae6d scsi: lpfc: code cleanups in NVME initiator base
This patch addresses the smatch issues identified by Dan Carpenter
in http://www.spinics.net/lists/linux-scsi/msg105663.html

The issues are:

drivers/scsi/lpfc/lpfc_hbadisc.c:316 lpfc_dev_loss_tmo_handler()
warn: we tested 'vport->load_flag & 2' before and it was 'false'

Action: removed item from test

drivers/scsi/lpfc/lpfc_hbadisc.c:701 lpfc_work_done()
warn: test_bit() takes a bit number

Action: changed definition so bit number

drivers/scsi/lpfc/lpfc_hbadisc.c:2206 lpfc_mbx_cmpl_fcf_scan_read_fcf_rec()
error: uninitialized symbol 'vlan_id'.
drivers/scsi/lpfc/lpfc_hbadisc.c:2582 lpfc_mbx_cmpl_fcf_rr_read_fcf_rec()
error: uninitialized symbol 'vlan_id'.
drivers/scsi/lpfc/lpfc_hbadisc.c:2683 lpfc_mbx_cmpl_read_fcf_rec() error:
uninitialized symbol 'vlan_id'.

Action: initilized value

drivers/scsi/lpfc/lpfc_hbadisc.c:4025 lpfc_register_remote_port()
error: we previously assumed 'rdata' could be null (see line 4023)

Action: refactored check block

drivers/scsi/lpfc/lpfc_hbadisc.c:4613 lpfc_sli4_dequeue_nport_iocbs()
error: double unlock 'irq:'

Action: removed inner irq reference

Signed-off-by: Dick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
2017-03-06 23:04:23 -05:00
..
lpfc_attr.c scsi: lpfc: Rename LPFC_MAX_EQ_DELAY to LPFC_MAX_EQ_DELAY_EQID_CNT 2017-03-06 23:04:22 -05:00
lpfc_attr.h scsi: lpfc: Update copyrights 2017-02-22 18:41:44 -05:00
lpfc_bsg.c scsi: lpfc: Update copyrights 2017-02-22 18:41:44 -05:00
lpfc_bsg.h scsi: lpfc: Update copyrights 2017-02-22 18:41:44 -05:00
lpfc_compat.h scsi: lpfc: Update copyrights 2017-02-22 18:41:44 -05:00
lpfc_crtn.h scsi: lpfc: Fix eh_deadline setting for sli3 adapters. 2017-03-06 23:04:22 -05:00
lpfc_ct.c scsi: lpfc: Update copyrights 2017-02-22 18:41:44 -05:00
lpfc_debugfs.c scsi: lpfc: correct double print 2017-03-06 23:04:22 -05:00
lpfc_debugfs.h scsi: lpfc: Update copyrights 2017-02-22 18:41:44 -05:00
lpfc_disc.h scsi: lpfc: Update copyrights 2017-02-22 18:41:44 -05:00
lpfc_els.c scsi: lpfc: correct rdp diag portnames 2017-03-06 23:04:23 -05:00
lpfc_hbadisc.c scsi: lpfc: code cleanups in NVME initiator base 2017-03-06 23:04:23 -05:00
lpfc_hw4.h scsi: lpfc: Rename LPFC_MAX_EQ_DELAY to LPFC_MAX_EQ_DELAY_EQID_CNT 2017-03-06 23:04:22 -05:00
lpfc_hw.h scsi: lpfc: Update copyrights 2017-02-22 18:41:44 -05:00
lpfc_ids.h scsi: lpfc: Update copyrights 2017-02-22 18:41:44 -05:00
lpfc_init.c scsi: lpfc: remove dead sli3 nvme code 2017-03-06 23:04:22 -05:00
lpfc_logmsg.h scsi: lpfc: Update copyrights 2017-02-22 18:41:44 -05:00
lpfc_mbox.c scsi: lpfc: Update copyrights 2017-02-22 18:41:44 -05:00
lpfc_mem.c scsi: lpfc: don't dereference dma_buf->iocbq before null check 2017-03-06 23:04:22 -05:00
lpfc_nl.h scsi: lpfc: Update copyrights 2017-02-22 18:41:44 -05:00
lpfc_nportdisc.c scsi: lpfc: Update copyrights 2017-02-22 18:41:44 -05:00
lpfc_nvme.c scsi: lpfc: Rework lpfc Kconfig for NVME options 2017-03-06 23:04:22 -05:00
lpfc_nvme.h scsi: lpfc: add NVME exchange aborts 2017-03-06 23:04:22 -05:00
lpfc_nvmet.c scsi: lpfc: Rework lpfc Kconfig for NVME options 2017-03-06 23:04:22 -05:00
lpfc_nvmet.h scsi: lpfc: Update copyrights 2017-02-22 18:41:44 -05:00
lpfc_scsi.c scsi: lpfc: add transport eh_timed_out reference 2017-03-06 23:04:22 -05:00
lpfc_scsi.h scsi: lpfc: Update copyrights 2017-02-22 18:41:44 -05:00
lpfc_sli4.h scsi: lpfc: add NVME exchange aborts 2017-03-06 23:04:22 -05:00
lpfc_sli.c scsi: lpfc: Rename LPFC_MAX_EQ_DELAY to LPFC_MAX_EQ_DELAY_EQID_CNT 2017-03-06 23:04:22 -05:00
lpfc_sli.h scsi: lpfc: Update copyrights 2017-02-22 18:41:44 -05:00
lpfc_version.h scsi: lpfc: Update lpfc version to 11.2.0.7 2017-02-22 18:41:44 -05:00
lpfc_vport.c scsi: lpfc: Update copyrights 2017-02-22 18:41:44 -05:00
lpfc_vport.h scsi: lpfc: Update copyrights 2017-02-22 18:41:44 -05:00
lpfc.h scsi: lpfc: code cleanups in NVME initiator base 2017-03-06 23:04:23 -05:00
Makefile scsi: lpfc: Update copyrights 2017-02-22 18:41:44 -05:00