mirror of
https://github.com/torvalds/linux.git
synced 2024-11-24 05:02:12 +00:00
99b7623380
Setting ->owner as done currently (pde->owner = THIS_MODULE) is racy as correctly noted at bug #12454. Someone can lookup entry with NULL ->owner, thus not pinning enything, and release it later resulting in module refcount underflow. We can keep ->owner and supply it at registration time like ->proc_fops and ->data. But this leaves ->owner as easy-manipulative field (just one C assignment) and somebody will forget to unpin previous/pin current module when switching ->owner. ->proc_fops is declared as "const" which should give some thoughts. ->read_proc/->write_proc were just fixed to not require ->owner for protection. rmmod'ed directories will be empty and return "." and ".." -- no harm. And directories with tricky enough readdir and lookup shouldn't be modular. We definitely don't want such modular code. Removing ->owner will also make PDE smaller. So, let's nuke it. Kudos to Jeff Layton for reminding about this, let's say, oversight. http://bugzilla.kernel.org/show_bug.cgi?id=12454 Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
117 lines
2.8 KiB
C
117 lines
2.8 KiB
C
/*
|
|
* RTC subsystem, proc interface
|
|
*
|
|
* Copyright (C) 2005-06 Tower Technologies
|
|
* Author: Alessandro Zummo <a.zummo@towertech.it>
|
|
*
|
|
* based on arch/arm/common/rtctime.c
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License version 2 as
|
|
* published by the Free Software Foundation.
|
|
*/
|
|
|
|
#include <linux/module.h>
|
|
#include <linux/rtc.h>
|
|
#include <linux/proc_fs.h>
|
|
#include <linux/seq_file.h>
|
|
|
|
#include "rtc-core.h"
|
|
|
|
|
|
static int rtc_proc_show(struct seq_file *seq, void *offset)
|
|
{
|
|
int err;
|
|
struct rtc_device *rtc = seq->private;
|
|
const struct rtc_class_ops *ops = rtc->ops;
|
|
struct rtc_wkalrm alrm;
|
|
struct rtc_time tm;
|
|
|
|
err = rtc_read_time(rtc, &tm);
|
|
if (err == 0) {
|
|
seq_printf(seq,
|
|
"rtc_time\t: %02d:%02d:%02d\n"
|
|
"rtc_date\t: %04d-%02d-%02d\n",
|
|
tm.tm_hour, tm.tm_min, tm.tm_sec,
|
|
tm.tm_year + 1900, tm.tm_mon + 1, tm.tm_mday);
|
|
}
|
|
|
|
err = rtc_read_alarm(rtc, &alrm);
|
|
if (err == 0) {
|
|
seq_printf(seq, "alrm_time\t: ");
|
|
if ((unsigned int)alrm.time.tm_hour <= 24)
|
|
seq_printf(seq, "%02d:", alrm.time.tm_hour);
|
|
else
|
|
seq_printf(seq, "**:");
|
|
if ((unsigned int)alrm.time.tm_min <= 59)
|
|
seq_printf(seq, "%02d:", alrm.time.tm_min);
|
|
else
|
|
seq_printf(seq, "**:");
|
|
if ((unsigned int)alrm.time.tm_sec <= 59)
|
|
seq_printf(seq, "%02d\n", alrm.time.tm_sec);
|
|
else
|
|
seq_printf(seq, "**\n");
|
|
|
|
seq_printf(seq, "alrm_date\t: ");
|
|
if ((unsigned int)alrm.time.tm_year <= 200)
|
|
seq_printf(seq, "%04d-", alrm.time.tm_year + 1900);
|
|
else
|
|
seq_printf(seq, "****-");
|
|
if ((unsigned int)alrm.time.tm_mon <= 11)
|
|
seq_printf(seq, "%02d-", alrm.time.tm_mon + 1);
|
|
else
|
|
seq_printf(seq, "**-");
|
|
if (alrm.time.tm_mday && (unsigned int)alrm.time.tm_mday <= 31)
|
|
seq_printf(seq, "%02d\n", alrm.time.tm_mday);
|
|
else
|
|
seq_printf(seq, "**\n");
|
|
seq_printf(seq, "alarm_IRQ\t: %s\n",
|
|
alrm.enabled ? "yes" : "no");
|
|
seq_printf(seq, "alrm_pending\t: %s\n",
|
|
alrm.pending ? "yes" : "no");
|
|
}
|
|
|
|
seq_printf(seq, "24hr\t\t: yes\n");
|
|
|
|
if (ops->proc)
|
|
ops->proc(rtc->dev.parent, seq);
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int rtc_proc_open(struct inode *inode, struct file *file)
|
|
{
|
|
struct rtc_device *rtc = PDE(inode)->data;
|
|
|
|
if (!try_module_get(THIS_MODULE))
|
|
return -ENODEV;
|
|
|
|
return single_open(file, rtc_proc_show, rtc);
|
|
}
|
|
|
|
static int rtc_proc_release(struct inode *inode, struct file *file)
|
|
{
|
|
int res = single_release(inode, file);
|
|
module_put(THIS_MODULE);
|
|
return res;
|
|
}
|
|
|
|
static const struct file_operations rtc_proc_fops = {
|
|
.open = rtc_proc_open,
|
|
.read = seq_read,
|
|
.llseek = seq_lseek,
|
|
.release = rtc_proc_release,
|
|
};
|
|
|
|
void rtc_proc_add_device(struct rtc_device *rtc)
|
|
{
|
|
if (rtc->id == 0)
|
|
proc_create_data("driver/rtc", 0, NULL, &rtc_proc_fops, rtc);
|
|
}
|
|
|
|
void rtc_proc_del_device(struct rtc_device *rtc)
|
|
{
|
|
if (rtc->id == 0)
|
|
remove_proc_entry("driver/rtc", NULL);
|
|
}
|