mirror of
https://github.com/torvalds/linux.git
synced 2024-12-11 21:52:04 +00:00
2bc20f3c84
The busy loop in rpmh_rsc_send_data() is written with the assumption that the udelay will be preempted by the tcs_tx_done() irq handler when the TCS slots are all full. This doesn't hold true when the calling thread is an irqthread and the tcs_tx_done() irq is also an irqthread. That's because kernel irqthreads are SCHED_FIFO and thus need to voluntarily give up priority by calling into the scheduler so that other threads can run. I see RCU stalls when I boot with irqthreads on the kernel commandline because the modem remoteproc driver is trying to send an rpmh async message from an irqthread that needs to give up the CPU for the rpmh irqthread to run and clear out tcs slots. rcu: INFO: rcu_preempt self-detected stall on CPU rcu: 0-....: (1 GPs behind) idle=402/1/0x4000000000000002 softirq=2108/2109 fqs=4920 (t=21016 jiffies g=2933 q=590) Task dump for CPU 0: irq/11-smp2p R running task 0 148 2 0x00000028 Call trace: dump_backtrace+0x0/0x154 show_stack+0x20/0x2c sched_show_task+0xfc/0x108 dump_cpu_task+0x44/0x50 rcu_dump_cpu_stacks+0xa4/0xf8 rcu_sched_clock_irq+0x7dc/0xaa8 update_process_times+0x30/0x54 tick_sched_handle+0x50/0x64 tick_sched_timer+0x4c/0x8c __hrtimer_run_queues+0x21c/0x36c hrtimer_interrupt+0xf0/0x22c arch_timer_handler_phys+0x40/0x50 handle_percpu_devid_irq+0x114/0x25c __handle_domain_irq+0x84/0xc4 gic_handle_irq+0xd0/0x178 el1_irq+0xbc/0x180 save_return_addr+0x18/0x28 return_address+0x54/0x88 preempt_count_sub+0x40/0x88 _raw_spin_unlock_irqrestore+0x4c/0x6c ___ratelimit+0xd0/0x128 rpmh_rsc_send_data+0x24c/0x378 __rpmh_write+0x1b0/0x208 rpmh_write_async+0x90/0xbc rpmhpd_send_corner+0x60/0x8c rpmhpd_aggregate_corner+0x8c/0x124 rpmhpd_set_performance_state+0x8c/0xbc _genpd_set_performance_state+0xdc/0x1b8 dev_pm_genpd_set_performance_state+0xb8/0xf8 q6v5_pds_disable+0x34/0x60 [qcom_q6v5_mss] qcom_msa_handover+0x38/0x44 [qcom_q6v5_mss] q6v5_handover_interrupt+0x24/0x3c [qcom_q6v5] handle_nested_irq+0xd0/0x138 qcom_smp2p_intr+0x188/0x200 irq_thread_fn+0x2c/0x70 irq_thread+0xfc/0x14c kthread+0x11c/0x12c ret_from_fork+0x10/0x18 This busy loop naturally lends itself to using a wait queue so that each thread that tries to send a message will sleep waiting on the waitqueue and only be woken up when a free slot is available. This should make things more predictable too because the scheduler will be able to sleep tasks that are waiting on a free tcs instead of the busy loop we currently have today. Reviewed-by: Maulik Shah <mkshah@codeaurora.org> Reviewed-by: Douglas Anderson <dianders@chromium.org> Tested-by: Stanimir Varbanov <stanimir.varbanov@linaro.org> Cc: Douglas Anderson <dianders@chromium.org> Cc: Maulik Shah <mkshah@codeaurora.org> Cc: Lina Iyer <ilina@codeaurora.org> Signed-off-by: Stephen Boyd <swboyd@chromium.org> Link: https://lore.kernel.org/r/20200724211711.810009-1-sboyd@kernel.org Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
137 lines
4.6 KiB
C
137 lines
4.6 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* Copyright (c) 2016-2018, The Linux Foundation. All rights reserved.
|
|
*/
|
|
|
|
|
|
#ifndef __RPM_INTERNAL_H__
|
|
#define __RPM_INTERNAL_H__
|
|
|
|
#include <linux/bitmap.h>
|
|
#include <linux/wait.h>
|
|
#include <soc/qcom/tcs.h>
|
|
|
|
#define TCS_TYPE_NR 4
|
|
#define MAX_CMDS_PER_TCS 16
|
|
#define MAX_TCS_PER_TYPE 3
|
|
#define MAX_TCS_NR (MAX_TCS_PER_TYPE * TCS_TYPE_NR)
|
|
#define MAX_TCS_SLOTS (MAX_CMDS_PER_TCS * MAX_TCS_PER_TYPE)
|
|
|
|
struct rsc_drv;
|
|
|
|
/**
|
|
* struct tcs_group: group of Trigger Command Sets (TCS) to send state requests
|
|
* to the controller
|
|
*
|
|
* @drv: The controller.
|
|
* @type: Type of the TCS in this group - active, sleep, wake.
|
|
* @mask: Mask of the TCSes relative to all the TCSes in the RSC.
|
|
* @offset: Start of the TCS group relative to the TCSes in the RSC.
|
|
* @num_tcs: Number of TCSes in this type.
|
|
* @ncpt: Number of commands in each TCS.
|
|
* @req: Requests that are sent from the TCS; only used for ACTIVE_ONLY
|
|
* transfers (could be on a wake/sleep TCS if we are borrowing for
|
|
* an ACTIVE_ONLY transfer).
|
|
* Start: grab drv->lock, set req, set tcs_in_use, drop drv->lock,
|
|
* trigger
|
|
* End: get irq, access req,
|
|
* grab drv->lock, clear tcs_in_use, drop drv->lock
|
|
* @slots: Indicates which of @cmd_addr are occupied; only used for
|
|
* SLEEP / WAKE TCSs. Things are tightly packed in the
|
|
* case that (ncpt < MAX_CMDS_PER_TCS). That is if ncpt = 2 and
|
|
* MAX_CMDS_PER_TCS = 16 then bit[2] = the first bit in 2nd TCS.
|
|
*/
|
|
struct tcs_group {
|
|
struct rsc_drv *drv;
|
|
int type;
|
|
u32 mask;
|
|
u32 offset;
|
|
int num_tcs;
|
|
int ncpt;
|
|
const struct tcs_request *req[MAX_TCS_PER_TYPE];
|
|
DECLARE_BITMAP(slots, MAX_TCS_SLOTS);
|
|
};
|
|
|
|
/**
|
|
* struct rpmh_request: the message to be sent to rpmh-rsc
|
|
*
|
|
* @msg: the request
|
|
* @cmd: the payload that will be part of the @msg
|
|
* @completion: triggered when request is done
|
|
* @dev: the device making the request
|
|
* @err: err return from the controller
|
|
* @needs_free: check to free dynamically allocated request object
|
|
*/
|
|
struct rpmh_request {
|
|
struct tcs_request msg;
|
|
struct tcs_cmd cmd[MAX_RPMH_PAYLOAD];
|
|
struct completion *completion;
|
|
const struct device *dev;
|
|
int err;
|
|
bool needs_free;
|
|
};
|
|
|
|
/**
|
|
* struct rpmh_ctrlr: our representation of the controller
|
|
*
|
|
* @cache: the list of cached requests
|
|
* @cache_lock: synchronize access to the cache data
|
|
* @dirty: was the cache updated since flush
|
|
* @batch_cache: Cache sleep and wake requests sent as batch
|
|
*/
|
|
struct rpmh_ctrlr {
|
|
struct list_head cache;
|
|
spinlock_t cache_lock;
|
|
bool dirty;
|
|
struct list_head batch_cache;
|
|
};
|
|
|
|
/**
|
|
* struct rsc_drv: the Direct Resource Voter (DRV) of the
|
|
* Resource State Coordinator controller (RSC)
|
|
*
|
|
* @name: Controller identifier.
|
|
* @tcs_base: Start address of the TCS registers in this controller.
|
|
* @id: Instance id in the controller (Direct Resource Voter).
|
|
* @num_tcs: Number of TCSes in this DRV.
|
|
* @rsc_pm: CPU PM notifier for controller.
|
|
* Used when solver mode is not present.
|
|
* @cpus_in_pm: Number of CPUs not in idle power collapse.
|
|
* Used when solver mode is not present.
|
|
* @tcs: TCS groups.
|
|
* @tcs_in_use: S/W state of the TCS; only set for ACTIVE_ONLY
|
|
* transfers, but might show a sleep/wake TCS in use if
|
|
* it was borrowed for an active_only transfer. You
|
|
* must hold the lock in this struct (AKA drv->lock) in
|
|
* order to update this.
|
|
* @lock: Synchronize state of the controller. If RPMH's cache
|
|
* lock will also be held, the order is: drv->lock then
|
|
* cache_lock.
|
|
* @tcs_wait: Wait queue used to wait for @tcs_in_use to free up a
|
|
* slot
|
|
* @client: Handle to the DRV's client.
|
|
*/
|
|
struct rsc_drv {
|
|
const char *name;
|
|
void __iomem *tcs_base;
|
|
int id;
|
|
int num_tcs;
|
|
struct notifier_block rsc_pm;
|
|
atomic_t cpus_in_pm;
|
|
struct tcs_group tcs[TCS_TYPE_NR];
|
|
DECLARE_BITMAP(tcs_in_use, MAX_TCS_NR);
|
|
spinlock_t lock;
|
|
wait_queue_head_t tcs_wait;
|
|
struct rpmh_ctrlr client;
|
|
};
|
|
|
|
int rpmh_rsc_send_data(struct rsc_drv *drv, const struct tcs_request *msg);
|
|
int rpmh_rsc_write_ctrl_data(struct rsc_drv *drv,
|
|
const struct tcs_request *msg);
|
|
void rpmh_rsc_invalidate(struct rsc_drv *drv);
|
|
|
|
void rpmh_tx_done(const struct tcs_request *msg, int r);
|
|
int rpmh_flush(struct rpmh_ctrlr *ctrlr);
|
|
|
|
#endif /* __RPM_INTERNAL_H__ */
|